b3dca51216
CLDC-3753: Update soft income validations ( #2779 )
...
* CLDC-3753: Update soft income validations
* Update tests
* Fix linting
* Include reference to informative text translations copy
* Combine min and max checks for income based on ecstat
* Fixes
* Update tests
11 months ago
6c10172c78
CLDC-3755 Add 2025 shared ownership subsection ( #2782 )
...
* Add shared ownership initial purchase subsection
* Display correct subsection based on year
* Update some content
* Update LivingBeforePurchase routing
* Update routing and check for page existence in guidance
* Add management fee questions
* Only check the subsections relevant to the form
* Update content
* Update financial calculations text
12 months ago
542565ed85
Use subsection copy key ( #2792 )
...
* CLDC-3766: Ensure copy for Q78 is found correctly
* Fix tests
* Use subsection copy key in defaults and remove explit keys that are now defaults
* Replace other uses of subsection.id interpolation in copy keys
* Test copy key when specified on subsection
* Update tests
* Update privacy notice page tests
* More test fixes
12 months ago
502d038e9e
CLDC-3752: Sales - Hide questions if a staircasing transaction (25/26) ( #2780 )
...
* Do not ask questions from these sections when it's a staircase transaction
* Hide section/subsections from task list
* Add tests
* Fix lint
* Move logic to section model
12 months ago
bc1fe83750
CLDC-3757: Sales - Change values in validation check for Q84 (25/26) ( #2781 )
...
* Update 2025 version of validation check
* Update validation for 2025
* Put two if statements into one
* Different approach to comparing dates
* Alternative method to compare dates
* Update tests
12 months ago
4dc323059f
CLDC-3738: Sales - Update household characteristics Q29 and Q38 (25/26) ( #2774 )
...
* Create 2025 versions of these questions
* Remove blank line
* Update copy and use 2025 version of question
* Add tests
* Update depends on
* Update question number
* Update test
* Remove depends_on companybuy which has been removed
* Fix lint
12 months ago
6fb1384364
Remove mortgage lender questions for 2025 discounted sales ( #2784 )
12 months ago
aeae0c1806
CLDC-3766: Ensure copy for sales Q78 is found correctly for 2024 logs ( #2790 )
...
* CLDC-3766: Ensure copy for Q78 is found correctly
* Fix tests
12 months ago
c8a36fd3a6
Move sales staircasing question ( #2777 )
...
* Change order
* Update test
12 months ago
b87c107f25
Route only to buyer questions for staircase transactions ( #2765 )
12 months ago
10de485408
CLDC-3698 Rename household needs to other household information for sales ( #2772 )
...
* Rename household needs occurences
* Rename files
12 months ago
8dab730c54
CLDC-3704: Allow equity/stairowned/stairbought to have 1 decimal place ( #2746 )
...
* CLDC-3666: Pull sales financial validations into translations file
* CLDC-3704: Allow equity/stairowned/stairbought to have 1 decimal place
* Fix lint for migration
* Fix tests
* Fix sale information validations tests
* Fix lint
* Fix form spec
* Don't expect unexpected cashdis error
12 months ago
fbeaee9368
CLDC-3733: Adjust ordering for working situation question ( #2762 )
...
* CLDC-3733: Adjust ordering for working situation question
* Fix tests
12 months ago
4886cdbe36
CLDC-3722: Sales - Remove from Q5 'outright or other sale' answer option (25/26) ( #2752 )
12 months ago
1a07e37049
CLDC-3717: Sales - Remove Q9 (Is the buyer a company?) (25/26) ( #2755 )
12 months ago
154f4d9538
CLDC-3721: Sales - Move Q78 (Is this a staircasing transaction?) to setup section (25/26) ( #2751 )
12 months ago
3125171edf
CLDC-3718: Sales - Remove Q10 (Will any buyers live in the property?) (25/26) ( #2757 )
12 months ago
e2123f8b9d
CLDC-3736: Don't route to property building type or wheelchair accessibility for staircasing sales from 2025 ( #2761 )
...
* CLDC-3736: Don't route to property building type or wheelchair accessibility for staircasing sales from 2025
* Add tests for routed_to?
* Fix test
12 months ago
7d407ab4c6
CLDC-3739: Remove buyer orgs question from 2025 ( #2766 )
12 months ago
30442fcee2
CLDC-3735: Sales - Move Q19 (What type of unit is the property?) (25/26) ( #2760 )
12 months ago
b681b101f3
CLDC-3715: Sales - Remove Q8 (What is the type of outright sale?) (25/26) ( #2753 )
12 months ago
224e49825e
CLDC-3719: Move sale completion date question to start of setup section ( #2750 )
...
* CLDC-3716: Allow 25/26 form use on dev, review, and staging environments
* Remove empty line
* CLDC-3719: Move sale completion date question to start of setup section
* Fix test
* Update test fixture csv order
12 months ago
6fb29ade6b
CLDC-3712: Sales Form Updates ( #2756 )
1 year ago
51bc0cffeb
CLDC-3665 Extract sale information copy ( #2711 )
...
* Extract shared ownership copy
* Extract discounted ownership copy
* rename files
* CLDC-3665 Extract sale information soft validations (#2712 )
* Extract shared ownership copy
* Extract shared ownership soft validations
* Extract discounted ownership validations
* Fix mappings
* Update some translations
* Remove full stops
1 year ago
625b0c757c
CLDC-3668 Extract guidance copy ( #2737 )
...
* Extract guidance copy
* Update tests and lint
1 year ago
f9922c1ba4
CLDC-3654: Copy changes - Sales property information questions ( #2694 )
1 year ago
a00489b7d7
CLDC-3659: Pull sales household situation questions copy into translation file ( #2701 )
...
* CLDC-3659: Pull sales household situation questions copy into translation file
* Fix header->question_text
1 year ago
1ffc440342
CLDC-3656 Extract household characteristics question and page copy to translation files ( #2702 )
...
* Extract question and page copy to translation files
* Refactor 2 question pages
* Readd removed answer options
* Fix missing/wrong age mappings
* Update some pages/questions
* Update tests
* CLDC-3656 Extract household characteristics soft validations (#2707 )
* Extract retirement confirmation questions
* Extract old persons shared ownership confirmation questions
* Extract income confirmation questions
* Extract buyer live-in value check page and question copy to translation files
* Extract student not a child confirmation questions and page copy to translation files
* Extract partner under 16 value check page and question copy to translation files
* Extract partner under 16 value check page and question copy to translation files
* Update some missing/wrong keys
* Update some keys on 2023
* Update BU tests
1 year ago
0799ff7a36
CLDC-3658 Extract household needs copy ( #2718 )
...
* Extract household needs subsection copy
* Extract housing needs soft validations copy
* Add new lines at the end of some files
1 year ago
9bd3389c84
CLDC-3655 Extract property information validations ( #2700 )
...
* Extract property information validations
* Refactor possesive variable from errors
1 year ago
ace6a599b0
CLDC-3664 Extract income and benefits copy ( #2709 )
...
* Refactor sales household pages and questions
* Refactor sales income and benefits soft validations
* Update subsection test
* Fix income copy keys
* Update subsection test
* Add missing question to translations
* Fix typo
* Add prevshared for 2024
1 year ago
731dcc9325
CLDC-3650: Move copy for sales setup section to translation files ( #2672 )
1 year ago
961f1b7f93
CLDC-3423: Add sales soft validation for person over retirement age not retired ( #2644 )
...
* CLDC-3423: Add sales soft validation for person over retirement age not retired
* Add rake task to recalculate log status when new validation is triggered
1 year ago
8516aa1f23
Don't hide person known question in CYA ( #2641 )
1 year ago
459420d7ee
CLDC-3541 Update sales financial validations ( #2546 )
...
* CLDC-3569 Update social homebuy errors (#2541 )
* Split questions
* Update the error message
* Add guidance
* Add back the headers
* Refactor depends_on
* Refactor further
* CLDC-3569 Update missed errors (#2548 )
* Update some skipped error messages
* Remove repeating deposit question
* CLDC-3571 Discounted ownership validation (#2547 )
* Rename discount to deposit discount
* Split about price rtb questions
* Update error message
* Update guidance partial
* Fix top_guidance_partial method
* Split about_price_not_rtb
* Update guidance partial and validation
* Fix bulk upload test
* Update deposit routed_to and guidance
* Refactor guidance links into a helper (#2551 )
* Refactor guidance links into a helper
* Refactor discounted ownership guidance
* CLDC-3570 Validations all other shared ownership types (#2550 )
* Update "all other shared ownership" errors
* CLDC-3571 Update outright sale financial validations (#2549 )
* Update outright sale validation message
* Add outright sale guidance
* Update duplicate page id
* User guidance helper
* Fix up financial equations content (#2552 )
* Tweak shared ownership validation wording
* Add top_guidance_partial to missed shared ownership questions
* Update discounted ownership validation message when there's no grant
* Update discounted sale guidance and errors
* Lint and update test
* Update BU test
* Update test
* CLDC-3569 Update guidance for shared ownership without mortgage (#2562 )
* Update how we display errors for BU
* Update guidance for shared ownership
* Add header to mortgage used question
* Update shared ownership guidance
* Update spacing (#2569 )
* Fix spacing again (#2570 )
* Update discounted ownership guidance (#2582 )
* Update discounted ownership guidance
* Add top guidance partial to outright sale
* Update outright sale guidance content
* Update model test
---------
Co-authored-by: Manny Dinssa <44172848+Dinssa@users.noreply.github.com>
1 year ago
8af9c255e3
CLDC-3567-Remove-DLUHC-references-from-CORE-pages ( #2530 )
1 year ago
ab4915c2aa
CLDC-2480 Allow deleting organisations ( #2459 )
...
* Add delete confirmation page
* Allow deleting organisation
* Add delete button
* Do not display deleted organisations as an option
* Update policy
* Display informative text and delete org resources
* lint
* Update organisation labels to show when deleted
* Refactor organisation label
* Update more labels
* Remove deleted orgs from schemes and autorize delete_confirmation
* Fix tests
1 year ago
07750ef26c
CLDC-3289 Avoid freezing time in tests (part 1) ( #2421 )
...
* Refactor tests #1
* Refactor helper tests
* Refactor model form tests
* Remove Timecop.returns
* Update tasklist helper tests
* Update task list helper
* Fix test
* Fix flaky search test
* Refactor
1 year ago
5696e4b81e
Cldc 3452 remove dont know option from mortgage used when invalid ( #2470 )
...
* initial spec file refactor
remove create for build, extract form to own variable, remove non-valuable tests
run time from 0.29s to0.11s
* refactor to ensure that the questions ownershipsch instance variable and the value of ownershipsch on the log is the same in tests
* delete page test file which is not testing anything meaningful
* add error messages to the I18n yml
* update tests for the validations
* update validation logic
* update tests for the mortgage used question
* update the mortgage used question displayed answer options
* update bulk upload specs to reflect error message updates
* make use of brackets consistent within validation method
1 year ago
34faa74a6c
CLDC-3447: Allow decimal discount percentage and increased validation tolerance ( #2427 )
...
* CLDC-3447: Allow decimal discount percentage and increased validation tolerance
* Update tests to use decimal discount
* Disable extra borrowing soft validation for 2024 onwards
* CLDC-3447: Make tolerance inclusive
* Fix linting error
* Fix method call
* Only change strictness when discount is present
* Remove blank line
1 year ago
7d871edf74
CLDC-3482 Correct routing to property LA ( #2449 )
...
* Correct routing to property LA
* Add rake task to update LAs
1 year ago
730b07ab25
CLDC-3426: Ensure outright sale section can be completed with mortgage used unknown ( #2399 )
...
* CLDC-3426: Ensure outright sale section can be completed with mortgage used unknown
* CLDC-3426: fix test
* CLDC-3426: Refactor tests
* Avoid unnecessarily creating users in sales log factory
* Fix test that inexplicably relies on creation
2 years ago
7e638657fb
CLDC-3354 Show user input on address selection page ( #2374 )
...
* Display input playback on the page
* Add input playback to uprn selection pages
2 years ago
30bb983e78
CLDC-3412 set derived? on mortgage amount ( #2396 )
...
* Set derived on mortgage amount
* Refactor
2 years ago
ad488bb5ce
CLDC-3345 Add assigned_to to the exports ( #2391 )
...
* Empty
* CLDC-3345 Rename created_by to assigned_to (#2372 )
* Rename created_by to assigned_to
* Replace created_by with assigned_to
* Update created_by to assigned_to in exports, remove blank assigned to
* CLDC-3345 Add and set created_by fields (#2373 )
* Add created_by
* Update existing created_by values
* Set created_by on single log
* Set created_by on BU
* Add created_by to exports
* feat: update since last merge
---------
Co-authored-by: natdeanlewissoftwire <nat.dean-lewis@softwire.com>
* Fix papertrail create version
---------
Co-authored-by: natdeanlewissoftwire <nat.dean-lewis@softwire.com>
2 years ago
b83be837ee
CLDC-3377 Remove hint text from buyer 1 questions ( #2376 )
...
* Remove hint text from buyer 1 questions
* Update working situation answer options
* Update missed hint text
* Update csv tests
2 years ago
a0215d45ef
CLDC-3089 Make absolute skip/back links relative ( #2348 )
...
* Empty-Commit
* feat: make skip links relative
* feat: make scheme back links relative
* feat: update tests
2 years ago
d2518d7c38
CLDC-2481: Add ability to disable organisations ( #2293 )
...
* CLDC-2481: Add ability to disable organisations.
* CLDC-2481: Add ability to disable organisations
* Tidy up tests
* CLDC-2481: Review markups
* CLDC-2481: Fix location and scheme filters
* Add banners for stock owners and managing agents
* Update view test
---------
Co-authored-by: Kat <katrina@kosiak.co.uk>
2 years ago
a65cc59713
CLDC-2479 Allow deleting users ( #2288 )
...
* Add delete confirmation page
* Add status to the user
* Allow deleting user
* Refactor sign_in user in tests
* Add delete user button and update policy
* Update user policy
* Do not display deleted users as an answer option
* Update user table and details
* Do not show deleted users
* Disable delete user on production
* Update test
2 years ago
2e7cb56c70
CLDC-3351: Clear deposit in situations where it is no longer derived ( #2354 )
...
* CLDC-3351: Clear deposit in situations where it is no longer derived
2 years ago
Rachael Booth
kosiakkatrina
Manny Dinssa
Arthur Campbell
natdeanlewissoftwire
Robert Sullivan