submit-social-housing-lettings-and-sales-data

Commit Graph

Author	SHA1	Message	Date
natdeanlewissoftwire	b543c57cf3	refactor: lint	2 years ago
natdeanlewissoftwire	2753ee3f85	Merge remote-tracking branch 'origin/CLDC-1917-allow-23-24-form' into CLDC-1917-allow-23-24-form # Conflicts: # app/models/validations/date_validations.rb	2 years ago
natdeanlewissoftwire	673800053e	feat: move to setup validation	2 years ago
natdeanlewissoftwire	f50407e46f	feat: make tests pass	2 years ago
natdeanlewissoftwire	9d2019b966	feat: make tests pass	2 years ago
natdeanlewissoftwire	d628fdc2ae	refactor: naming	2 years ago
natdeanlewissoftwire	02789668d9	Merge branch 'main' into CLDC-1917-allow-23-24-form	2 years ago
natdeanlewissoftwire	5f5204cbcb	feat: align with saledate validation structure	2 years ago
natdeanlewissoftwire	513e0c0b26	Merge branch 'main' into CLDC-1917-allow-23-24-form # Conflicts: # config/initializers/feature_toggle.rb	2 years ago
natdeanlewissoftwire	6be860db28	CLDC-868 purchase price validations PO review (#1285 ) * feat: wip behaviour * feat: hide in cya * feat: show in cya * feat: purchase price range service and rake task * feat: fix hodate validation and use purchase price ranges * db:update * feat: more saledate -> exdate fixing * feat: add min and max conditional text * refactor: linting * refactor: remove duplicated behaviour * refactor: linting * feat: update tests * test: add validation tests * test: add purchase price rangeimport service tests * refactor: linting * feat: allow translation text and title text to display currency formatting even when not a log field * feat: use i18n * feat: update i18n * refactor: pratical -> practical * refactor: linting * refactor: revert unnecessary change * feat: respond to PR comments * tests: update after merge * feat: improve currency interruption screen display * feat: update docs * feat: fix typo * feat: missing end after merge * feat: respond to PR comments * feat: add soft validation to beds and la pages * db:update * feat: revert saledate/exdate work * feat: revert saledate/exdate work * feat: revert saledate/exdate work * feat: revert saledate/exdate work * feat: revert saledate/exdate work * feat: PO comment responses * tests: update * refactor: linting * refactor: simplification * refactor: railsification * test: fix * refactor: use number_to_currency units * refactor: remove duplicated copy * db:update * feat: add value check for discounted and outright sale * feat: rename files * test: update * test: update * test: update * db: update	2 years ago
natdeanlewissoftwire	2e279d251d	CLDC-1976 remove duplicate purchase price page (#1324 ) * feat: remove duplicated purchase price page and delete as it's not used elsewhere * test: update * feat: update * db: update	2 years ago
natdeanlewissoftwire	223f142060	CLDC-1812 Length of stay in property before purchase updates (#1296 ) * feat: conditional question * db:update * tests: add tests for year dependent behaviour * db: migrate	2 years ago
Phil Lee	06a48cecda	bulk upload handles social housing first time let (#1337 ) - this question is present in the web form - however is not surfaced for bulk upload - therefore the answer must be inferred	2 years ago
natdeanlewissoftwire	609c9ba91e	feat: add hidden_in_check_answers (#1325 )	2 years ago
Jack	f1c7b8188f	[CLDC-1915] Update privacy notice (#1332 ) * [CLDC-1915] Update privacy notice * Use generic notice	2 years ago
natdeanlewissoftwire	59c19c1993	refactor: simplification	2 years ago
natdeanlewissoftwire	a407187120	refactor: revert previous	2 years ago
natdeanlewissoftwire	7a310bf193	refactor: simplification	2 years ago
kosiakkatrina	66a528bd48	CLDC-1860 Change location question header for 23/24 (#1291 ) * Change location question header for 23/24 * Stup form in page tests	2 years ago
Jack	68a1c17ae5	CLDC-1916 Handle sales forms and validations during comparison period (#1317 ) * Add more time helpers * CLDC-1916 Validate this and next year start date in saleslogs * Add capybara-screenshot * Use sales_in_crossover_period?	2 years ago
Phil Lee	5f9151158a	CLDC-1889 Bulk upload schemes + locations (#1329 ) * bulk upload validates scheme data * bulk upload schemes can use new core IDs * bulk upload handles locations	2 years ago
David May-Miller	4a31906d45	CLDC-853 Added validations for sales income2 (#1101 ) * CLDC-853 Added hard validations for sales income2 * CLDC-853 Added soft validation for sales income2 * CLDC-853 Fix tests broken by new code * CLDC-853 Add new tests for new page and refactor slightly * CLDC-853 Fix linting errors * CLDC-853 Rename migration and update schema version * CLDC-853 Fix broken sales income2 test * CLDC-853 Rename migration * CLDC-853 Move income 2 to cya card 2 and commonise combined income validation * CLDC-853 Actually use the validate_combined_income method * combine duplicate methods after rebase, ensure hard validations are triggered on all relevant fields * move validation on child income to financial validations to stop it being triggered on lettings logs, minor amendments to tests broken by changes * revamp financial validations tests against income to reflect updates * amend child income validation to reflect specifications and write tests to cover this validation * correct linting errors and play a little code golf * change copy for some validations, add sales log method and amend interruption screen helper to support this * extract duplicate code to private method * update buyer 1 and 2 income value check to be consistent * remove ecstat from income checks, the only ecstat we care about is child which is dealt with elsewhere * rename constant struct with same anme as existing variable * amend tests to reflect the chagnes in validations and copy * enable currency formatting of numbers for inserting into informative_text or title_text * update evil test in form handler spec * rebase and fix conflicts and tests * change a variable name and correct minor rebase errors * update interruption screen helper tests * correct linting errors, minor test failure and typo * add tests for new sales log method for formatting currency * fix merge conflicts --------- Co-authored-by: Arthur Campbell <arfa.camble@gmail.com>	2 years ago
Jack	e7e67c8b58	Bump depts to fix security issues (#1328 ) * Bump depts * Fix deprecation	2 years ago
natdeanlewissoftwire	2a83fbc198	feat: remove instantiation, update tests	2 years ago
natdeanlewissoftwire	bf58939e4f	feat: re-instantiate	2 years ago
natdeanlewissoftwire	c427f720b5	feat: wip remove instance variables so tests work	2 years ago
natdeanlewissoftwire	13390bb67a	feat: instantiate suffixes	2 years ago
natdeanlewissoftwire	e49dedd59a	refactor: typo	2 years ago
Phil Lee	01b957cc10	better validation on bulk upload start year (#1319 )	2 years ago
James Rose	b24ab538ce	Update collection year end dates for 2022 onwards (#1312 ) The source of truth for this update is: https://digital.dclg.gov.uk/confluence/pages/viewpage.action?spaceKey=MC&title=CORE+And+Collection+Years	2 years ago
natdeanlewissoftwire	47343613f9	feat: make validation use correct end_date	2 years ago
natdeanlewissoftwire	0e4c785018	feat: inequality tweak for crossover period	2 years ago
Phil Lee	5490e2ecb0	CLDC-1892 Bulk upload validation for managing organisation (#1315 ) * bulk upload validation for owning org * block log creation at row parser level * bubble up block_log_creation so it blocks logs * owning org id looks up serveral fields * validate bulk upload managing org	2 years ago
natdeanlewissoftwire	3d15283e43	Merge remote-tracking branch 'origin/CLDC-1917-allow-23/24-form' into CLDC-1917-allow-23/24-form	2 years ago
natdeanlewissoftwire	73a333fb68	refactor: linting	2 years ago
natdeanlewissoftwire	e21b7b81f0	Merge branch 'main' into CLDC-1917-allow-23/24-form	2 years ago
natdeanlewissoftwire	1913f6a685	db:update	2 years ago
natdeanlewissoftwire	0595b32254	Merge branch 'main' into CLDC-1917-allow-23/24-form # Conflicts: # db/schema.rb	2 years ago
natdeanlewissoftwire	3929a2c08b	feat: add more tests	2 years ago
James Rose	7c62d8b4a6	Change CDS export archive names from quarter to financial year (#1309 ) - We previously pushed logs into archives categorised by the quarter that they were created for. - CDS requested that instead we push everything into a larger bucket seperated by FY.	2 years ago
Phil Lee	02d8247f59	tweak bulk upload validation (#1302 ) - LA referral not permitted if general needs and now also if owning org is an LA	2 years ago
James Rose	c19b200e84	Add arcturus.net to whitelisted delivery domains (#1316 ) - We whitelist domains that we will deliver to in non-production environments - This adds arcturus.net so that they can conduct their pentest	2 years ago
Phil Lee	26aa5244bb	mass update gems used by docs (#1313 )	2 years ago
Jack	b6ff8bf896	CLDC-1909 Add 2023-2024 collection year filter (#1314 )	2 years ago
natdeanlewissoftwire	f4608d046f	test: update	2 years ago
natdeanlewissoftwire	fc2302e312	test: update	2 years ago
Jack	65bde2b7f5	CLDC-1903 Infer first time property let question (#1300 )	2 years ago
Jack	d8689c30a2	CLDC-1968 Add review page for Sales logs (#1292 ) * CLDC-1968 Add review page for Sales logs * use log#sales? * Do not use type checking	2 years ago
James Rose	293077695c	Allow issues/pull-request write permissions for GitHub token (#1310 )	2 years ago
kosiakkatrina	b973e8348e	CLDC-1861 Update options order for lead tenant's working situation (#1289 ) * Switch the first two options so Full time comes before Part time * Enable dates validations on staging	2 years ago

1 2 3 4 5 ...

2012 Commits (b543c57cf3ae28c4cd432883a5e75759efdc8307) All Branches Search

2012 Commits (b543c57cf3ae28c4cd432883a5e75759efdc8307)

All Branches