b3dca51216
CLDC-3753: Update soft income validations ( #2779 )
...
* CLDC-3753: Update soft income validations
* Update tests
* Fix linting
* Include reference to informative text translations copy
* Combine min and max checks for income based on ecstat
* Fixes
* Update tests
1 month ago
6c10172c78
CLDC-3755 Add 2025 shared ownership subsection ( #2782 )
...
* Add shared ownership initial purchase subsection
* Display correct subsection based on year
* Update some content
* Update LivingBeforePurchase routing
* Update routing and check for page existence in guidance
* Add management fee questions
* Only check the subsections relevant to the form
* Update content
* Update financial calculations text
1 month ago
542565ed85
Use subsection copy key ( #2792 )
...
* CLDC-3766: Ensure copy for Q78 is found correctly
* Fix tests
* Use subsection copy key in defaults and remove explit keys that are now defaults
* Replace other uses of subsection.id interpolation in copy keys
* Test copy key when specified on subsection
* Update tests
* Update privacy notice page tests
* More test fixes
1 month ago
671232daa9
CLDC-3734 Add LA in England validation for 2025 ( #2763 )
...
* Add LA in England validation for 2025
* Validate supported housing logs
* Add error message to the date
* Update error messages
* lint
* Fix error messages for date
* Update no address found soft validation
* Update validation messages
1 month ago
502d038e9e
CLDC-3752: Sales - Hide questions if a staircasing transaction (25/26) ( #2780 )
...
* Do not ask questions from these sections when it's a staircase transaction
* Hide section/subsections from task list
* Add tests
* Fix lint
* Move logic to section model
1 month ago
bc1fe83750
CLDC-3757: Sales - Change values in validation check for Q84 (25/26) ( #2781 )
...
* Update 2025 version of validation check
* Update validation for 2025
* Put two if statements into one
* Different approach to comparing dates
* Alternative method to compare dates
* Update tests
1 month ago
4dc323059f
CLDC-3738: Sales - Update household characteristics Q29 and Q38 (25/26) ( #2774 )
...
* Create 2025 versions of these questions
* Remove blank line
* Update copy and use 2025 version of question
* Add tests
* Update depends on
* Update question number
* Update test
* Remove depends_on companybuy which has been removed
* Fix lint
1 month ago
6fb1384364
Remove mortgage lender questions for 2025 discounted sales ( #2784 )
1 month ago
aeae0c1806
CLDC-3766: Ensure copy for sales Q78 is found correctly for 2024 logs ( #2790 )
...
* CLDC-3766: Ensure copy for Q78 is found correctly
* Fix tests
1 month ago
c8a36fd3a6
Move sales staircasing question ( #2777 )
...
* Change order
* Update test
2 months ago
b87c107f25
Route only to buyer questions for staircase transactions ( #2765 )
2 months ago
10de485408
CLDC-3698 Rename household needs to other household information for sales ( #2772 )
...
* Rename household needs occurences
* Rename files
2 months ago
0083485b42
CLDC-3690 Extract lettings property validations copy ( #2742 )
...
* Extract lettings property validations copy
* Update uprn question
* Remove redundant validations (can't trigger them because on inferrance)
2 months ago
fbeaee9368
CLDC-3733: Adjust ordering for working situation question ( #2762 )
...
* CLDC-3733: Adjust ordering for working situation question
* Fix tests
2 months ago
4886cdbe36
CLDC-3722: Sales - Remove from Q5 'outright or other sale' answer option (25/26) ( #2752 )
2 months ago
1a07e37049
CLDC-3717: Sales - Remove Q9 (Is the buyer a company?) (25/26) ( #2755 )
2 months ago
154f4d9538
CLDC-3721: Sales - Move Q78 (Is this a staircasing transaction?) to setup section (25/26) ( #2751 )
2 months ago
3125171edf
CLDC-3718: Sales - Remove Q10 (Will any buyers live in the property?) (25/26) ( #2757 )
2 months ago
e2123f8b9d
CLDC-3736: Don't route to property building type or wheelchair accessibility for staircasing sales from 2025 ( #2761 )
...
* CLDC-3736: Don't route to property building type or wheelchair accessibility for staircasing sales from 2025
* Add tests for routed_to?
* Fix test
2 months ago
7d407ab4c6
CLDC-3739: Remove buyer orgs question from 2025 ( #2766 )
2 months ago
30442fcee2
CLDC-3735: Sales - Move Q19 (What type of unit is the property?) (25/26) ( #2760 )
2 months ago
b681b101f3
CLDC-3715: Sales - Remove Q8 (What is the type of outright sale?) (25/26) ( #2753 )
2 months ago
224e49825e
CLDC-3719: Move sale completion date question to start of setup section ( #2750 )
...
* CLDC-3716: Allow 25/26 form use on dev, review, and staging environments
* Remove empty line
* CLDC-3719: Move sale completion date question to start of setup section
* Fix test
* Update test fixture csv order
2 months ago
61eb0057f6
CLDC-3693: Extract shared validations ( #2744 )
...
* Extract lettings household validation from shared validations
* Extract lettings setup validation from shared validations
* Extract only shared validations
2 months ago
020b8a4f4c
CLDC-3686 Extract lettings soft validations copy ( #2735 )
...
* Extract household characteristics soft validations
* Extract household needs soft validations
* Extract household situation soft validations
* Extract income and benefits soft validations
* Extract property information soft validations
* Update tests and 2024 soft validations
* Update some test forms
* Re-add sales validation
* Update BU tests
* Fixes
* Change higher to longer
* Update model test
* Update model test
* Add 2025 translations copied from 2024
* Update pregnancy and retirement copy
---------
Co-authored-by: Manny Dinssa <44172848+Dinssa@users.noreply.github.com>
Co-authored-by: Rachael Booth <rachael.booth@softwire.com>
2 months ago
6fb29ade6b
CLDC-3712: Sales Form Updates ( #2756 )
2 months ago
51bc0cffeb
CLDC-3665 Extract sale information copy ( #2711 )
...
* Extract shared ownership copy
* Extract discounted ownership copy
* rename files
* CLDC-3665 Extract sale information soft validations (#2712 )
* Extract shared ownership copy
* Extract shared ownership soft validations
* Extract discounted ownership validations
* Fix mappings
* Update some translations
* Remove full stops
2 months ago
3cda5adf5c
CLDC-3683 Extract lettings household situation copy ( #2730 )
...
* Extract lettings household situation copy
* Update wrong copy, remove duplicate keys
2 months ago
625b0c757c
CLDC-3668 Extract guidance copy ( #2737 )
...
* Extract guidance copy
* Update tests and lint
2 months ago
f9922c1ba4
CLDC-3654: Copy changes - Sales property information questions ( #2694 )
2 months ago
f2f44329f3
CLDC-3684 Extract lettings tenancy information copy ( #2731 )
...
* Extract lettings tenancy information copy
* Fix flaky merged schemes test
2 months ago
3424cbc550
CLDC-3366: Use single page for rent soft validation ( #2724 )
...
* CLDC-3366: Use single page for rent soft validation
* Fix tests
2 months ago
ff3f789acc
CLDC-3681 Extract lettings household characteristics copy ( #2728 )
...
* Extract lettings household characteristics copy
* Update cya labels for age known
* Update missing keys and copy
2 months ago
1ffc440342
CLDC-3656 Extract household characteristics question and page copy to translation files ( #2702 )
...
* Extract question and page copy to translation files
* Refactor 2 question pages
* Readd removed answer options
* Fix missing/wrong age mappings
* Update some pages/questions
* Update tests
* CLDC-3656 Extract household characteristics soft validations (#2707 )
* Extract retirement confirmation questions
* Extract old persons shared ownership confirmation questions
* Extract income confirmation questions
* Extract buyer live-in value check page and question copy to translation files
* Extract student not a child confirmation questions and page copy to translation files
* Extract partner under 16 value check page and question copy to translation files
* Extract partner under 16 value check page and question copy to translation files
* Update some missing/wrong keys
* Update some keys on 2023
* Update BU tests
2 months ago
0799ff7a36
CLDC-3658 Extract household needs copy ( #2718 )
...
* Extract household needs subsection copy
* Extract housing needs soft validations copy
* Add new lines at the end of some files
2 months ago
ace6a599b0
CLDC-3664 Extract income and benefits copy ( #2709 )
...
* Refactor sales household pages and questions
* Refactor sales income and benefits soft validations
* Update subsection test
* Fix income copy keys
* Update subsection test
* Add missing question to translations
* Fix typo
* Add prevshared for 2024
2 months ago
731dcc9325
CLDC-3650: Move copy for sales setup section to translation files ( #2672 )
3 months ago
b1ad8a1520
CLDC-3633++ Full stops in error messages & capitalisation within messages ( #2674 )
3 months ago
961f1b7f93
CLDC-3423: Add sales soft validation for person over retirement age not retired ( #2644 )
...
* CLDC-3423: Add sales soft validation for person over retirement age not retired
* Add rake task to recalculate log status when new validation is triggered
3 months ago
53c3b3e61a
CLDC-3633 Full stops in error messages ( #2628 )
...
* Make full stops consistent in error messages
* Fix test
* Update few hardcoded errors
* Update join in remaining row parsers
* Update some more tests
* Update more hard coded BU errors
* Fix typo I introduced - bedrooms to bedroom
---------
Co-authored-by: Kat <katrina@kosiak.co.uk>
Co-authored-by: kosiakkatrina <54268893+kosiakkatrina@users.noreply.github.com>
3 months ago
8516aa1f23
Don't hide person known question in CYA ( #2641 )
3 months ago
d5f2424247
CLDC-3576 Update soft pregnancy validation ( #2640 )
...
* Update soft pregnancy validation
* Fix tests
3 months ago
459420d7ee
CLDC-3541 Update sales financial validations ( #2546 )
...
* CLDC-3569 Update social homebuy errors (#2541 )
* Split questions
* Update the error message
* Add guidance
* Add back the headers
* Refactor depends_on
* Refactor further
* CLDC-3569 Update missed errors (#2548 )
* Update some skipped error messages
* Remove repeating deposit question
* CLDC-3571 Discounted ownership validation (#2547 )
* Rename discount to deposit discount
* Split about price rtb questions
* Update error message
* Update guidance partial
* Fix top_guidance_partial method
* Split about_price_not_rtb
* Update guidance partial and validation
* Fix bulk upload test
* Update deposit routed_to and guidance
* Refactor guidance links into a helper (#2551 )
* Refactor guidance links into a helper
* Refactor discounted ownership guidance
* CLDC-3570 Validations all other shared ownership types (#2550 )
* Update "all other shared ownership" errors
* CLDC-3571 Update outright sale financial validations (#2549 )
* Update outright sale validation message
* Add outright sale guidance
* Update duplicate page id
* User guidance helper
* Fix up financial equations content (#2552 )
* Tweak shared ownership validation wording
* Add top_guidance_partial to missed shared ownership questions
* Update discounted ownership validation message when there's no grant
* Update discounted sale guidance and errors
* Lint and update test
* Update BU test
* Update test
* CLDC-3569 Update guidance for shared ownership without mortgage (#2562 )
* Update how we display errors for BU
* Update guidance for shared ownership
* Add header to mortgage used question
* Update shared ownership guidance
* Update spacing (#2569 )
* Fix spacing again (#2570 )
* Update discounted ownership guidance (#2582 )
* Update discounted ownership guidance
* Add top guidance partial to outright sale
* Update outright sale guidance content
* Update model test
---------
Co-authored-by: Manny Dinssa <44172848+Dinssa@users.noreply.github.com>
4 months ago
1da04df30f
CLDC-3411 correct 24 25 bulk upload error messages on lettings and sales ( #2556 )
...
* Update error messages and sales parser
5 months ago
c3b85f2b50
CLDC-3411: Correct 24/25 bulk upload error messages on lettings and sales ( #2553 )
5 months ago
8af9c255e3
CLDC-3567-Remove-DLUHC-references-from-CORE-pages ( #2530 )
5 months ago
fb89b47b6f
CLDC-3520 order scheme locations ( #2499 )
...
* List in alphabetical order using second line of address (.i.e. hint/name)
5 months ago
8ce22d37c0
CLDC-3289 Avoid freezing time (part 3) ( #2445 )
...
* Refactor tests #1
* Update tasklist helper tests
* Update task list helper
* Fix test
* Rabase fixes
* Update model/validations tests
* Update som sales log specs
* Remove missing addresses csv tasks
* Update some tests for 2023 collection close
* More fixes
* Revert sales shared examples change
* Fix test
* Update test nemes, remove time stub
6 months ago
3adfb29143
CLDC-3290 Update some test setup ( #2466 )
...
* test prof in test context
* time reduced from ~1.4 to 0.27
* time reduced from ~1.1 to 0.7
* time reduced from ~0.13 to 0.07
* add testprof env variables to spec helper
* reorder gems for linting copmlaint
* Remove test-prof gem
---------
Co-authored-by: Kat <katrina@kosiak.co.uk>
6 months ago
f423ec1cd5
CLDC-3505 further fixes to tests for year hard end ( #2493 )
...
* further fixes
* Fix date / crossover issues
* Try changing form end dates
* Revert "Try changing form end dates"
This reverts commit e027e29cf06b87938d70
6 months ago
Rachael Booth
kosiakkatrina
Manny Dinssa
Arthur Campbell