baarkerlounger/submit-social-housing-lettings-and-sales-data - submit-social-housing-lettings-and-sales-data - Gitea: Git with a cup of tea

Author	SHA1	Message	Date
natdeanlewissoftwire	da00fa73f6	CLDC-2348 Purchaser code bug fix (#1638 ) * feat: assign purchaser_code for each year * refactor: lint * feat: add test that checks purchaser code assignment without explicitly calling a field	1 year ago
kosiakkatrina	79c4f9b74b	CLDC-2334 Add journey to fix soft validation errors only (#1615 ) * Sends a correct email if there are only soft validations * Add soft errors valid page * Add soft errors confirm page * Confirm the soft validations * Reuse the how to fix template for check soft validations email * Update email link * Move soft validation confirmation to processor * Correctly set the log status, remove redundant confirm_soft_validations * Redirect successful upload to logs index and display a success banner * Implement the soft validations only journey for sales logs * Display the soft validation errors on the soft-errors-valid page * Fix page alignment * Fix tests by mapping housingneeds in csv hepler * Add the sales soft validations to unpend_and_confirm_soft_validations * Change naming * Update method names * refactor * undo typo * Only set the existing soft validations for correct types * Fix path name * Add missing error mappings for location fields * Add missing tests and cancel button * Change some wording * Typos	1 year ago
kosiakkatrina	353facc893	CLDC-2304 Deduplicate sales logs in bulk upload (#1612 ) * Deduplicate 2022 sales logs * Don't run deduplication on staging * Do not create duplicate logs * Add deduplication to the 23/24 sales	1 year ago
Phil Lee	cf9d9550e9	CLDC-2344 Remove bulk upload minimum column check (#1621 ) # Context - https://digital.dclg.gov.uk/jira/browse/CLDC-2344 - So the reported bug and these change do not match 100% - As the reported bug should have already been resolved in an earlier change as the error message that was reported has already been removed from the system - These changes remove the check from sales plus a few minor tidy ups # Changes - Remove dead code around error threshold which is no longer used or needed - Inverted negative predicate to positive one, `incorrect_field_count` => `correct_field_count` - Remove `validate_min_columns` from sales bulk upload	1 year ago
natdeanlewissoftwire	6973ade8c4	CLDC-2262 Bulk upload clear invalid data to create forms (#1618 ) * feat: wip blank fields and dependent fields on upload tos ee if valid and can upload with missing info - this is not the exact ac on the ticket yet * feat: update seed * feat: wip commit * feat: add postcodenk error so can clear on validation * feat: add postcode validation back * feat: move la vals to shared and move and add tests * feat: add correct pluralisation to warning message * feat: add blank compound invalid fields methods * feat: update validations * feat: update pluralisation * refactor: lint * feat: clear errors associated with blanked values so log status is set correctly on creation * feat: validate instead * feat: avoid duplicated errors * feat: dont auto-refuse income, different to imports * feat: validate after every blank method * feat: delete la validator spec * tests: update * refactor: erblinting * refactor: cleanup * refactor: move pluralizer to helper * feat: copy update * feat: rename * feat: refactor to avoid redundant re-validations and test * refactor: rubocop * test: update * test: update * test: update * update sidekiq * feat: clear errors * feat: run clearing twice in case first clear creates different errors * feat: remove moved file * feat: undo validation file tweaks as shared/specific overlap could do with a more general refactor * feat: update tests	1 year ago
kosiakkatrina	d1f21a5890	CLDC-2031 Sales bulk upload (#1574 ) * Add sales csv parser * Create log creator and update row parser for sales * Add validations * Add status_cache to sales logs * Parse completed log * Add basic validations to the row parser * Fix details known and proplen mapping * Add setup section errors * Update sales log validator * tests * Add sales resume and summary pages * send the correct emails	2 years ago
Phil Lee	35de06e324	CLDC-2067 Bulk upload for lettings 23/24 (#1417 ) * refactor questions from validator to row parser * able to switch between bulk upload parsers - depending on what year we are processing * spec tooling to support bulk upload multi year * row parser now has year in namespacing * add static data for 2023 row parser * add placeholder to log to csv for specs * bulk upload aribtrary 23/34 column ordering works * bulk upload supports 23/24 without headers * bulk upload 23/24 supports BOM + invalid chars * dupe tests * port 23/24 attributes_for_log * port 23/24 bulk upload validations * force crossover period * tweak max permitted columns * able to return column for given field * work out column for field for errors * add field_4 as 23/24 setup field * remove duplicate method * map schemes and locations correctly * handle arbitrary number of header rows * add missing fields to bulk upload support	2 years ago
Phil Lee	197e2ae4cb	[1778] Bulk upload errors (#1091 ) * lockdown bulk upload routes * able to view lettings bulk upload errors * add error count to bulk upload results * coverage for bulk upload filename on results * group bulk upload errors by row on results * able to view bulk upload sales results * scope lettings and sales bulk upload results * fix linting * call service correctly in test * add bulk upload sales questions mapping * appease linter * bulk upload error shows correct question - depending on log type it will show relevant question for the field concerned * use local disk for bulk upload for dev env - this saves the need to connect to S3 to play with bulk upload in dev environment * improve namespacing of classes * add job to process bulk uploads * use local disk storage for dev file upload * fix test * use inline active job queue_adapter for dev * use test active job queue adapter for test env * remove rubocop violation * delete bulk upload from disk after processing * populate errors with cell, row + metadata * update error message with something meaningful * shim in sales validator * able to parse sales bulk uploads * change migration to add purchase_code to errors * bulk upload error component renders purchaser code - when a sales log * populate purchaser_code for bulk upload errors - when log type is sales * remove superfluous private method	2 years ago