kosiakkatrina
5d7649a9e4
CLDC-3821 Remove care home questions ( #2885 )
...
* Remove carehome questions for 2025
* Update routing to rent pages for 2025
* lint
6 days ago
kosiakkatrina
ca2d670116
CLDC-3748 Check org name uniqueness ( #2818 )
...
* Check org name uniqueness
* Some tests
* Do not update org name
* Update some request specs
* Remove unnecessary updates
* Update error message
1 month ago
Rachael Booth
542565ed85
Use subsection copy key ( #2792 )
...
* CLDC-3766: Ensure copy for Q78 is found correctly
* Fix tests
* Use subsection copy key in defaults and remove explit keys that are now defaults
* Replace other uses of subsection.id interpolation in copy keys
* Test copy key when specified on subsection
* Update tests
* Update privacy notice page tests
* More test fixes
2 months ago
kosiakkatrina
671232daa9
CLDC-3734 Add LA in England validation for 2025 ( #2763 )
...
* Add LA in England validation for 2025
* Validate supported housing logs
* Add error message to the date
* Update error messages
* lint
* Fix error messages for date
* Update no address found soft validation
* Update validation messages
2 months ago
kosiakkatrina
0083485b42
CLDC-3690 Extract lettings property validations copy ( #2742 )
...
* Extract lettings property validations copy
* Update uprn question
* Remove redundant validations (can't trigger them because on inferrance)
2 months ago
kosiakkatrina
020b8a4f4c
CLDC-3686 Extract lettings soft validations copy ( #2735 )
...
* Extract household characteristics soft validations
* Extract household needs soft validations
* Extract household situation soft validations
* Extract income and benefits soft validations
* Extract property information soft validations
* Update tests and 2024 soft validations
* Update some test forms
* Re-add sales validation
* Update BU tests
* Fixes
* Change higher to longer
* Update model test
* Update model test
* Add 2025 translations copied from 2024
* Update pregnancy and retirement copy
---------
Co-authored-by: Manny Dinssa <44172848+Dinssa@users.noreply.github.com>
Co-authored-by: Rachael Booth <rachael.booth@softwire.com>
2 months ago
Manny Dinssa
6fb29ade6b
CLDC-3712: Sales Form Updates ( #2756 )
2 months ago
kosiakkatrina
51bc0cffeb
CLDC-3665 Extract sale information copy ( #2711 )
...
* Extract shared ownership copy
* Extract discounted ownership copy
* rename files
* CLDC-3665 Extract sale information soft validations (#2712 )
* Extract shared ownership copy
* Extract shared ownership soft validations
* Extract discounted ownership validations
* Fix mappings
* Update some translations
* Remove full stops
3 months ago
kosiakkatrina
3cda5adf5c
CLDC-3683 Extract lettings household situation copy ( #2730 )
...
* Extract lettings household situation copy
* Update wrong copy, remove duplicate keys
3 months ago
kosiakkatrina
625b0c757c
CLDC-3668 Extract guidance copy ( #2737 )
...
* Extract guidance copy
* Update tests and lint
3 months ago
kosiakkatrina
f2f44329f3
CLDC-3684 Extract lettings tenancy information copy ( #2731 )
...
* Extract lettings tenancy information copy
* Fix flaky merged schemes test
3 months ago
Rachael Booth
3424cbc550
CLDC-3366: Use single page for rent soft validation ( #2724 )
...
* CLDC-3366: Use single page for rent soft validation
* Fix tests
3 months ago
kosiakkatrina
ff3f789acc
CLDC-3681 Extract lettings household characteristics copy ( #2728 )
...
* Extract lettings household characteristics copy
* Update cya labels for age known
* Update missing keys and copy
3 months ago
Rachael Booth
731dcc9325
CLDC-3650: Move copy for sales setup section to translation files ( #2672 )
3 months ago
Manny Dinssa
53c3b3e61a
CLDC-3633 Full stops in error messages ( #2628 )
...
* Make full stops consistent in error messages
* Fix test
* Update few hardcoded errors
* Update join in remaining row parsers
* Update some more tests
* Update more hard coded BU errors
* Fix typo I introduced - bedrooms to bedroom
---------
Co-authored-by: Kat <katrina@kosiak.co.uk>
Co-authored-by: kosiakkatrina <54268893+kosiakkatrina@users.noreply.github.com>
3 months ago
kosiakkatrina
d5f2424247
CLDC-3576 Update soft pregnancy validation ( #2640 )
...
* Update soft pregnancy validation
* Fix tests
4 months ago
Manny Dinssa
1da04df30f
CLDC-3411 correct 24 25 bulk upload error messages on lettings and sales ( #2556 )
...
* Update error messages and sales parser
5 months ago
Manny Dinssa
c3b85f2b50
CLDC-3411: Correct 24/25 bulk upload error messages on lettings and sales ( #2553 )
5 months ago
Manny Dinssa
8af9c255e3
CLDC-3567-Remove-DLUHC-references-from-CORE-pages ( #2530 )
6 months ago
Manny Dinssa
fb89b47b6f
CLDC-3520 order scheme locations ( #2499 )
...
* List in alphabetical order using second line of address (.i.e. hint/name)
6 months ago
kosiakkatrina
8ce22d37c0
CLDC-3289 Avoid freezing time (part 3) ( #2445 )
...
* Refactor tests #1
* Update tasklist helper tests
* Update task list helper
* Fix test
* Rabase fixes
* Update model/validations tests
* Update som sales log specs
* Remove missing addresses csv tasks
* Update some tests for 2023 collection close
* More fixes
* Revert sales shared examples change
* Fix test
* Update test nemes, remove time stub
6 months ago
Arthur Campbell
3adfb29143
CLDC-3290 Update some test setup ( #2466 )
...
* test prof in test context
* time reduced from ~1.4 to 0.27
* time reduced from ~1.1 to 0.7
* time reduced from ~0.13 to 0.07
* add testprof env variables to spec helper
* reorder gems for linting copmlaint
* Remove test-prof gem
---------
Co-authored-by: Kat <katrina@kosiak.co.uk>
6 months ago
kosiakkatrina
42f89680e5
CLDC-3495 Reduce persisted models in tests ( #2507 )
...
* Remove legacy user from user factory
* Build instead of creating in some model tests
* Do not create a new DPO for orgs created within user factories
* Add original setup doc
* Update documentation with updated factories
* Fix up DSA creations
6 months ago
kosiakkatrina
ab4915c2aa
CLDC-2480 Allow deleting organisations ( #2459 )
...
* Add delete confirmation page
* Allow deleting organisation
* Add delete button
* Do not display deleted organisations as an option
* Update policy
* Display informative text and delete org resources
* lint
* Update organisation labels to show when deleted
* Refactor organisation label
* Update more labels
* Remove deleted orgs from schemes and autorize delete_confirmation
* Fix tests
6 months ago
kosiakkatrina
5947a2027a
CLDC-3496 Move period creation to log ( #2490 )
...
* Move period creation to log
* Allow adding rent periods to organisations
* Update more tests
7 months ago
Arthur Campbell
8f65fd35fd
Cldc 3505 fix tests that will break on rollover ( #2485 )
...
* update factory completed traits using an after build hook so that trait does what it says regardless of start or sale date of log
* use completed trait rather than completed2024 trait from factories
skip validation on saving logs from previous years so that logs created too far in the past do not trigger validations
* remove sale and start dates from logs in tests where that should not be important
build rather than create to reduce db interactions
in order that the setup is complete, build the necessary user and organisation with ids
* fix a wide range of tests affected by the changes in log factories completed traits
7 months ago
kosiakkatrina
07750ef26c
CLDC-3289 Avoid freezing time in tests (part 1) ( #2421 )
...
* Refactor tests #1
* Refactor helper tests
* Refactor model form tests
* Remove Timecop.returns
* Update tasklist helper tests
* Update task list helper
* Fix test
* Fix flaky search test
* Refactor
7 months ago
Arthur Campbell
d95e08cca2
Cldc 3492 oustide rent range soft validation not clearing for bedsit ( #2473 )
...
* mark the beds question as derived when the log is a bedsit to stop it from being cleared
* delete spec file not testing anything worthwhile
7 months ago
kosiakkatrina
a85fed42b1
CLDC-3504 Update period question options and error message ( #2463 )
...
* Update displayed_answer_options for period
* Update invalid rent period error message
7 months ago
kosiakkatrina
7d871edf74
CLDC-3482 Correct routing to property LA ( #2449 )
...
* Correct routing to property LA
* Add rake task to update LAs
7 months ago
kosiakkatrina
7e638657fb
CLDC-3354 Show user input on address selection page ( #2374 )
...
* Display input playback on the page
* Add input playback to uprn selection pages
8 months ago
kosiakkatrina
ad488bb5ce
CLDC-3345 Add assigned_to to the exports ( #2391 )
...
* Empty
* CLDC-3345 Rename created_by to assigned_to (#2372 )
* Rename created_by to assigned_to
* Replace created_by with assigned_to
* Update created_by to assigned_to in exports, remove blank assigned to
* CLDC-3345 Add and set created_by fields (#2373 )
* Add created_by
* Update existing created_by values
* Set created_by on single log
* Set created_by on BU
* Add created_by to exports
* feat: update since last merge
---------
Co-authored-by: natdeanlewissoftwire <nat.dean-lewis@softwire.com>
* Fix papertrail create version
---------
Co-authored-by: natdeanlewissoftwire <nat.dean-lewis@softwire.com>
9 months ago
Arthur Campbell
44a0b1acb8
CLDC-3405-update-retirement-age-validation ( #2384 )
...
* update retirement soft validation pages and copy in en.yml to reflect changes in english retirement age
* update soft validation tests to display interruption screens under the correct conditions given changes to state retirement age
reduction of variation in retirement age means lots of code related to determining the retirement age given an individuals gender can also be removed
testing updated
9 months ago
kosiakkatrina
eea2aead2c
CLDC-3397 Remove hint text from lead tenant questions ( #2378 )
...
* Remove hint text from lead tenant questions
* Update working situation answer options
9 months ago
Robert Sullivan
c309a4760b
CLDC-3384 referral tests and inconsistencies ( #2370 )
...
* CLDC-3156: Update 2024 referral options
* CLDC-3156: Add tests for referral question
* CLDC-3156: Update other referral questions
* CLDC-3384: Referral question inconsistencies and tests
* feat: remove option 4 from 24/25 referral
* feat: update tests
---------
Co-authored-by: natdeanlewissoftwire <nat.dean-lewis@softwire.com>
9 months ago
natdeanlewissoftwire
a0215d45ef
CLDC-3089 Make absolute skip/back links relative ( #2348 )
...
* Empty-Commit
* feat: make skip links relative
* feat: make scheme back links relative
* feat: update tests
9 months ago
Robert Sullivan
d2518d7c38
CLDC-2481: Add ability to disable organisations ( #2293 )
...
* CLDC-2481: Add ability to disable organisations.
* CLDC-2481: Add ability to disable organisations
* Tidy up tests
* CLDC-2481: Review markups
* CLDC-2481: Fix location and scheme filters
* Add banners for stock owners and managing agents
* Update view test
---------
Co-authored-by: Kat <katrina@kosiak.co.uk>
9 months ago
Robert Sullivan
378388ebc5
CLDC-3156: Update 2024 referral options ( #2366 )
...
* CLDC-3156: Update 2024 referral options
* CLDC-3156: Add tests for referral question
* CLDC-3156: Update other referral questions
10 months ago
kosiakkatrina
a65cc59713
CLDC-2479 Allow deleting users ( #2288 )
...
* Add delete confirmation page
* Add status to the user
* Allow deleting user
* Refactor sign_in user in tests
* Add delete user button and update policy
* Update user policy
* Do not display deleted users as an answer option
* Update user table and details
* Do not show deleted users
* Disable delete user on production
* Update test
10 months ago
Robert Sullivan
2e7cb56c70
CLDC-3351: Clear deposit in situations where it is no longer derived ( #2354 )
...
* CLDC-3351: Clear deposit in situations where it is no longer derived
10 months ago
Robert Sullivan
1d5d736f03
CLDC-3355: Reorder rent types on 2024/5 forms ( #2343 )
10 months ago
natdeanlewissoftwire
da0d27c8f9
feat: update copy ( #2357 )
10 months ago
kosiakkatrina
826b803e4e
CLDC-3305 Update previous postcode routing for renewals ( #2325 )
...
* Derive previous postcode for renewals
* Do not route renewals to previous postcode
* Update test
10 months ago
kosiakkatrina
5bbf0148b5
CLDC-2478 Allow deleting locations ( #2285 )
...
* Add delete confirmation page
* Allow deleting location
* Add delete location button and update policy
* Add delete button to CYA
* Update location policy
* Do not display deleted locationa as an option
* Move delete button into the button group
* Add informative text for locations that have logs
* Refactor query
* CLDC-2478 Allow deleting scheme (#2286 )
* Add delete confirmation page
* Allow deleting scheme
* Add delete scheme button and update policy
* Add delete button to CYA
* Update scheme policy
* Do not display deleted schemes as an option
* Add informative text for schemesrbe that have logs
* Refactor query
* Update tests
* Add feature toggle
10 months ago
natdeanlewissoftwire
99ad80aebd
feat: update skip links ( #2342 )
10 months ago
Robert Sullivan
cdfca1c023
CLDC-3336: Add hint text to Q77 for renewals ( #2340 )
10 months ago
Robert Sullivan
976d0f6e73
CLDC-3329: Update hint text for schemes question ( #2336 )
10 months ago
kosiakkatrina
5907502f21
CLDC-3146 Update household validations ( #2256 )
...
* Separate the validations, remove irrelevant tests
* Remove relevant lettings 2023 validations from 24
* Update validations for 2024 lettings
* Separate sales validations
* Infer child uner 16 for sales
* Update sales validations
* Update tests
* Add validations to all relevant fields
* Add a 2023 context
* Undo some 2024 validations
* Remove another validation, update test names
* Remove child option hint
* Update person age hint
* Add ecstat buyer validation
* Add custom ecstat BU errors
* Skip working situation for child in sales
* Add child under 16 validation to 2024, do not reset ecstat
* Add soft validation columns
* Add partner under 16 soft validation
* Add multiple partners soft validations
* Remove child option for buyer 2
* Update CSVs
* Check hhmemb exists
* refactor
* Display child option for lettings
* Remove wrong tests
* More tests
10 months ago
natdeanlewissoftwire
5b5e29a84a
CLDC-3310 UPRN routing bug fix ( #2312 )
...
* feat: update routing
* feat: test routing
10 months ago
Rachael Booth
5937ae3328
CLDC-3309: Update privacy notice/declaration error message for 2024 ( #2315 )
...
* CLDC-3309: Update privacy notice/declaration error message for 2024
* Remove missing answer feature test
* Remove unused definition
10 months ago