cbbe65cf30
tests: update after merge
2 years ago
0f17eab3fe
CLDC 882 add validation against grant ( #1220 )
...
* fix rebase conflicts
* fix rebase conflicts
* fix rebase conflicts
* implement soft validation of grant value
* fix rebase conflicts
* fix rebase conflicts
* fix rebase conflicts
* fix rebase conflicts
* fix final test from added page
* update test after rebase
2 years ago
99c87f1eb5
feat: respond to PR comments
2 years ago
4659a3efcf
CLDC-1899 Add discounted ownership value validation ( #1229 )
...
* Add validation for discounted ownership value
* Fix tests
* Update validations to work with different routing
* update error message
2 years ago
a4fbb99a3f
CLDC-1583 Add extra borrowing validation ( #1201 )
...
* feat: add condition-less soft validation and update db
* feat: add validation condition and update tests
* feat: update validation
* feat: update validation
* feat: add tests
* db: update
* test: update
* refactor: linting
* test: update
* feat: update text, remove separate redundant function, add value check page everywhere
* feat: leave value check at end
* test: update
* feat: add value check everywhere
* tests: update
* db:update
* feat: only appear at end
* test: update
* feat: add soft validation everywhere smoothly
* test: update
2 years ago
d67e4710c8
CLDC-861 Add length of stay validations ( #1218 )
...
* faet: add validation and tests
* refactor: linting
* feat: respond to PR comments
2 years ago
56a9cb4bdf
CLDC-864 Add contract exchange date validations ( #1231 )
...
* CLDC-864 Add exdate validations
* Raise missing translation errors
* Fix missing translation
* Remove unused method
* Remove redundant check
2 years ago
6ca9f851d3
refactor: linting
2 years ago
8ca9cbfb49
Change numeric validation to display prefixes in error message ( #1227 )
...
* change numeric validation
* Fix test, add delimiter and suffix to the numeric error mesage
2 years ago
9475cfc50b
refactor: pratical -> practical
2 years ago
16b6913e00
feat: update i18n
2 years ago
b6bfd1fb6f
feat: use i18n
2 years ago
f33b2ec332
refactor: linting
2 years ago
9ef3b38886
refactor: remove duplicated behaviour
2 years ago
c5bb9c6eaf
feat: add min and max conditional text
2 years ago
a1681d0a7f
feat: more saledate -> exdate fixing
2 years ago
be38ac3e39
feat: fix hodate validation and use purchase price ranges
2 years ago
3308d86a10
Last settled accommodation and discounted ownership property postcodes must match ( #1213 )
2 years ago
cf92c9559c
Add disability and wheelchair questions validation ( #1215 )
...
* Add Page#interruption_screen? method
* Use form helper method
* Validate household disability questions
* Update CYA
2 years ago
1cced31e27
hard validation on value of cash discount ( #1221 )
2 years ago
7e176bba34
CLDC-845 Add sales household details validations ( #1191 )
...
* Add min and max for age 1 validation
* Add retirement value check column to the sales table
* Add retirement value check question and page
* Add retirement value check pages to household characteristics
* Reuse soft validations for retirement in sales
* Update person_indexes
* Add old_persons_shared_ownership validation
* Display the retirement value check in correct places depending on the joinpur value
* Update page IDs
* It's always joint purchase if age 2 is displayed
* lint
* lint
2 years ago
1bf8373a74
CLDC-867 Add previous bedrooms validations ( #1219 )
...
* Add previous property bedsit validations
* Add min and max for frombeds
2 years ago
d2cd5b0b0a
feat: wip behaviour
2 years ago
d2afa46946
CLDC-1461 add validation ensure postcodes match if discounted ownership purchase ( #1200 )
...
* new property validation file for sales logs with postcode validation regarding discounted ownership, tests also
* linting problem
2 years ago
da8d6c0f74
CLDC-848 Add household details validations ( #1199 )
...
* Add min and max to age2 + questions
* validate that under 16s are economic children
* Update factory
* Update test
* Update ecstat, relationship and age validation
2 years ago
d4e8e64c28
CLDC-863 Add practical completion/handover date validations ( #1198 )
...
* [CLDC-863] Add hard validation for hodate
* Add soft validation
2 years ago
9e9ff8a4e2
CLDC-850 Add relationship to buyer 1 validation to sales log ( #1178 )
...
* feat: add sales partner count validation
* test: update tests
* test: add new test
* refactor: DRYing
* feat: DRY general household member validation
* feat: add tests
* db: update
* feat: update shared validations
* test: update tests
* feat: add more validations
* feat: add more validation and update tests
* feat: add update method test
* test: update sales_log factory
* refactor: linting
* feat: remove numbering
* test: update tests
* feat: rename i18n vars, add validations everywhere
* tests: add new tests for new validation occurences
* db: update
* feat: add partner number validation to relevant fields rather than base
* test: update tests
* tests: refactor
* test: update
2 years ago
45710ed661
CLDC 911 add hard validation to cash deposit ( #1186 )
...
* Tidy up test file
* Add hard validation to cash deposit
* Load validations
2 years ago
09e4a55bbb
Cldc 855 savings validation ( #1102 )
...
* Add savings soft validation page and question
* Add savings saof validation page to the income subsection
* add savings_over_soft_max? soft validation
* Add deposit value check soft validation page and question
* Add deposit soft validation page to the income and benefits subsection
* Add deposit, savings and deposit value check fields to the db
* Add deposit over soft max validation
* Add the value check to the new sections
2 years ago
7d02752d82
Cldc 1440 household situation section ( #1132 )
...
* feat: add question page and subsection (#1120 )
* feat: add question page and subsection
* refactor: linting
* feat: remove schema rows from other branch
* feat: slight refactor, fix tag behaviour and add section tests
* test: update and add tests
* feat: update status behaviour
* feat: update subsection status tag
* refactor: linting
* [CLDC-857] Add household wheelchair check (#1122 )
* [CLDC-857] Add household wheelchair check
* Hide only if answered
* Cldc 1497 ever served armed forces (#1124 )
* feat: add question and page
* test: update tests
* refactor: linting and slight test updates
* test: fix tests
* Cldc 1498 still serving armed forces (#1123 )
* feat: new question and tests
* test: update subsection spec
* test: update tests
* feat: (future) conflict resolving
* feat: more conflict resolution
* feat: update db field
* test: update id
* test: updates
* Cldc 1488 last accomodation (#1125 )
* Add postcode fields
* Add previous postcode page and questions
* Add last accommodation page to household situation subsection
* add previous la known to the db
* infer correct location fields
* styling
* Reorder disability questions (#1127 )
* [CLDC-1487] Add buyer1 previous tenure question (#1133 )
* use collection_start_year instead of the startdate (#1128 )
* [CLDC-1487] Add buyer 1 previous tenure
Co-authored-by: kosiakkatrina <54268893+kosiakkatrina@users.noreply.github.com>
* feat: fix routing (#1141 )
* Add last accommodation la question (#1142 )
* move hint text (#1146 )
Co-authored-by: natdeanlewissoftwire <94526761+natdeanlewissoftwire@users.noreply.github.com>
Co-authored-by: Jack S <113976590+bibblobcode@users.noreply.github.com>
2 years ago
514552934d
Sales financial validations ( #1079 )
...
* Include shared validations in sales log model and run validate_numeric_min_max method
* Add non london hard max income validation
* Add london income validation
* Remove child vlidation because buyer cannot be a child
* Add income1_value_check column
* Add buyer_1_income_value_check question and page
* Update income1_under_soft_min?
* Add mortgage and value check column
* Add mortgage value check page
* Update mortgage_over_soft_max? in soft validateions
* Remove unused error message
2 years ago
3c9bb2985f
[1644] Validate head count ( #1011 )
...
* validate sales log head count between 0 and 4
* enable ability to focus rspecs
2 years ago
natdeanlewissoftwire
Arthur Campbell
kosiakkatrina
natdeanlewissoftwire
Jack
Phil Lee