submit-social-housing-lettings-and-sales-data

Commit Graph

Author	SHA1	Message	Date
Samuel Young	0a10512dc6	Revert "CLDC-4340: Account for nil location name on location select (#3268 )" (#3280 ) This reverts commit `dc1f25f722`.	1 month ago
Samuel Young	dc1f25f722	CLDC-4340: Account for nil location name on location select (#3268 ) * CLDC-4340: Account for nil location name on location select use postcode as a fallback, which should never be nil * CLDC-4340: Add a verifying test * CLDC-4340: Put all postcode locations at the end * CLDC-4340: Sort locations by postcode	1 month ago
Nat Dean-Lewis	04f3285bbf	CLDC-4354: Return staging to real time post-testing (#3273 ) * Revert "CLDC-4235, CLDC-4280: staging go-live testing prep (#3262)" This reverts commit `21367a7e3e`. * CLDC-4280: continue to block future form use on staging	1 month ago
Nat Dean-Lewis	21367a7e3e	CLDC-4235, CLDC-4280: staging go-live testing prep (#3262 ) * CLDC-4235: set allow_future_form_use false in staging * CLDC-4280: add time travel behaviour for staging (and check on test first) * CLDC-4280: actually check on review * CLDC-4280: time travel on staging now review works * CLDC-4280: temp add review to diff again * CLDC-4280: send notify emails in real time in all environments to avoid auth/time skew errors * CLDC-4280: also apply with_timecop to s3 * CLDC-4280: undo changes to review	1 month ago
samyou-softwire	f26ee3c5b2	CLDC-NONE: Document check_answers_card_title	1 month ago
samyou-softwire	53a4797d98	CLDC-NONE: Final tweaks to new question	1 month ago
samyou-softwire	c56cb6c682	CLDC-NONE: Lint	1 month ago
samyou-softwire	4aad9b152a	CLDC-NONE: Update new question tutorial	1 month ago
samyou-softwire	b31c9f410b	CLDC-NONE: Add extra library to install to setup	1 month ago
samyou-softwire	4cfd42575b	CLDC-NONE: Update docs gemfile deprecation warning, these dependencies won't be included in default ruby in future	1 month ago
samyou-softwire	6fa34a4f26	CLDC-NONE: Finish question and page docs	1 month ago
Samuel Young	6a655e7210	CLDC-4325: Check tests will run on go live day (#3250 ) * CLDC-4325: Set date to 2026 * CLDC-4325: Fix sale information % tests I'm not sure why I turned off strict post 2026, it's wanted in the same scenarios as before as shown by the failing tests * CLDC-4325: Fix check answers spec * CLDC-4325: Fix old rake task tests * CLDC-4325: Fix sales soft validations * CLDC-4325: Fix collection resources controller spec * CLDC-4325: Only add noms and org to CSV row if prp in most cases this was done by default but some tests construct an invalid log * CLDC-4325: Fix lettings household validations spec * CLDC-4221: Add 2026 collection deadlines * CLDC-4325: Fix remaining model specs * CLDC-4325: Fix form controller spec * CLDC-4325: Fix hhmemb spec * CLDC-4325: Fix duplicate logs controller spec also introduce a new helper for a dynamic way of setting year * CLDC-4325: Fix sales BU validator spec * CLDC-4325: Fix check answers summary component * CLDC-4325: Remove 2024 rake * CLDC-4325: Use or later in all touched tests * CLDC-4325: Fix guidance helper spec * CLDC-4325: Run all tests now and in 2026 * CLDC-4325: Turn off 2026 override * CLDC-4325: Add a corresponding return to timecop missing one * CLDC-4325: Fix sales log spec in 2025 need to use let rather than let! so the timecop can run first * CLDC-4325: Fix lettings log derived spec in 2025 timecop required for the start dates to work * CLDC-4325: Turn the 2026 override on again * fixup! CLDC-4325: Fix check answers summary component * CLDC-4325: Delete recalculate_reasonpref_dontknow rake only needed for 2024 logs * fixup! CLDC-4325: Fix lettings household validations spec Co-authored-by: Oscar Richardson <116292912+oscar-richardson-softwire@users.noreply.github.com> * fixup! CLDC-4325: Fix sales log spec in 2025 * fixup! CLDC-4325: Fix sales log spec in 2025 * CLDC-4325: Make start controller spec not year specific * CLDC-4325: Run tests in current day * CLDC-4325: Run tests on 31st march * CLDC-4325: Run tests on 2nd april * CLDC-4325: Properly run tests on current day * fixup! CLDC-4325: Fix sales soft validations * fixup! CLDC-4325: Make start controller spec not year specific * CLDC-4325: Run tests on 31st march * CLDC-4325: Run tests on 1st april * CLDC-4325: Run tests on 2nd april * CLDC-4325: Revert time travel --------- Co-authored-by: Oscar Richardson <116292912+oscar-richardson-softwire@users.noreply.github.com>	1 month ago
dependabot[bot]	268b63eac5	Bump activesupport from 7.0.7.2 to 7.2.3.1 in /docs (#3266 ) Bumps [activesupport](https://github.com/rails/rails) from 7.0.7.2 to 7.2.3.1. - [Release notes](https://github.com/rails/rails/releases) - [Changelog](https://github.com/rails/rails/blob/v8.1.2.1/activesupport/CHANGELOG.md) - [Commits](https://github.com/rails/rails/compare/v7.0.7.2...v7.2.3.1) --- updated-dependencies: - dependency-name: activesupport dependency-version: 7.2.3.1 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	1 month ago
dependabot[bot]	5ef876f21c	Bump activesupport from 7.2.2.2 to 7.2.3.1 (#3267 ) Bumps [activesupport](https://github.com/rails/rails) from 7.2.2.2 to 7.2.3.1. - [Release notes](https://github.com/rails/rails/releases) - [Changelog](https://github.com/rails/rails/blob/v8.1.2.1/activesupport/CHANGELOG.md) - [Commits](https://github.com/rails/rails/compare/v7.2.2.2...v7.2.3.1) --- updated-dependencies: - dependency-name: activesupport dependency-version: 7.2.3.1 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	1 month ago
Nat Dean-Lewis	83de52ec8c	CLDC-NONE: whitespace linting	1 month ago
Nat Dean-Lewis	9e4408cf34	CLDC-NONE: add note about page ids	1 month ago
Nat Dean-Lewis	fd05184418	CLDC-NONE: add note to update variable_definitions file	1 month ago
Nat Dean-Lewis	9aac02e674	CLDC-NONE: add explanation of copy_key	1 month ago
Nat Dean-Lewis	f9ad054fce	CLDC-NONE: make clear sales steps are generic for lettings too	1 month ago
Nat Dean-Lewis	d7c15ee300	CLDC-NONE: make clear sales steps are generic for lettings too	1 month ago
Nat Dean-Lewis	622cc8b691	CLDC-NONE: update node version to correct value in setup.md	1 month ago
Katherine Langford	97d0c4fac9	CLDC-NONE: Lint fixes	1 month ago
Katherine Langford	a5f51638e5	CLDC-NONE: Update question doc	1 month ago
Katherine Langford	f00986d2ba	CLDC-NONE: Documentation for creating a new question	1 month ago
Katherine Langford	71beb4fd62	CLDC-NONE: Update setup docs to reccommend WSL	1 month ago
Nat Dean-Lewis	96638aaa88	CLDC-4297: Align new service charges with bu spec (#3240 ) * CLDC-4270: Add an error for fields with the wrong type for 2026 lettings * CLDC-4270: Add tests * CLDC-4270: Port changes to other years' parsers sales 2025 2026 lettings 2026 * fixup! CLDC-4270: Add an error for fields with the wrong type for 2026 lettings * fixup! CLDC-4270: Port changes to other years' parsers * CLDC-4270: Fix tests post merge * fixup! CLDC-4270: Add tests * CLDC-4270: Add ? to boolean method * CLDC-4263: align new service charge questions with bu spec * CLDC-4263: fix "no" mapping and allow decimal mscharge * CLDC-4263: update tests * CLDC-4297: clarify test naming * CLDC-4297: add tests for inferences and confirm R inference * CLDC-4297: add test override * CLDC-4297: remove R tests * CLDC-4297: add R behaviour back in * CLDC-4297: updated error handling * CLDC-4297: add warning comment on block_log_creation! * CLDC-4297: test updates * CLDC-4297: comment update * CLDC-4297: allow 0 for newservicecharges * CLDC-4297: test improvements * CLDC-4297: test negatives and unify order * CLDC-4297: misc cleanup * CLDC-4297: specify same value errors * CLDC-4297: don't allow 0 for mscharge and update tests * CLDC-4297: update case insensitive field tests * CLDC-4297: don't allow 0.0 * CLDC-4297: test 0.0 and r explicitly * CLDC-4297: refactor and simplify * CLDC-4297: final validation test tweaks --------- Co-authored-by: samyou-softwire <samuel.young@softwire.com>	1 month ago
Samuel Young	b2ed8405a3	CLDC-4221: Add 2026 collection deadlines (#3218 ) * CLDC-4221: Add 2026 collection deadlines * CLDC-4221: Update tests * CLDC-4221: Use form submission deadline for 4th quarter	1 month ago
dependabot[bot]	d67c949474	Bump json from 2.18.1 to 2.19.2 (#3260 ) Bumps [json](https://github.com/ruby/json) from 2.18.1 to 2.19.2. - [Release notes](https://github.com/ruby/json/releases) - [Changelog](https://github.com/ruby/json/blob/master/CHANGES.md) - [Commits](https://github.com/ruby/json/compare/v2.18.1...v2.19.2) --- updated-dependencies: - dependency-name: json dependency-version: 2.19.2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	1 month ago
dependabot[bot]	dc02504f4c	Bump flatted from 3.3.1 to 3.4.2 (#3259 ) Bumps [flatted](https://github.com/WebReflection/flatted) from 3.3.1 to 3.4.2. - [Commits](https://github.com/WebReflection/flatted/compare/v3.3.1...v3.4.2) --- updated-dependencies: - dependency-name: flatted dependency-version: 3.4.2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	1 month ago
Samuel Young	18d061143d	CLDC-4270: Fix text being coerced to 0 on integer fields (#3230 ) * CLDC-4270: Add an error for fields with the wrong type for 2026 lettings * CLDC-4270: Add tests * CLDC-4270: Port changes to other years' parsers sales 2025 2026 lettings 2026 * fixup! CLDC-4270: Add an error for fields with the wrong type for 2026 lettings * fixup! CLDC-4270: Port changes to other years' parsers * CLDC-4270: Fix tests post merge * fixup! CLDC-4270: Add tests * CLDC-4270: Add ? to boolean method	1 month ago
Nat Dean-Lewis	66bcfd7f16	CLDC-4302: Align buyer interviewed copy with paper form (#3255 ) * CLDC-4301: copy updates * CLDC-4302: row parser and fixture updates * CLDC-4302: typo fix * CLDC-4302: bu validation update * CLDC-4302: update log var def spec	1 month ago
Nat Dean-Lewis	05abccd7bc	CLDC-4312: Fix broken purchase price soft validation (#3253 ) * CLDC-4297: set derived for sales beds * CLDC-4312: update tests	1 month ago
Samuel Young	328ea6272b	CLDC-4309: Add copy for staircasing transaction mortgage used (#3251 ) * CLDC-4309: Add copy for staircasing transaction mortgage used * CLDC-4309: Update tests	1 month ago
Nat Dean-Lewis	edae85af99	Reapply "CLDC-4246: Starter tenancy type copy updates (#3229 )" (#3242 ) (#3246 ) This reverts commit `384435fdc6`.	1 month ago
Samuel Young	319af27e75	CLDC-4215: Don't run validate_discounted_ownership_value if mortgageused is 3 (#3239 ) * CLDC-4215: Don't run validate_discounted_ownership_value if mortgageused is 3 I don't think this should have ever been turned on. if we don't know the mortgage we can't assume info in this check * CLDC-4215: Add a verifying test	1 month ago
dependabot[bot]	d66771e591	Bump bcrypt from 3.1.21 to 3.1.22 (#3258 ) Bumps [bcrypt](https://github.com/bcrypt-ruby/bcrypt-ruby) from 3.1.21 to 3.1.22. - [Release notes](https://github.com/bcrypt-ruby/bcrypt-ruby/releases) - [Changelog](https://github.com/bcrypt-ruby/bcrypt-ruby/blob/master/CHANGELOG) - [Commits](https://github.com/bcrypt-ruby/bcrypt-ruby/compare/v3.1.21...v3.1.22) --- updated-dependencies: - dependency-name: bcrypt dependency-version: 3.1.22 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	1 month ago
Nat Dean-Lewis	9600112cda	CLDC-4318: update min for 26 onwards and test (#3257 )	1 month ago
Nat Dean-Lewis	4aae303e09	CLDC-4290: filter address responses to England only (#3256 ) * CLDC-4290: filter address responses to england only * CLDC-4290: update test stubs * CLDC-4290: update other stubbed urls	1 month ago
Nat Dean-Lewis	9e36fe7d34	CLDC-4314: Monthly service charge soft validation redirect bug (#3249 ) * CLDC-4314: set unique urls for shared ownership soft validations * CLDC-4314: update specs	1 month ago
Nat Dean-Lewis	ea74e31a64	CLDC-4152: update guidance copy (#3252 )	1 month ago
Samuel Young	dddf661f63	CLDC-4157: Remove nursing care from scheme level of support (#3224 ) * CLDC-4157: Remove nursing care home level of support * CLDC-4157: Add a helper script to mark impacted schemes & logs as incomplete * CLDC-4157: Update scheme factory * CLDC-4157: Remove redundant scheme hint functions * fixup! CLDC-4157: Add a helper script to mark impacted schemes & logs as incomplete correct script name	1 month ago
Samuel Young	749e69d5ea	CLDC-4239: Widen age range for pregnancy soft validation (#3192 ) * CLDC-4239: Update age range for pregnancy soft validation for 2026 * CLDC-4239: Update tests looks like the 2026 tests were testing the 2025 method, so have updated * fixup! CLDC-4239: Update tests * fixup! CLDC-4239: Update tests add boundary cases for 2025 * fixup! CLDC-4239: Update tests make 8 household memmbers clear	2 months ago
dependabot[bot]	a4b8795523	Bump json from 2.18.1 to 2.19.2 in /docs (#3254 ) Bumps [json](https://github.com/ruby/json) from 2.18.1 to 2.19.2. - [Release notes](https://github.com/ruby/json/releases) - [Changelog](https://github.com/ruby/json/blob/master/CHANGES.md) - [Commits](https://github.com/ruby/json/compare/v2.18.1...v2.19.2) --- updated-dependencies: - dependency-name: json dependency-version: 2.19.2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2 months ago
Samuel Young	3305e3017b	CLDC-4306: Correct sales still serving options for 2026 (#3248 )	2 months ago
Nat Dean-Lewis	80329f5c9a	CLDC-4249: reorder answer options (#3220 )	2 months ago
Samuel Young	b65de0c6d8	CLDC-4179: Fix duplicate logs check (#3245 ) * Reapply "CLDC-4179: Amend sales duplicate log check (#3207)" (#3241) This reverts commit `3bcc6627c0`. * CLDC-4179: Enable BU duplicate log check on staging	2 months ago
Nat Dean-Lewis	d87aba906b	CLDC-4236: Deploy review apps manually using PR labels (#3238 ) * CLDC-4263: implement minimal label-based approach * CLDC-4263: add descriptive comment * CLDC-4263: separate comment workflow * CLDC-4263: add label check to code workflow * CLDC-4263: always hint initially * CLDC-4263: copy change test * Revert "CLDC-4263: copy change test" This reverts commit `09df8ab28f`. * CLDC-4263: rename review app workflows for clarity * CLDC-4263: remove broken workflow_dispatches * CLDC-4263: rename label * CLDC-4236: renaming and commenting	2 months ago
Carolyn Barker	de4e0945a1	CLDC-4146 infer no other partners (#3152 ) * CLDC-4146 infer no to multiple partners * CLDC-4146 try removing factory change * Simplify inference logic * Fix not equals logic * Improve person_partner tests * Add tests for new not equals logic * Improve person_lead_partner tests * Fix inference logic * Revert to simpler inference logic * Correct hidden_in_check_answers logic * Fixed derived? * Improve lettings log variables tests * Pull out resetting partner fields into method * Convert 'else next' to guard clause * Refactor infer_only_partner! * Match updated requirements * Fix tests * Small tweaks * Remove redundant logic from infer_at_most_one_relationship! * Remove redundant `disable_clearing_if_not_routed_or_dynamic_answer_options` * Add tests for question number * Remove puts * Refactor derived fields tests * Fix lint * After build, set nil values for `details_known` to 0 * Add details_known to tests * Add question mark to method name * Rewrite `is_another_person_partner?` to be `is_any_person_partner?` * Move skip in form flow method from page to question * Fix tests * Fix tests after merge --------- Co-authored-by: Carolyn <carolyn.barker@softwire.com> Co-authored-by: oscar-richardson-softwire <oscar.richardson@softwire.com>	2 months ago
dependabot[bot]	c494890dea	Bump devise from 4.9.3 to 5.0.3 (#3244 ) Bumps [devise](https://github.com/heartcombo/devise) from 4.9.3 to 5.0.3. - [Release notes](https://github.com/heartcombo/devise/releases) - [Changelog](https://github.com/heartcombo/devise/blob/main/CHANGELOG.md) - [Commits](https://github.com/heartcombo/devise/compare/v4.9.3...v5.0.3) --- updated-dependencies: - dependency-name: devise dependency-version: 5.0.3 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2 months ago
Nat Dean-Lewis	384435fdc6	Revert "CLDC-4246: Starter tenancy type copy updates (#3229 )" (#3242 ) This reverts commit `66dfdbfbb3`.	2 months ago

1 2 3 4 5 ...

3665 Commits (cfdec4ffa20fc0bc7ccf08ac06a8b8d60abe0a19) All Branches Search

3665 Commits (cfdec4ffa20fc0bc7ccf08ac06a8b8d60abe0a19)

All Branches