* Add missing answer option
* Update tests
* Allow user to change the age of a person if they're not actually under 16 without being blocked
* Update displayed answer options
* Add tests
* Fix lint
* Clear only when age is not known
* Lint
* Use existing method
* Update tests
* Revert changes in derived variables
* Update sales_log_spec.rb
* db migration, new sales log fields
* Add new staircasing transaction section
* Update tests
* Lint
* Add tests
* Use log methods
* Lint
* Update test
* Remove compact
* Change section display condition
* CLDC-3760: Sales - firststair and numstair staircasing questions validations (#2793
An error occurred
)
* Add validation to new questions firststair and numstair
* Remove page headers on single question page
* Remove page
* More useful page header
* Show don't know option from 2025 onwards
* Add page header to monthly rent only for the version with two questions on the page
* Remove page header staircase initial date only page
* Update displayed answer options
* Fix lint
* Updates after merge
* Update test
* Update tests
* CLDC-3753: Update soft income validations
* Update tests
* Fix linting
* Include reference to informative text translations copy
* Combine min and max checks for income based on ecstat
* Fixes
* Update tests
* Add shared ownership initial purchase subsection
* Display correct subsection based on year
* Update some content
* Update LivingBeforePurchase routing
* Update routing and check for page existence in guidance
* Add management fee questions
* Only check the subsections relevant to the form
* Update content
* Update financial calculations text
* CLDC-3766: Ensure copy for Q78 is found correctly
* Fix tests
* Use subsection copy key in defaults and remove explit keys that are now defaults
* Replace other uses of subsection.id interpolation in copy keys
* Test copy key when specified on subsection
* Update tests
* Update privacy notice page tests
* More test fixes
* Do not ask questions from these sections when it's a staircase transaction
* Hide section/subsections from task list
* Add tests
* Fix lint
* Move logic to section model
* Update 2025 version of validation check
* Update validation for 2025
* Put two if statements into one
* Different approach to comparing dates
* Alternative method to compare dates
* Update tests
* Create 2025 versions of these questions
* Remove blank line
* Update copy and use 2025 version of question
* Add tests
* Update depends on
* Update question number
* Update test
* Remove depends_on companybuy which has been removed
* Fix lint
* CLDC-3716: Allow 25/26 form use on dev, review, and staging environments
* Remove empty line
* CLDC-3719: Move sale completion date question to start of setup section
* Fix test
* Update test fixture csv order
* Extract question and page copy to translation files
* Refactor 2 question pages
* Readd removed answer options
* Fix missing/wrong age mappings
* Update some pages/questions
* Update tests
* CLDC-3656 Extract household characteristics soft validations (#2707
An error occurred
)
* Extract retirement confirmation questions
* Extract old persons shared ownership confirmation questions
* Extract income confirmation questions
* Extract buyer live-in value check page and question copy to translation files
* Extract student not a child confirmation questions and page copy to translation files
* Extract partner under 16 value check page and question copy to translation files
* Extract partner under 16 value check page and question copy to translation files
* Update some missing/wrong keys
* Update some keys on 2023
* Update BU tests
* CLDC-3423: Add sales soft validation for person over retirement age not retired
* Add rake task to recalculate log status when new validation is triggered
* Make full stops consistent in error messages
* Fix test
* Update few hardcoded errors
* Update join in remaining row parsers
* Update some more tests
* Update more hard coded BU errors
* Fix typo I introduced - bedrooms to bedroom
---------
Co-authored-by: Kat <katrina@kosiak.co.uk>
Co-authored-by: kosiakkatrina <54268893+kosiakkatrina@users.noreply.github.com>
)
* Rename discount to deposit discount
* Split about price rtb questions
* Update error message
* Update guidance partial
* Fix top_guidance_partial method
* Split about_price_not_rtb
* Update guidance partial and validation
* Fix bulk upload test
* Update deposit routed_to and guidance
* Refactor guidance links into a helper (#2551
An error occurred
)
* Refactor guidance links into a helper
* Refactor discounted ownership guidance
* CLDC-3570 Validations all other shared ownership types (#2550
An error occurred
)
* Update "all other shared ownership" errors
* CLDC-3571 Update outright sale financial validations (#2549
An error occurred
)
* Update outright sale validation message
* Add outright sale guidance
* Update duplicate page id
* User guidance helper
* Fix up financial equations content (#2552
An error occurred
)
* Tweak shared ownership validation wording
* Add top_guidance_partial to missed shared ownership questions
* Update discounted ownership validation message when there's no grant
* Update discounted sale guidance and errors
* Lint and update test
* Update BU test
* Update test
* CLDC-3569 Update guidance for shared ownership without mortgage (#2562
An error occurred
)
* Update how we display errors for BU
* Update guidance for shared ownership
* Add header to mortgage used question
* Update shared ownership guidance
* Update spacing (#2569
)
* Update discounted ownership guidance
* Add top guidance partial to outright sale
* Update outright sale guidance content
* Update model test
---------
Co-authored-by: Manny Dinssa <44172848+Dinssa@users.noreply.github.com>
* further fixes
* Fix date / crossover issues
* Try changing form end dates
* Revert "Try changing form end dates"
This reverts commit e027e29cf0.
* Make use of :ignore-validation-errors trait
* Try with end dates in past
* Revert "Try with end dates in past"
This reverts commit 6b87938d70.
---------
Co-authored-by: Rachael Booth <rachael.booth@softwire.com>
* Remove legacy user from user factory
* Build instead of creating in some model tests
* Do not create a new DPO for orgs created within user factories
* Add original setup doc
* Update documentation with updated factories
* Fix up DSA creations
* update factory completed traits using an after build hook so that trait does what it says regardless of start or sale date of log
* use completed trait rather than completed2024 trait from factories
skip validation on saving logs from previous years so that logs created too far in the past do not trigger validations
* remove sale and start dates from logs in tests where that should not be important
build rather than create to reduce db interactions
in order that the setup is complete, build the necessary user and organisation with ids
* fix a wide range of tests affected by the changes in log factories completed traits
* initial spec file refactor
remove create for build, extract form to own variable, remove non-valuable tests
run time from 0.29s to0.11s
* refactor to ensure that the questions ownershipsch instance variable and the value of ownershipsch on the log is the same in tests
* delete page test file which is not testing anything meaningful
* add error messages to the I18n yml
* update tests for the validations
* update validation logic
* update tests for the mortgage used question
* update the mortgage used question displayed answer options
* update bulk upload specs to reflect error message updates
* make use of brackets consistent within validation method
* CLDC-3426: Ensure outright sale section can be completed with mortgage used unknown
* CLDC-3426: fix test
* CLDC-3426: Refactor tests
* Avoid unnecessarily creating users in sales log factory
* Fix test that inexplicably relies on creation
Manny Dinssa
Rachael Booth
kosiakkatrina
Arthur Campbell