submit-social-housing-lettings-and-sales-data

Commit Graph

Author	SHA1	Message	Date
Rachael Booth	356d652db1	CLDC-3532: Make BU guidance back link depend on referrer (#2482 ) * CLDC-3532: Make BU guidance back link depend on referrer * Add tests for back_path * Add guidance to homepage * CLDC-3526: Update back_path --------- Co-authored-by: Kat <katrina@kosiak.co.uk>	4 months ago
kosiakkatrina	30b86f5a86	CLDC-3289 Avoid freezing time in tests (part 2) (#2432 ) * Refactor tests #1 * Refactor model form tests * Update tasklist helper tests * Update task list helper * Fix test * Udate model/forms tests * Update model/validations tests * Update a few more model specs * Update bulk request tests * Update policy tests * lint * Refactor * More fixes * Rabase fixes * Refactor * lint	4 months ago
kosiakkatrina	ad488bb5ce	CLDC-3345 Add assigned_to to the exports (#2391 ) * Empty * CLDC-3345 Rename created_by to assigned_to (#2372) * Rename created_by to assigned_to * Replace created_by with assigned_to * Update created_by to assigned_to in exports, remove blank assigned to * CLDC-3345 Add and set created_by fields (#2373) * Add created_by * Update existing created_by values * Set created_by on single log * Set created_by on BU * Add created_by to exports * feat: update since last merge --------- Co-authored-by: natdeanlewissoftwire <nat.dean-lewis@softwire.com> * Fix papertrail create version --------- Co-authored-by: natdeanlewissoftwire <nat.dean-lewis@softwire.com>	6 months ago
Rachael Booth	642b9cdaf2	CLDC-3264: Setup to allow using future form on staging for testing (#2279 ) * CLDC-3264: Setup to allow using future form on staging for testing * Update bulk upload year_spec tests * Fix indentation * Disable future form use on review apps for testing * Move lettings startdate 14 day validation to enforce order * Update tests * Restore future form use on review apps	8 months ago
natdeanlewissoftwire	fb389414a0	CLDC-2504 Add owning org select to sales if there are stock owning absorbed orgs (#1815 ) * feat: wip update sales org select * feat: update routing and hidden in check answers methods * feat: set sales org id as derived * feat: update tests * refactor: linting * feat: update tests and radio options * feat: update test * feat: add value helper test for non-constant value question * refactor: lint * feat: freeze time in unrelated test * refactor: linting	1 year ago
natdeanlewissoftwire	05b9e59939	CLDC-2242 Add assigned to filter (#1775 ) * feat: wip commit * feat: rest of assigned to filter behaviour * feat: start to update tests * feat: update tests * feat: update tests * refactor: linting * feat: add new test * feat: add new test * feat: update filters_count * feat: let support users see all users * feat: let users select users from stock owners/managing agents too * refactor: typo * feat: update tests	1 year ago
Arthur Campbell	cec1208b35	CLDC-2290 implement delete multiple logs story (#1657 ) * add a button to the logs list to delete multiple logs style and position of button helpers for displaying the button conditionally depending on user role and what filters and search are active * correct indentation from 4 spaces to 2 in view file * test appearance of delete logs button on index page for lettings logs * write a happy path feature test for the entire journey * create basic tests for the view component for listing logs to delete * create request tests for the GET delete-logs path * create request tests for the GET delete-logs-confirmation path * create request tests for the DELETE delete-logs path * comprehensive reworking after code review ensure that we are not passing lists of ids through params in the query string, risking overflowing the maximum URL length, adjust tests accordingly, do not attempt to reuse the same table for sales and lettings * alter config to allow creating controllers from the command line with associated spec files that matches how we test * extract controller methods and associated tests to do with the delete logs feature into their own controller, amend routes accordingly * implement same work for sales as for lettings * implement the story for lettings and sales logs under the organisation tab routing and controller methods testing for deleting sales logs, lettings or sales logs for an organisation move storage of relevant routes inside the form object as a comprehensive view model * merge the delete pages for lettings logs and sales logs, add to the tests for the lettings page to test sales specific content * minor refactor to delete logs controller: ensure session filters are only fetched from teh session when needed and extract discard logs method to private method * extract tables for lettings and sales to own partials * refactor delete logs controller after tech review improve the private method that builds the form object so that it has the flexibility to do so for all controller methods ensure that the search term is passed to the delete logs controller when navigating through the organisations tab ensure that noly logs for that organisation are displayed when navigating to delete logs through the organisations tab * remove unnecessary untested arguments * test new helper methods * implement dirty fiddle to get the checkboxes smaller and also not misaligned * ensure delete logs button is always visible on log lists when in the organisations tab * minor linting corrections * revert change, causing errors and outside the scope of this ticket * simplify tests for whether delete logs button appears on index page * replicate request specs from lettings for sales and organisations controllers * minor refactor of lettings log feature spec setup, replicate happy path for sales * minor refactors after rebasing onto Nat's work * temp * write tests for the delete logs form object * lint: add new line at end of file * respond to PO feedback the log id in the delte logs table should be a link to the log the delete logs button should be visible when the user is in a bulk upload journey updated associated tests	1 year ago
kosiakkatrina	ae9a4d0638	Fix collection year shift issues (#1506 ) * Fix possible bulk upload years * Initialise 2021/22 form routes for tests * Return test routes from form handler * Fix some tests * fix bulk upload tests - change from mocks to actual code calls * update years for bulk upload form * Fix some uprn tests * Set the scheme as available from previous year if the collection is in crossover * Update location available_from * Update location and scheme tests * Refactor and comment out a scheme test * Some uprn and export tests * Fix lettings logs controller tests and comment out previous collection message test * fix tests for new collection year * fix bulk upload tests for some reason tenancylength must not be given for validation to pass * update bulk upload tests for new year * More fixes * Undo location changes * Fix remaining uprn * further new collection year test fixes --------- Co-authored-by: Phil Lee <asmega@users.noreply.github.com>	2 years ago
Phil Lee	35de06e324	CLDC-2067 Bulk upload for lettings 23/24 (#1417 ) * refactor questions from validator to row parser * able to switch between bulk upload parsers - depending on what year we are processing * spec tooling to support bulk upload multi year * row parser now has year in namespacing * add static data for 2023 row parser * add placeholder to log to csv for specs * bulk upload aribtrary 23/34 column ordering works * bulk upload supports 23/24 without headers * bulk upload 23/24 supports BOM + invalid chars * dupe tests * port 23/24 attributes_for_log * port 23/24 bulk upload validations * force crossover period * tweak max permitted columns * able to return column for given field * work out column for field for errors * add field_4 as 23/24 setup field * remove duplicate method * map schemes and locations correctly * handle arbitrary number of header rows * add missing fields to bulk upload support	2 years ago
Phil Lee	197e2ae4cb	[1778] Bulk upload errors (#1091 ) * lockdown bulk upload routes * able to view lettings bulk upload errors * add error count to bulk upload results * coverage for bulk upload filename on results * group bulk upload errors by row on results * able to view bulk upload sales results * scope lettings and sales bulk upload results * fix linting * call service correctly in test * add bulk upload sales questions mapping * appease linter * bulk upload error shows correct question - depending on log type it will show relevant question for the field concerned * use local disk for bulk upload for dev env - this saves the need to connect to S3 to play with bulk upload in dev environment * improve namespacing of classes * add job to process bulk uploads * use local disk storage for dev file upload * fix test * use inline active job queue_adapter for dev * use test active job queue adapter for test env * remove rubocop violation * delete bulk upload from disk after processing * populate errors with cell, row + metadata * update error message with something meaningful * shim in sales validator * able to parse sales bulk uploads * change migration to add purchase_code to errors * bulk upload error component renders purchaser code - when a sales log * populate purchaser_code for bulk upload errors - when log type is sales * remove superfluous private method	2 years ago
kosiakkatrina	da33b7e5fd	Cldc 1773 needstype bulk upload (#1105 ) * Add needstype to lettings bulk upload model * Add needstype question for 2022/23 bulk uploads * New line * Add more info to prepare your file	2 years ago
Phil Lee	a249b5b1eb	store filename on bulk upload (#1071 )	2 years ago
Phil Lee	add39e9611	[1716] [1717] Bulk upload part four (#1043 ) * add start of bulk upload logs journey * split upload controller into 2 * add year page to bulk upload journey * bulk upload years now dynamic * add placeholder for upload your file page * handle bulk upload when not in crossover * add bulk upload csv user journey * bulk upload now persists and sends to S3 * swap ruby-filemagic for file command * match csv or text file for validation * in_crossover_period? now uses overlap of forms - also moved from Form to FormHandler * add production env var for CSV bucket * stub kernel call methods * remove duplicate env var * hardcode env var for review apps * move feature toggle to FeatureToggle * crossover period checks now specific to the form * fix typo in bulk upload journey	2 years ago
Phil Lee	a305bb7d52	[1714] Bulk upload part three (#1032 ) * add start of bulk upload logs journey * split upload controller into 2 * add year page to bulk upload journey * bulk upload years now dynamic * bulk upload journey: add copy for prepare file * add link to bulk upload template * add placeholder for upload your file page * handle bulk upload when not in crossover * fix tests around bulk upload redirect * fix typos in bulk upload jouney	2 years ago

14 Commits (daff1d637b95c322a059f2fa7ece742ae3dc17df)