e2c7ac01f9
Update test suite
2 years ago
15524cd8e7
Remove accidental comment
2 years ago
ac928adcd7
Update failing tests
2 years ago
a36015a7a7
Add postcode fields to sales_log :completed factory
2 years ago
f833705c21
Update existing postcode stubs to include in/outcode
2 years ago
2957ee3d19
Update Postcode service related spec
2 years ago
a29f38ea08
Revise schema to original column order
2 years ago
e572e0f63a
Remove branch migrations
2 years ago
1541ca1281
Remove merged duplicate column names
2 years ago
de92947869
Remove duplicate column
...
Removes sales.la_known from a later migration
2 years ago
79d16d82c4
Merge branch 'main' into CLDC-1468-add-postcode-to-sales-property-info-journey
2 years ago
3ecfe24139
Update postcode handling
...
Introduces new database fields and fixes rubocop issues
2 years ago
20159bba13
Ensure that logs exported with datetimes are local times ( #965 )
...
Follows on from https://github.com/communitiesuk/submit-social-housing-lettings-and-sales-data/pull/960
2 years ago
d89e03cc62
Cldc 1675 rent validations ( #959 )
...
* feat: add 2022 rent range data, update rake task for population of this
* feat: change file format so ranges_rent_id is recognised
* feat: add updated error messages and casing
* tests: make tests pass
* feat: ensure there is a location_code in all locations and use this (and beds = 0) for supported housing rent validations
* feat: fix general needs validation behaviour
* feat: add local authorities enum to location.rb
* feat: ensure case when beds > 4 is accounted for
* feat: add error messages on property postcode page as well as la page
* feat: add error messages on scheme_id and location_id as well as la page
* feat: add error messages on scheme_id and location_id as well as la page
* feat: null coalescing and validations on changing las to one that invalidates rent in supported housing
* feat: nil protection
* refactor: linting
* refactor: combining duplicated logic
* tests: add hard validation tests split by needstype
* feat: update validations when beds > 4
* feat: update validations when beds > 4
* refactor: simplification, use preivous la method
* refactor: response to PR comments, fixing beds.negative validation
* feat: remove dynamic local auth name text from interruption screens - to be added back in later if this becomes a priority, would need some work on adding local auth name to log for supported housing logs not just leaving it in the location
2 years ago
9fdd2978bf
Adjust referral derived value when log is a renewal ( #963 )
...
Previously we inferred referral to equal `0` when renewal was `1`. This change sets `referral` to `1` when `renewal` is also `1`.
2 years ago
1bc1ce6144
Update mapping values of reservist field ( #962 )
...
Previous to this change, the `reservist` field mapped `0` to yes and `1` to no. This change adjusts the mapping from `1` to yes, `2` to no, and `3` to prefer not to say.
2 years ago
2642afd036
[CLDC-1660] Remove managing agent ( #961 )
2 years ago
0b91bafee1
Export logs with datetimes formatted as ISO 8601 ( #960 )
2 years ago
ccf4e91295
Cldc 1663 remove housing provider ( #957 )
...
* wip
* Rename managing_agents column
* add managing relationship
* f
* feat: add my features branched off managing agents branch
* feat: update nav behaviour
* feat: simplify housing_providers view
* feat: fix pluralise to default to plural rather than singular
* feat: remove managing agent related code so can be merged directly
* tests: update tests and add new ones for housing_providers
* refactor: rubocop conciliation
* tests: fix failing navigation tests
* tests: one more plural test
* refactor: erb linting
* refactor: erb linting
* feat: right-align "Remove" text
* feat: update nokogiri to pass bundler-audit
* feat: grey out search button
* feat: remove section-break
* feat: add housing provider page with details and button
* feat: tidy up routing
* feat: add wip housing provider behaviour without functioning search
* feat: wip add housing provider functionality hard coded to add FooBar LTD as provider to DLUHC
* feat: remove redundant code
* feat: add data passing behaviour without accessible autocomplete
* feat: use accessible autocomplete (not working)
* feat: use accessible autocomplete (now working)
* feat: wip commit error messages
* feat: add banner always
* feat: add conditional banner behaviour, back link and update logs titles
* feat: add search icon to accessible autocomplete, make hint text aligned correctly
* feat: use pluck not all
* tests: add initial test
* feat: refactor create logic
* feat: add sub org title
* feat: add correct no housing providers text
* feat: add correct no housing providers text
* tests: add tests for add housing provider page
* feat: remove unnecessary line from controller
* fet: simplify controller args
* fet: update schema
* feat: update schema
* feat: add core removal functionality
* fix: make secondary navbar display selected org not user org for support users
* refactor: tidy up code and add single quotes instead of apostrophes
* refactor: remove unnecessary lines
* test: add housing provider removal tests
* feat: use path helpers and beng methods
* refactor: linting
* refactor: erblinting
* refactor: renaming and tidying
* refactor: simplify format response and paths and remove redundant rendering
* feat: user flash notices instead of explicit notification banners
* test: update tests with new urls
* feat: add target org helper
* feat: add target org helper fix
* feat: add related org helper
* test: update paths in tests
Co-authored-by: Jack S <jacopo.scotti@softwire.com>
2 years ago
d7dab9644e
feat: remove redundant fields ( #958 )
...
* feat: remove redundant fields
* feat: hide behaviour behind feature toggle
2 years ago
38f1cada5d
[CLDC-1659] Create managing agents ( #956 )
...
* Add managing agent
* tidy up specs
* Address comments
* linter
2 years ago
b45b98108a
Cldc 1662 add housing provider ( #954 )
...
* wip
* Rename managing_agents column
* add managing relationship
* f
* feat: add my features branched off managing agents branch
* feat: update nav behaviour
* feat: simplify housing_providers view
* feat: fix pluralise to default to plural rather than singular
* feat: remove managing agent related code so can be merged directly
* tests: update tests and add new ones for housing_providers
* refactor: rubocop conciliation
* tests: fix failing navigation tests
* tests: one more plural test
* refactor: erb linting
* refactor: erb linting
* feat: right-align "Remove" text
* feat: update nokogiri to pass bundler-audit
* feat: grey out search button
* feat: remove section-break
* feat: add housing provider page with details and button
* feat: tidy up routing
* feat: add wip housing provider behaviour without functioning search
* feat: wip add housing provider functionality hard coded to add FooBar LTD as provider to DLUHC
* feat: remove redundant code
* feat: add data passing behaviour without accessible autocomplete
* feat: use accessible autocomplete (not working)
* feat: use accessible autocomplete (now working)
* feat: wip commit error messages
* feat: add banner always
* feat: add conditional banner behaviour, back link and update logs titles
* feat: add search icon to accessible autocomplete, make hint text aligned correctly
* feat: use pluck not all
* tests: add initial test
* feat: refactor create logic
* feat: add sub org title
* feat: add correct no housing providers text
* feat: add correct no housing providers text
* tests: add tests for add housing provider page
* feat: remove unnecessary line from controller
* fet: simplify controller args
* fet: update schema
* feat: update schema
* feat: remove create_managing_agent
* test: add support user tests
* test: add create_housing_provider tests
* refactor: rubocop autocorrect
* refactor: erblinting
* test: fix tests
* refactor: erblinting
* feat: don't use !important tag
Co-authored-by: Jack S <jacopo.scotti@softwire.com>
2 years ago
e5452b145c
feat: update logs link ( #955 )
2 years ago
47551f8276
CLDC-1577 Added page asking for local authority in sales log ( #953 )
2 years ago
13762991c4
Fix navigation item path
2 years ago
b83c6c0b27
Cldc 1675 rent validations ( #946 )
...
* feat: add 2022 rent range data, update rake task for population of this
* feat: change file format so ranges_rent_id is recognised
* feat: add updated error messages and casing
* tests: make tests pass
2 years ago
d218bfea4f
feat: remove overriding answer_selected? function ( #941 )
2 years ago
c710d642cc
[CLDC-1659] new managing agent page ( #948 )
...
* Add managing agents page
* Rubocop fixes
2 years ago
4aede34cf0
Cldc 1661 housing providers branch ( #950 )
...
* wip
* Rename managing_agents column
* add managing relationship
* f
* feat: add my features branched off managing agents branch
* feat: update nav behaviour
* feat: simplify housing_providers view
* feat: fix pluralise to default to plural rather than singular
* feat: remove managing agent related code so can be merged directly
* tests: update tests and add new ones for housing_providers
* refactor: rubocop conciliation
* tests: fix failing navigation tests
* tests: one more plural test
* refactor: erb linting
* refactor: erb linting
* feat: right-align "Remove" text
* feat: update nokogiri to pass bundler-audit
* feat: grey out search button
* feat: remove section-break
Co-authored-by: Jack S <jacopo.scotti@softwire.com>
2 years ago
b0f2f902ab
Add postcode fields to Sales Logs
2 years ago
75206fdde9
[CLDC-1679] Add relationshop type to org relationship ( #947 )
2 years ago
fd85f2a19e
[CLDC-1512] Add buyer1 income ( #940 )
...
* Add tests for household wheelchair
* [CLDC-1512] Add buyer 1 income
* Add guidance to question
2 years ago
57de10622a
CLDC-1505 Buyer 1 working situation must be an adult ( #945 )
2 years ago
67435e9fa6
Cldc 1529 add more ages ( #943 )
...
* feat: add person2_age
* feat: add person2_age
* feat: add all 4 additional people ages
* tests: add tests and make old tests pass
2 years ago
d7f650a283
feat: add validation for voiddate and mrcdate when startdate changed … ( #942 )
...
* feat: add validation for voiddate and mrcdate when startdate changed after these have been added later
* test: add tests for new validations
* refactor: remove unnecessary parens
2 years ago
27f3046c4f
feat: update linking behaviour ( #938 )
...
* feat: update linking behaviour
* feat: update linking behaviour for jointpur
* refactor: improve spacing
2 years ago
72dfcbf8db
Cldc 1529 person 1 age ( #939 )
...
* feat: add person 1 age question
* feat: add new tests and fix old tests
* feat: linting
2 years ago
c52a30ae0c
[CLDC-1467] add type of building question to sales ( #911 )
...
* add type of building question to sales
* update check answer label
* fix tests
* [CLDC-1467] Use correct page ID
Co-authored-by: Jack S <jacopo.scotti@softwire.com>
2 years ago
f2716ef0c1
[CLDC-1502] Add household wheelchair question ( #935 )
2 years ago
333dbfe5bb
Cldc 1522 buyer 2 relationship ( #936 )
...
* feat: add buyer 2-1 relationship question and page (migration and schema to come in next commit)
* feat: add buyer 2-1 migration and schema
* feat: update schema
* feat: add depends_on and tests
* feat: add hint text
* tests: add new tests
* refactor: lint appeasing
* test: update no. of pages
* feat: remove text input for Other option
* feat: update schema
2 years ago
8dc808a7db
Cldc 1527 others in property ( #934 )
...
* feat: add functionality and make tests pass
* tests: add new tests
* refactor: appease linting
* feat: update schema
* feat: update test
2 years ago
c34f922d76
CLDC-1505 Buyer 1 working situation ( #932 )
...
* CLDC-1505 Buyer 1 working situation
* Update sales log factory
2 years ago
a136a70139
Check that we have an inferred check answers value before extracting its value ( #933 )
...
It's possible that this method returns true despite not having an `inferred_check_answers_value` set. This is an obvious smell that we will return to fix.
2 years ago
9a0629004d
Cldc 1574 privacy notice ( #931 )
...
* feat: core functionality
* feat: update schema.rb
* feat: add link for privacy notice, refactor to separate tenant/buyer
* feat: make privacy notices open in new tab
* test: make previous tests pass
* test: add new tests
2 years ago
b22c6c961a
Cldc 1503 lead nationality ( #909 )
...
* Add nationality and other nationality questions
* Add nationality page
* Add national columns
* Add hidden_in_check_answers
* Update conditional question controller to work with both log types
* update tests
* lint
* Remove console.log
* tests and migration
* typo
* tests
* tests
* feat: update schema and tests
* Add nationality and other nationality questions
* Add nationality page
* Add national columns
* Add hidden_in_check_answers
* Update conditional question controller to work with both log types
* update tests
* lint
* Remove console.log
* tests and migration
* typo
* tests
* feat: update schema and tests
* tests: update tests
* feat: update schema.rb
Co-authored-by: natdeanlewissoftwire <nat.dean-lewis@softwire.com>
2 years ago
3ef5408451
Cldc 1525 buyer2 working situation ( #930 )
...
* feat: add functionality
* tests: make tests pass
* tests: add new tests
* feat: update schema
* tests: update tests
* feat: fix order of pages
* feat: fix order of pages
2 years ago
23c086d5da
Cldc 1525 buyer2 working situation ( #929 )
...
* feat: add functionality
* tests: make tests pass
* tests: add new tests
* feat: update schema
* tests: update tests
2 years ago
83e1469b4f
Cldc 1526 buyer 2 live in ( #928 )
...
* feat: add functionality
* tests: make existing tests pass
* tests: add new tests
2 years ago
0981ce7c4a
Cldc 1480 buyer interview ( #927 )
...
* feat: add functionality
* test: make old tests pass
* test: add new tests
* [CLDC-1524] Add buyer 2 gender question (#926 )
* changes for buyer 2 gender
* Rubocop
Co-authored-by: Jack S <jacopo.scotti@softwire.com>
* feat: add updated schema post rebase
* refactor: remove blank line
* test: update tests
Co-authored-by: Dushan <47317567+dushan-madetech@users.noreply.github.com>
Co-authored-by: Jack S <jacopo.scotti@softwire.com>
2 years ago
04c2e7b638
[CLDC-1524] Add buyer 2 gender question ( #926 )
...
* changes for buyer 2 gender
* Rubocop
Co-authored-by: Jack S <jacopo.scotti@softwire.com>
2 years ago
Mo Seedat
James Rose
natdeanlewissoftwire
Jack S
David May-Miller
Sam
Ted-U
kosiakkatrina
Dushan