Rachael Booth
975f072d2f
CLDC-3547: Validate against incomplete schemes being used in logs ( #2498 )
...
* CLDC-3547: Validate against incomplete schemes being used in logs
* Fix ordering issue in tests
2 years ago
kosiakkatrina
0f4bc32d6e
CLDC-3465 Update hard validations flow ( #2472 )
...
* Add check your errors page with clear links
* Update answer links
* Link to check your errors page
* Refactor check errors page
* Allow clearing answers
* Update styling and lint
* Add routing for sales
* lint
* Update page routing test
* Remove unused code
* CLDC-3465 Handle additional errors (#2480 )
* Keep check errors query params
* Add success banner
* Update confirm and continue button
* CLDC-3465 Allow clearing all error questions (#2483 )
* Allow clearing all error questions
* Update setup question link
* Update clear all to ignore setup questions
* Update correct_validation_action_href
* Extract some vriables
* CLDC-3465 Do not display non persisted values in check errors page (#2484 )
* Do not display non persisted values on check_errors page
* Remove govuk button styling from link
* Update warning message
* Update copy
2 years ago
kosiakkatrina
201ce23906
CLDC-1718 Update numeric questions to text fields ( #2527 )
...
* Update numeric questions to text fields
* Add test case
2 years ago
Manny Dinssa
8af9c255e3
CLDC-3567-Remove-DLUHC-references-from-CORE-pages ( #2530 )
2 years ago
kosiakkatrina
b9f900c98e
CLDC-3550 Fix rent_type 2024 BU mapping ( #2501 )
...
* Fix rent_type 2024 BU mapping
* Correct rent_type values
* Reuse rent_type mapping
* Track updated bulk uploads
* Fix test
2 years ago
Manny Dinssa
d9a9846ef0
Change location active scope
2 years ago
Manny Dinssa
cb49abe9a8
Remove unused method
2 years ago
Manny Dinssa
467431d740
Remove check
2 years ago
Manny Dinssa
c2884ef5d0
Use scope to filter location instead
2 years ago
Manny Dinssa
fb89b47b6f
CLDC-3520 order scheme locations ( #2499 )
...
* List in alphabetical order using second line of address (.i.e. hint/name)
2 years ago
Manny Dinssa
6273a076cb
CLDC-3414&5 Close 2023/24 - No new/No editing of entries ( #2520 )
...
* Close 2023/24
2 years ago
Manny Dinssa
6d592d14ad
Separate out active scheme check
2 years ago
kosiakkatrina
a08f6a6ca8
Allow discarding users for merged orgs ( #2518 )
2 years ago
Rachael Booth
d2964d73db
CLDC-3549: Ensure location page routing is updated when log is changed ( #2502 )
2 years ago
Manny Dinssa
b0bf07e461
Lint offences
2 years ago
Manny Dinssa
ab69841f7c
Separate tenancy startdate and scheme validation & fix bug
2 years ago
Manny Dinssa
20e0715db9
Consolidate tenancy validation functionality into scheme validation
2 years ago
Manny Dinssa
c888972e0f
Change order, validate scheme before location
2 years ago
Manny Dinssa
01aa26a053
Alternative to prevent tenancy dates before location start date
2 years ago
Manny Dinssa
f6c938df2a
Change function to read more clearly
2 years ago
Manny Dinssa
d4436bc3bc
Remove unused parameter
2 years ago
Manny Dinssa
f807cdac34
Validate tenancy start date against location availability
2 years ago
Manny Dinssa
40c2746151
Prevent picking tenancy dates before location start date
2 years ago
Manny Dinssa
fd5b65a277
Fix merge conflict
2 years ago
Manny Dinssa
3955e8a9be
Remove do...end block, Lint offence
2 years ago
Manny Dinssa
cc46f53c35
Fix failing tests expecting an empty hash
2 years ago
Manny Dinssa
74b5f79cd2
Correct syntax offences
2 years ago
Manny Dinssa
34ebd405ff
Sort by alphabetical section first, then by numerical
2 years ago
Manny Dinssa
e27ad6c3be
Create alternative select view for schemes with 20+ locations
2 years ago
Manny Dinssa
405ebf900c
List in alphabetical order using second line of address (.i.e. hint/name)
2 years ago
kosiakkatrina
8ce22d37c0
CLDC-3289 Avoid freezing time (part 3) ( #2445 )
...
* Refactor tests #1
* Update tasklist helper tests
* Update task list helper
* Fix test
* Rabase fixes
* Update model/validations tests
* Update som sales log specs
* Remove missing addresses csv tasks
* Update some tests for 2023 collection close
* More fixes
* Revert sales shared examples change
* Fix test
* Update test nemes, remove time stub
2 years ago
Manny Dinssa
c1bad2bc7e
Remove do...end block, Lint offence
2 years ago
Manny Dinssa
c74c842dfa
Fix failing tests expecting an empty hash
2 years ago
Manny Dinssa
2d6c41e78c
Correct syntax offences
2 years ago
Manny Dinssa
bd135d6a5d
Sort by alphabetical section first, then by numerical
2 years ago
Manny Dinssa
cd1aad495d
Create alternative select view for schemes with 20+ locations
2 years ago
Manny Dinssa
b894ef7494
List in alphabetical order using second line of address (.i.e. hint/name)
2 years ago
kosiakkatrina
ab4915c2aa
CLDC-2480 Allow deleting organisations ( #2459 )
...
* Add delete confirmation page
* Allow deleting organisation
* Add delete button
* Do not display deleted organisations as an option
* Update policy
* Display informative text and delete org resources
* lint
* Update organisation labels to show when deleted
* Refactor organisation label
* Update more labels
* Remove deleted orgs from schemes and autorize delete_confirmation
* Fix tests
2 years ago
Rachael Booth
356d652db1
CLDC-3532: Make BU guidance back link depend on referrer ( #2482 )
...
* CLDC-3532: Make BU guidance back link depend on referrer
* Add tests for back_path
* Add guidance to homepage
* CLDC-3526: Update back_path
---------
Co-authored-by: Kat <katrina@kosiak.co.uk>
2 years ago
Arthur Campbell
e566ff09a0
refactor property validations specs to avoid breaking on collection year change ( #2478 )
2 years ago
kosiakkatrina
07750ef26c
CLDC-3289 Avoid freezing time in tests (part 1) ( #2421 )
...
* Refactor tests #1
* Refactor helper tests
* Refactor model form tests
* Remove Timecop.returns
* Update tasklist helper tests
* Update task list helper
* Fix test
* Fix flaky search test
* Refactor
2 years ago
Arthur Campbell
5696e4b81e
Cldc 3452 remove dont know option from mortgage used when invalid ( #2470 )
...
* initial spec file refactor
remove create for build, extract form to own variable, remove non-valuable tests
run time from 0.29s to0.11s
* refactor to ensure that the questions ownershipsch instance variable and the value of ownershipsch on the log is the same in tests
* delete page test file which is not testing anything meaningful
* add error messages to the I18n yml
* update tests for the validations
* update validation logic
* update tests for the mortgage used question
* update the mortgage used question displayed answer options
* update bulk upload specs to reflect error message updates
* make use of brackets consistent within validation method
2 years ago
Arthur Campbell
d95e08cca2
Cldc 3492 oustide rent range soft validation not clearing for bedsit ( #2473 )
...
* mark the beds question as derived when the log is a bedsit to stop it from being cleared
* delete spec file not testing anything worthwhile
2 years ago
kosiakkatrina
a85fed42b1
CLDC-3504 Update period question options and error message ( #2463 )
...
* Update displayed_answer_options for period
* Update invalid rent period error message
2 years ago
Rachael Booth
34faa74a6c
CLDC-3447: Allow decimal discount percentage and increased validation tolerance ( #2427 )
...
* CLDC-3447: Allow decimal discount percentage and increased validation tolerance
* Update tests to use decimal discount
* Disable extra borrowing soft validation for 2024 onwards
* CLDC-3447: Make tolerance inclusive
* Fix linting error
* Fix method call
* Only change strictness when discount is present
* Remove blank line
2 years ago
kosiakkatrina
8edca7e34b
Update routing for major repairs question ( #2464 )
2 years ago
kosiakkatrina
9f623e0cb2
CLDC-3274 Display organisation merges for a longer period ( #2456 )
...
* Display organisation merges for a longer period
* Refactor
2 years ago
Arthur Campbell
00c8567538
add paper trail to organisation rent periods in case of any further bugs ( #2461 )
2 years ago
kosiakkatrina
7d871edf74
CLDC-3482 Correct routing to property LA ( #2449 )
...
* Correct routing to property LA
* Add rake task to update LAs
2 years ago
Rachael Booth
10732f92f2
CLDC-3487: Ensure locations and previous_la_known are cleared when necessary ( #2452 )
...
* CLDC-3487: Clear previous_la_known when necessary for renewal logs
* CLDC-3487: Clear location when clearing scheme due to org change
* CLDC-3487: Use nil instead of 0
* Specify orgs on sh logs when needed for tests
* Fix flaky tests
2 years ago