Manny Dinssa
e045588775
CLDC-3241: Part 2 - Explanation of variables on CSVs ( #2586 )
...
* Create CsvVariableDefinition migration and model
* Add definition files
* Add CsvVariableDefinitions to rails admin
* Create rake and service
* Create tests
* Additional fixes
* Rollback unwanted changes to schema
* Add variable definitions as the first row of csv downloads
* Add and update tests
* Fix lint offences
* Update Gemfile.lock
4 months ago
dependabot[bot]
caba5e7fdd
Bump rexml from 3.3.3 to 3.3.6 in /docs ( #2603 )
...
Bumps [rexml](https://github.com/ruby/rexml ) from 3.3.3 to 3.3.6.
- [Release notes](https://github.com/ruby/rexml/releases )
- [Changelog](https://github.com/ruby/rexml/blob/master/NEWS.md )
- [Commits](https://github.com/ruby/rexml/compare/v3.3.3...v3.3.6 )
---
updated-dependencies:
- dependency-name: rexml
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
4 months ago
kosiakkatrina
4690fb446e
CLDC-3595 Remove duplicate errors for check errors page ( #2560 )
...
* Remove duplicate errors for check errors page
* Remove unused line
* Format some missed errors correctly
4 months ago
Rachael Booth
ea853c484d
CLDC-3566: Clear duplicate set ids when a log ceases to be a duplicate in normal update flow - with better performance ( #2573 )
...
* Revert "Revert "CLDC-3566: Clear duplicate set ids when a log ceases to be a duplicate through normal update flow (#2534 )" (#2563 )"
This reverts commit 53ae216bae
.
* CLDC-3566: Avoid unnecessary queries for duplicates
4 months ago
Rachael Booth
14d63bd5c4
CLDC-3577: Add optional phone extension to users ( #2597 )
...
* CLDC-3577: Add optional phone extension to users
* CLDC-3577: Validate that phone extension is a number
4 months ago
kosiakkatrina
daff1d637b
Remove old email template ( #2591 )
4 months ago
kosiakkatrina
573e6302bc
CLDC-3600 Clear unconfirmed emails for deactivated users ( #2587 )
...
* Discard email changes when deactivating user
* Clear existing unconfirmed emails
4 months ago
kosiakkatrina
eb355d6829
Update equity validation for resale ( #2559 )
4 months ago
dependabot[bot]
6c33210510
Bump fugit from 1.10.0 to 1.11.1 ( #2595 )
...
Bumps [fugit](https://github.com/floraison/fugit ) from 1.10.0 to 1.11.1.
- [Changelog](https://github.com/floraison/fugit/blob/master/CHANGELOG.md )
- [Commits](https://github.com/floraison/fugit/compare/v1.10.0...v1.11.1 )
---
updated-dependencies:
- dependency-name: fugit
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
4 months ago
kosiakkatrina
459420d7ee
CLDC-3541 Update sales financial validations ( #2546 )
...
* CLDC-3569 Update social homebuy errors (#2541 )
* Split questions
* Update the error message
* Add guidance
* Add back the headers
* Refactor depends_on
* Refactor further
* CLDC-3569 Update missed errors (#2548 )
* Update some skipped error messages
* Remove repeating deposit question
* CLDC-3571 Discounted ownership validation (#2547 )
* Rename discount to deposit discount
* Split about price rtb questions
* Update error message
* Update guidance partial
* Fix top_guidance_partial method
* Split about_price_not_rtb
* Update guidance partial and validation
* Fix bulk upload test
* Update deposit routed_to and guidance
* Refactor guidance links into a helper (#2551 )
* Refactor guidance links into a helper
* Refactor discounted ownership guidance
* CLDC-3570 Validations all other shared ownership types (#2550 )
* Update "all other shared ownership" errors
* CLDC-3571 Update outright sale financial validations (#2549 )
* Update outright sale validation message
* Add outright sale guidance
* Update duplicate page id
* User guidance helper
* Fix up financial equations content (#2552 )
* Tweak shared ownership validation wording
* Add top_guidance_partial to missed shared ownership questions
* Update discounted ownership validation message when there's no grant
* Update discounted sale guidance and errors
* Lint and update test
* Update BU test
* Update test
* CLDC-3569 Update guidance for shared ownership without mortgage (#2562 )
* Update how we display errors for BU
* Update guidance for shared ownership
* Add header to mortgage used question
* Update shared ownership guidance
* Update spacing (#2569 )
* Fix spacing again (#2570 )
* Update discounted ownership guidance (#2582 )
* Update discounted ownership guidance
* Add top guidance partial to outright sale
* Update outright sale guidance content
* Update model test
---------
Co-authored-by: Manny Dinssa <44172848+Dinssa@users.noreply.github.com>
4 months ago
Rachael Booth
3773dd7d9b
Yarn package upgrades ( #2590 )
...
* Upgrade yarn packages to clear dependabot warnings
* Add prettier
* Run prettier
* Update docs
* Update babel config for moved plugins
* Add node_modules and similar to prettierignore, since on CI it's not run from same directory as gitignore
4 months ago
Manny Dinssa
331ee8f0e8
CLDC-3575: Remove reference to dluhc on GitHub ( #2581 )
...
* Update github README.md picture
* Change name
* Remove old image & change private to public beta text
4 months ago
Manny Dinssa
bee90d6f99
CLDC-2588++update soft validation errors in bulk upload ( #2577 )
...
* Change table column width with govuk class
* Add html_safe to error message fields
4 months ago
Rachael Booth
85bbbe6108
CLDC-3556: Ignore address data in bulk upload for supported housing logs ( #2540 )
...
* Only set address data in BU for general needs logs
* Don't route to uprn selection page for supported housing logs
* Fix tests
4 months ago
kosiakkatrina
72890e516e
CLDC-3564 Update filter search ( #2535 )
...
* Add search controller
* Update on confirm
* lint
* Update search endpoint
* remove assigned to filter options
* Explicitly define host in the url
* Update search controller
* Allow searching organisations
* Allow filtering by user without js
* Allow filtering by org without js
* Add filter_type to method calls
* Update filter helpers
* Hide text search input when js is enabled
* Some feature test updates
* fix model test
* Delete a random file 👀
* lint
* Update more tests
* Update inner text for filter
* Keep csv filters the same
* Clear free text filters for csv dowloads
* User path helper
* Update scheme filters and log scopes
* Update which users we can filter by
4 months ago
kosiakkatrina
53ae216bae
Revert "CLDC-3566: Clear duplicate set ids when a log ceases to be a duplicate through normal update flow ( #2534 )" ( #2563 )
...
This reverts commit e66d5ea1d0
.
5 months ago
Manny Dinssa
c7bf7a037d
CLDC-2588-Separate soft and hard validation errors in bulk upload ( #2545 )
...
* Separate soft and hard validation errors in bulk upload
5 months ago
kosiakkatrina
979e2a6ba2
Filter out location questions before checking the routing ( #2557 )
5 months ago
Manny Dinssa
1da04df30f
CLDC-3411 correct 24 25 bulk upload error messages on lettings and sales ( #2556 )
...
* Update error messages and sales parser
5 months ago
Manny Dinssa
c3b85f2b50
CLDC-3411: Correct 24/25 bulk upload error messages on lettings and sales ( #2553 )
5 months ago
Rachael Booth
e66d5ea1d0
CLDC-3566: Clear duplicate set ids when a log ceases to be a duplicate through normal update flow ( #2534 )
...
* CLDC-3566: Clear duplicate set ids when a log ceases to be a duplicate in normal updates
* Refactor
* Ensure post not run twice in form controller tests
* Remove deduplication flow feature toggle
* Ensure class_name is defined in redirect path function
* Add tests for sales logs
5 months ago
Rachael Booth
6a42978fab
CLDC-3546: Add error to managing org when it does not have relevant rent period ( #2538 )
...
* CLDC-3546: Add error to managing org when it does not have relevant rent period
* Add test for :skip_bu_error
* Fix managing org question id
5 months ago
kosiakkatrina
72cbc7d6fd
Update rexml to 3.3.3 ( #2544 )
5 months ago
Manny Dinssa
ae190b268d
CLDC-3357-Previously-applied-filters-not-clearing ( #2528 )
5 months ago
kosiakkatrina
45d73955c9
CLDC-759 Add accessibility testing ( #2529 )
...
* Add accessibility tests
* Add accessibiliy tests to CI
* Lint and refactor
* Adjust and update paths
* Add some more page tests
5 months ago
Rachael Booth
427099c724
CLDC-3568: Update collection resources for MHCLG name change ( #2536 )
5 months ago
kosiakkatrina
ba2cf8b4a9
Update location scopes ( #2537 )
5 months ago
Manny Dinssa
9b0cbac406
CLDC 2954 handle schemes with only deactivated locations ( #2510 )
5 months ago
Rachael Booth
975f072d2f
CLDC-3547: Validate against incomplete schemes being used in logs ( #2498 )
...
* CLDC-3547: Validate against incomplete schemes being used in logs
* Fix ordering issue in tests
5 months ago
kosiakkatrina
bb270d34c0
Remove noint_fix_status from the database ( #2508 )
5 months ago
kosiakkatrina
0f4bc32d6e
CLDC-3465 Update hard validations flow ( #2472 )
...
* Add check your errors page with clear links
* Update answer links
* Link to check your errors page
* Refactor check errors page
* Allow clearing answers
* Update styling and lint
* Add routing for sales
* lint
* Update page routing test
* Remove unused code
* CLDC-3465 Handle additional errors (#2480 )
* Keep check errors query params
* Add success banner
* Update confirm and continue button
* CLDC-3465 Allow clearing all error questions (#2483 )
* Allow clearing all error questions
* Update setup question link
* Update clear all to ignore setup questions
* Update correct_validation_action_href
* Extract some vriables
* CLDC-3465 Do not display non persisted values in check errors page (#2484 )
* Do not display non persisted values on check_errors page
* Remove govuk button styling from link
* Update warning message
* Update copy
5 months ago
kosiakkatrina
201ce23906
CLDC-1718 Update numeric questions to text fields ( #2527 )
...
* Update numeric questions to text fields
* Add test case
5 months ago
Manny Dinssa
8af9c255e3
CLDC-3567-Remove-DLUHC-references-from-CORE-pages ( #2530 )
5 months ago
kosiakkatrina
523f931770
Set the bulk upload value for correct log type ( #2533 )
5 months ago
kosiakkatrina
b9f900c98e
CLDC-3550 Fix rent_type 2024 BU mapping ( #2501 )
...
* Fix rent_type 2024 BU mapping
* Correct rent_type values
* Reuse rent_type mapping
* Track updated bulk uploads
* Fix test
5 months ago
kosiakkatrina
a4a83908ae
Refactor locations/index page ( #2523 )
5 months ago
kosiakkatrina
93cf84edca
CLDC-3027 Remove unused admin user code ( #2524 )
...
* Remove leftover admin user code
* Fix flaky tests
5 months ago
dependabot[bot]
1da419f1f3
Bump rexml from 3.2.8 to 3.3.2 in /docs ( #2525 )
...
Bumps [rexml](https://github.com/ruby/rexml ) from 3.2.8 to 3.3.2.
- [Release notes](https://github.com/ruby/rexml/releases )
- [Changelog](https://github.com/ruby/rexml/blob/master/NEWS.md )
- [Commits](https://github.com/ruby/rexml/compare/v3.2.8...v3.3.2 )
---
updated-dependencies:
- dependency-name: rexml
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
5 months ago
kosiakkatrina
9d08cf9c85
Update rails-admin ( #2521 )
5 months ago
Manny Dinssa
fb89b47b6f
CLDC-3520 order scheme locations ( #2499 )
...
* List in alphabetical order using second line of address (.i.e. hint/name)
5 months ago
kosiakkatrina
a92c401a4d
Make sure archived filters are removed after crossover ( #2522 )
...
* Make sure archived filters are removed after crossover
* Fix feature tests
5 months ago
kosiakkatrina
6c03a6d203
CLDC-3562 Add scheme ID to the hint text ( #2519 )
...
* Add scheme ID to the hint text
* Fix flaky tests
5 months ago
Manny Dinssa
6273a076cb
CLDC-3414&5 Close 2023/24 - No new/No editing of entries ( #2520 )
...
* Close 2023/24
5 months ago
kosiakkatrina
a08f6a6ca8
Allow discarding users for merged orgs ( #2518 )
5 months ago
Rachael Booth
636e40fc9d
CLDC-3505: Fix tests for hard year end part 4 ( #2509 )
...
* Add in past end dates for testing
* Temporarily disable test marked to delete at year end
* Remove one off reinfer_local_authority task
* Update validator_spec
* Set 2024 date in form_handler_spec to be during crossover period as needed
* Use bulk_upload.year_combo for comparison in request tests to avoid year dependancy
* Update BU log creator specs for 2024
* Use year combo function in bulk upload mailer tests
* Refactor lettings validator_spec
* More fixes
* More work on bu validator specs - mostly sales
* Remove pre 2023 test
* More use of bulk_upload.year_combo in request tests
* Fix lint
* Tweak bulk upload error row component tests for year changes
* Further fixes
* Fix 2023 lettings row parser spec
* Sales log to csv fix
* Refactor BU processor tests
* Fix field number row identifier
* Fix linting
* More years in request spec
* fix
* Don't use db unnecessarily in financial validations spec
* Fix sale date changing 2024 -> 2023 test
* Add tests for bulk_upload.year_combo
* Update bu factory year specification
* Refactoring
* Linting
* Don't use helper in factory
* Remove new 2023 specific test
* Remove dummy end dates
5 months ago
kosiakkatrina
f9cb42fbad
CLDC-2831 Remove mini-profiler from staging ( #2517 )
...
* Revert "Add mini profiler (#2513 )"
This reverts commit c19291c948
.
* Revert "CLDC-2831 Update profiler storage (#2514 )"
This reverts commit 2203577fee
.
5 months ago
Rachael Booth
d2964d73db
CLDC-3549: Ensure location page routing is updated when log is changed ( #2502 )
5 months ago
kosiakkatrina
e639c5c861
CLDC-3558 Display correct orgs data protection confirmation ( #2511 )
...
* Display correct orgs data protection confirmation
* Remove binding
5 months ago
kosiakkatrina
2203577fee
CLDC-2831 Update profiler storage ( #2514 )
...
* Update profiler storage
* lint
5 months ago
kosiakkatrina
9688a04ac7
Update rexml ( #2515 )
5 months ago