Update tests and lint

app/views/form/guidance/_scheme_selection.html.erb

@@ -1,5 +1,5 @@
 <% if current_user.data_provider? %>
-  <p class="govuk-body"><%= I18n.t("forms.#{@log.form.start_date.year}.lettings.guidance.scheme_selection.data_provider.content", users_page_link: "#{govuk_link_to I18n.t("forms.#{@log.form.start_date.year}.lettings.guidance.scheme_selection.data_provider.users_page_link_text"), users_path}").html_safe %></p>
+  <p class="govuk-body"><%= I18n.t("forms.#{@log.form.start_date.year}.lettings.guidance.scheme_selection.data_provider.content", users_page_link: govuk_link_to(I18n.t("forms.#{@log.form.start_date.year}.lettings.guidance.scheme_selection.data_provider.users_page_link_text"), users_path).to_s).html_safe %></p>
 <% elsif current_user.data_coordinator? %>
   <p class="govuk-body"><%= govuk_link_to I18n.t("forms.#{@log.form.start_date.year}.lettings.guidance.scheme_selection.data_coordinator.create_scheme_link_text"), new_scheme_path %></p>
 <% end %>

spec/requests/form_controller_spec.rb

@@ -412,7 +412,7 @@ RSpec.describe FormController, type: :request do
         context "with a form page that has custom guidance" do
           it "displays the correct partial" do
             get "/lettings-logs/#{lettings_log.id}/net-income", headers: headers, params: {}
-            expect(response.body).to match("What counts as income?")
+            expect(response.body).to match(I18n.t("forms.2021.lettings.guidance.what_counts_as_income.title"))
           end
         end
 

spec/views/form/page_view_spec.rb

@@ -100,7 +100,7 @@ RSpec.describe "form/page" do
   end
 
   context "with a question containing extra guidance" do
-    let(:expected_guidance) { /What counts as income?/ }
+    let(:expected_guidance) { /#{I18n.t("forms.2021.lettings.guidance.what_counts_as_income.content")}/ }
 
     context "with radio type" do
       let(:question_attributes) { { type: "radio", answer_options: { "1": "A", "2": "B" } } }