Makes the invalid user save more explicit

spec/models/form/setup/questions/created_by_id_spec.rb

@@ -8,11 +8,14 @@ RSpec.describe Form::Setup::Questions::CreatedById, type: :model do
   let(:page) { instance_double(Form::Page) }
   let(:subsection) { instance_double(Form::Subsection) }
   let(:form) { instance_double(Form) }
-  let!(:user_1) { FactoryBot.create(:user, name: "first user") }
+  let(:user_1) { FactoryBot.create(:user, name: "first user") }
-  let!(:user_2) { FactoryBot.create(:user, name: "second user") }
+  let(:user_2) { FactoryBot.create(:user, name: "second user") }
-  let(:user_3) { FactoryBot.build(:user, name: nil, email: "madeupmail@example.com") }
+  let(:user_3) do
-  let(:users)  { [user_1, user_2, user_3] }
+    user = FactoryBot.build(:user, name: nil, email: "madeupmail@example.com")
-  let(:expected_answer_options) do
+    user.save!(validate: false)
+    user
+  end
+  let!(:expected_answer_options) do
     {
       "" => "Select an option",
       user_1.id => user_1.name,
@@ -21,10 +24,6 @@ RSpec.describe Form::Setup::Questions::CreatedById, type: :model do
     }
   end
 
-  before do
-    allow(User).to receive(:select).and_return users
-  end
-
   it "has correct page" do
     expect(question.page).to eq(page)
   end