Browse Source

add guard clause for answer_selected?

pull/755/head
Kat 3 years ago
parent
commit
340aa6cdb2
  1. 1
      app/models/form/question.rb
  2. 5
      spec/models/form/setup/questions/property_reference_spec.rb

1
app/models/form/question.rb

@ -229,6 +229,7 @@ class Form::Question
end end
def answer_selected?(case_log, answer) def answer_selected?(case_log, answer)
return false unless type == "select"
case_log[id].to_s == answer.id.to_s case_log[id].to_s == answer.id.to_s
end end

5
spec/models/form/setup/questions/property_reference_spec.rb

@ -6,6 +6,7 @@ RSpec.describe Form::Setup::Questions::PropertyReference, type: :model do
let(:question_id) { nil } let(:question_id) { nil }
let(:question_definition) { nil } let(:question_definition) { nil }
let(:page) { instance_double(Form::Page) } let(:page) { instance_double(Form::Page) }
let(:case_log) { FactoryBot.create(:case_log) }
it "has correct page" do it "has correct page" do
expect(question.page).to eq(page) expect(question.page).to eq(page)
@ -38,4 +39,8 @@ RSpec.describe Form::Setup::Questions::PropertyReference, type: :model do
it "is not marked as derived" do it "is not marked as derived" do
expect(question.derived?).to be false expect(question.derived?).to be false
end end
it "returns false for answer_selected" do
expect(question.answer_selected?(case_log, {})).to be false
end
end end

Loading…
Cancel
Save