Browse Source

wait for binding when deploying review apps (#1013)

- there seems to be a race condition without this and there is a chance
  not command will fail as it needs to wait for any existing operations
  to complete first
pull/1014/head
Phil Lee 2 years ago committed by GitHub
parent
commit
3c07107c87
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 6
      .github/workflows/review_pipeline.yml

6
.github/workflows/review_pipeline.yml

@ -126,21 +126,21 @@ jobs:
APP_NAME: dluhc-core-review-${{ github.event.pull_request.number }} APP_NAME: dluhc-core-review-${{ github.event.pull_request.number }}
SERVICE_NAME: dluhc-core-review-${{ github.event.pull_request.number }}-postgres SERVICE_NAME: dluhc-core-review-${{ github.event.pull_request.number }}-postgres
run: | run: |
cf bind-service $APP_NAME $SERVICE_NAME cf bind-service $APP_NAME $SERVICE_NAME --wait
- name: Bind redis service - name: Bind redis service
env: env:
APP_NAME: dluhc-core-review-${{ github.event.pull_request.number }} APP_NAME: dluhc-core-review-${{ github.event.pull_request.number }}
SERVICE_NAME: dluhc-core-review-${{ github.event.pull_request.number }}-redis SERVICE_NAME: dluhc-core-review-${{ github.event.pull_request.number }}-redis
run: | run: |
cf bind-service $APP_NAME $SERVICE_NAME cf bind-service $APP_NAME $SERVICE_NAME --wait
- name: Bind logit drain service - name: Bind logit drain service
env: env:
APP_NAME: dluhc-core-review-${{ github.event.pull_request.number }} APP_NAME: dluhc-core-review-${{ github.event.pull_request.number }}
SERVICE_NAME: logit-ssl-drain SERVICE_NAME: logit-ssl-drain
run: | run: |
cf bind-service $APP_NAME $SERVICE_NAME cf bind-service $APP_NAME $SERVICE_NAME --wait
- name: Start review app - name: Start review app
env: env:

Loading…
Cancel
Save