Browse Source

rubo and lint

pull/671/head
JG 3 years ago
parent
commit
60a7f44e1c
  1. 4
      app/views/schemes/check_answers.html.erb
  2. 3
      app/views/schemes/confirm_secondary.html.erb
  3. 3
      app/views/schemes/new.html.erb
  4. 1
      app/views/schemes/primary_client_group.html.erb
  5. 1
      spec/features/schemes_spec.rb

4
app/views/schemes/check_answers.html.erb

@ -10,7 +10,7 @@
<%= render partial: "organisations/headings", locals: { main: "Check your changes before updating this scheme", sub: @scheme.service_name } %> <%= render partial: "organisations/headings", locals: { main: "Check your changes before updating this scheme", sub: @scheme.service_name } %>
<%= govuk_tabs(title: "Check your answers before creating this scheme") do |component| %> <%= govuk_tabs(title: "Check your answers before creating this scheme") do |component| %>
<% component.tab(label: 'Scheme') do %> <% component.tab(label: "Scheme") do %>
<%= govuk_summary_list do |summary_list| %> <%= govuk_summary_list do |summary_list| %>
<% @scheme.check_details_attributes.each do |attr| %> <% @scheme.check_details_attributes.each do |attr| %>
<% next if current_user.data_coordinator? && attr[:name] == ("Managed by") %> <% next if current_user.data_coordinator? && attr[:name] == ("Managed by") %>
@ -19,7 +19,7 @@
<% row.value { details_html(attr) } %> <% row.value { details_html(attr) } %>
<% row.action( <% row.action(
text: "Change", text: "Change",
href: scheme_details_path(scheme_id: @scheme.id, check_answers: true) href: scheme_details_path(scheme_id: @scheme.id, check_answers: true),
) %> ) %>
<% end %> <% end %>
<% end %> <% end %>

3
app/views/schemes/confirm_secondary.html.erb

@ -19,8 +19,7 @@
selection, selection,
:id, :id,
:name, :name,
legend: nil legend: nil %>
%>
<%= f.hidden_field :page, value: "confirm-secondary" %> <%= f.hidden_field :page, value: "confirm-secondary" %>
<% if request.query_parameters["check_answers"] == "true" %> <% if request.query_parameters["check_answers"] == "true" %>

3
app/views/schemes/new.html.erb

@ -3,7 +3,7 @@
<% content_for :before_content do %> <% content_for :before_content do %>
<%= govuk_back_link( <%= govuk_back_link(
text: "Back", text: "Back",
href: 'javascript:history.go(-1);', href: "javascript:history.go(-1);",
) %> ) %>
<% end %> <% end %>
@ -20,7 +20,6 @@
label: { text: "Scheme name", size: "m" }, label: { text: "Scheme name", size: "m" },
hint: { text: "This is how you’ll refer to this supported housing scheme within your organisation. For example, the name could relate to the address or location. You’ll be able to see the client group when selecting it." } %> hint: { text: "This is how you’ll refer to this supported housing scheme within your organisation. For example, the name could relate to the address or location. You’ll be able to see the client group when selecting it." } %>
<%= f.govuk_check_box :sensitive, <%= f.govuk_check_box :sensitive,
"Yes", "Yes",
checked: @scheme.sensitive?, checked: @scheme.sensitive?,

1
app/views/schemes/primary_client_group.html.erb

@ -9,7 +9,6 @@
<%= render partial: "organisations/headings", locals: { main: "What client group is this scheme intended for?", sub: @scheme.service_name } %> <%= render partial: "organisations/headings", locals: { main: "What client group is this scheme intended for?", sub: @scheme.service_name } %>
<%= form_for(@scheme, method: :patch) do |f| %> <%= form_for(@scheme, method: :patch) do |f| %>
<div class="govuk-grid-row"> <div class="govuk-grid-row">
<div class="govuk-grid-column-two-thirds"> <div class="govuk-grid-column-two-thirds">

1
spec/features/schemes_spec.rb

@ -321,7 +321,6 @@ RSpec.describe "Schemes scheme Features" do
end end
context "when changing answers" do context "when changing answers" do
it "displays change links" do it "displays change links" do
assert_selector "a", text: "Change", count: 12 assert_selector "a", text: "Change", count: 12
end end

Loading…
Cancel
Save