Browse Source

change question and hint copy, create test file for question class (#1374)

pull/1394/head
Arthur Campbell 2 years ago committed by GitHub
parent
commit
74f264f6f3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 4
      app/models/form/lettings/questions/offered_social_let.rb
  2. 44
      spec/models/form/lettings/questions/offered_social_let_spec.rb

4
app/models/form/lettings/questions/offered_social_let.rb

@ -3,13 +3,13 @@ class Form::Lettings::Questions::OfferedSocialLet < ::Form::Question
super super
@id = "offered" @id = "offered"
@check_answer_label = "Times previously offered since becoming available" @check_answer_label = "Times previously offered since becoming available"
@header = "Since becoming available, how many times has the property been previously offered?" @header = "How many times was the property offered between becoming vacant and this letting?"
@type = "numeric" @type = "numeric"
@width = 2 @width = 2
@check_answers_card_number = 0 @check_answers_card_number = 0
@max = 150 @max = 150
@min = 0 @min = 0
@hint_text = "If the property is being offered for let for the first time, enter 0." @hint_text = "Do not include the offer that led to this letting.This is after the last tenancy ended. If the property is being offered for let for the first time, enter 0."
@step = 1 @step = 1
end end
end end

44
spec/models/form/lettings/questions/offered_social_let_spec.rb

@ -0,0 +1,44 @@
require "rails_helper"
RSpec.describe Form::Lettings::Questions::OfferedSocialLet, type: :model do
subject(:question) { described_class.new(nil, nil, page) }
let(:page) { instance_double(Form::Page) }
it "has correct page" do
expect(question.page).to eq page
end
it "has the correct id" do
expect(question.id).to eq "offered"
end
it "has the correct header" do
expect(question.header).to eq "How many times was the property offered between becoming vacant and this letting?"
end
it "has the correct check_answer_label" do
expect(question.check_answer_label).to eq "Times previously offered since becoming available"
end
it "has the correct type" do
expect(question.type).to eq "numeric"
end
it "has the correct minimum and maximum values" do
expect(question.min).to eq 0
expect(question.max).to eq 150
end
it "has the correct step" do
expect(question.step).to eq 1
end
it "is not marked as derived" do
expect(question.derived?).to be false
end
it "has the correct hint_text" do
expect(question.hint_text).to eq "Do not include the offer that led to this letting.This is after the last tenancy ended. If the property is being offered for let for the first time, enter 0."
end
end
Loading…
Cancel
Save