Browse Source

rename attribute

pull/34/head
Kat 4 years ago
parent
commit
8c5988009e
  1. 2
      app/helpers/numeric_questions_helper.rb
  2. 2
      app/javascript/controllers/numeric_question_controller.js
  3. 2
      spec/helpers/numeric_questions_helper_spec.rb

2
app/helpers/numeric_questions_helper.rb

@ -5,7 +5,7 @@ module NumericQuestionsHelper
{ {
"data-controller": "numeric-question", "data-controller": "numeric-question",
"data-action": "numeric-question#calculateFields", "data-action": "numeric-question#calculateFields",
"data-affected": "#{question['result-field'].to_s.dasherize}-field", "data-target": "#{question['result-field'].to_s.dasherize}-field",
"data-calculated": question["fields-to-add"].to_json, "data-calculated": question["fields-to-add"].to_json,
} }
end end

2
app/javascript/controllers/numeric_question_controller.js

@ -2,7 +2,7 @@ import { Controller } from "@hotwired/stimulus"
export default class extends Controller { export default class extends Controller {
calculateFields() { calculateFields() {
const affectedField = this.element.dataset.affected; const affectedField = this.element.dataset.target;
const fieldsToAdd = JSON.parse(this.element.dataset.calculated).map(x => `${x.replaceAll("_","-")}-field`); const fieldsToAdd = JSON.parse(this.element.dataset.calculated).map(x => `${x.replaceAll("_","-")}-field`);
const valuesToAdd = fieldsToAdd.map(x => document.getElementById(x).value).filter(x => x); const valuesToAdd = fieldsToAdd.map(x => document.getElementById(x).value).filter(x => x);
const newValue = valuesToAdd.map(x => parseInt(x)).reduce((a, b) => a + b, 0); const newValue = valuesToAdd.map(x => parseInt(x)).reduce((a, b) => a + b, 0);

2
spec/helpers/numeric_questions_helper_spec.rb

@ -13,7 +13,7 @@ RSpec.describe NumericQuestionsHelper do
expect(numeric_question_html_attributes(questions["basic_rent"])).to eq({ expect(numeric_question_html_attributes(questions["basic_rent"])).to eq({
"data-controller": "numeric-question", "data-controller": "numeric-question",
"data-action": "numeric-question#calculateFields", "data-action": "numeric-question#calculateFields",
"data-affected": "#{questions['basic_rent']['result-field'].to_s.dasherize}-field", "data-target": "#{questions['basic_rent']['result-field'].to_s.dasherize}-field",
"data-calculated": questions["basic_rent"]["fields-to-add"].to_json, "data-calculated": questions["basic_rent"]["fields-to-add"].to_json,
}) })
end end

Loading…
Cancel
Save