Browse Source

Only hide created_by question for non support users (#1045)

pull/1057/head
kosiakkatrina 2 years ago committed by GitHub
parent
commit
ae0b375580
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 4
      app/models/form/lettings/questions/created_by_id.rb
  2. 2
      spec/features/lettings_log_spec.rb
  3. 14
      spec/models/form/lettings/questions/created_by_id_spec.rb

4
app/models/form/lettings/questions/created_by_id.rb

@ -35,8 +35,8 @@ class Form::Lettings::Questions::CreatedById < ::Form::Question
answer_options[value] answer_options[value]
end end
def hidden_in_check_answers?(_log, _current_user) def hidden_in_check_answers?(_log, current_user)
true !current_user.support?
end end
def derived? def derived?

2
spec/features/lettings_log_spec.rb

@ -89,7 +89,7 @@ RSpec.describe "Lettings Log Features" do
log_id = page.current_path.scan(/\d/).join log_id = page.current_path.scan(/\d/).join
visit("lettings-logs/#{log_id}/setup/check-answers") visit("lettings-logs/#{log_id}/setup/check-answers")
expect(page).to have_content("Housing provider #{support_user.organisation.name}") expect(page).to have_content("Housing provider #{support_user.organisation.name}")
expect(page).to have_content("You have answered 2 of 8 questions") expect(page).to have_content("You have answered 3 of 9 questions")
end end
end end
end end

14
spec/models/form/lettings/questions/created_by_id_spec.rb

@ -51,8 +51,20 @@ RSpec.describe Form::Lettings::Questions::CreatedById, type: :model do
expect(question.derived?).to be true expect(question.derived?).to be true
end end
context "when the current user is support" do
let(:support_user) { FactoryBot.build(:user, :support) }
it "is shown in check answers" do
expect(question.hidden_in_check_answers?(nil, support_user)).to be false
end
end
context "when the current user is not support" do
let(:user) { FactoryBot.build(:user) }
it "is not shown in check answers" do it "is not shown in check answers" do
expect(question.hidden_in_check_answers?(nil, user_1)).to be true expect(question.hidden_in_check_answers?(nil, user)).to be true
end
end end
context "when the owning organisation is already set" do context "when the owning organisation is already set" do

Loading…
Cancel
Save