Browse Source

Add mrentprestaircasing, update factory and tests

pull/2943/head
Kat 1 month ago
parent
commit
c8df193bf2
  1. 1
      app/services/exports/sales_log_export_constants.rb
  2. 5
      spec/factories/sales_log.rb
  3. 1
      spec/fixtures/exports/sales_log.xml
  4. 3
      spec/fixtures/exports/sales_log_2024.xml
  5. 3
      spec/services/exports/export_service_spec.rb

1
app/services/exports/sales_log_export_constants.rb

@ -57,6 +57,7 @@ module Exports::SalesLogExportConstants
"stairbought", "stairbought",
"stairowned", "stairowned",
"mrent", "mrent",
"mrentprestaircasing",
"resale", "resale",
"deposit", "deposit",
"cashdis", "cashdis",

5
spec/factories/sales_log.rb

@ -270,11 +270,6 @@ FactoryBot.define do
value { 110_000 } value { 110_000 }
value_value_check { 0 } value_value_check { 0 }
grant { 10_000 } grant { 10_000 }
proplen { 10 }
pregyrha { 1 }
pregla { 1 }
pregother { 1 }
pregghb { 1 }
hhregres { 7 } hhregres { 7 }
ppcodenk { 1 } ppcodenk { 1 }
prevten { 1 } prevten { 1 }

1
spec/fixtures/exports/sales_log.xml vendored

@ -89,6 +89,7 @@
<address_search_value_check/> <address_search_value_check/>
<firststair/> <firststair/>
<numstair/> <numstair/>
<mrentprestaircasing/>
<day>1</day> <day>1</day>
<month>3</month> <month>3</month>
<year>2026</year> <year>2026</year>

3
spec/fixtures/exports/sales_log_2024.xml vendored

@ -66,7 +66,7 @@
<prevloc>E09000033</prevloc> <prevloc>E09000033</prevloc>
<hhregres>7</hhregres> <hhregres>7</hhregres>
<hhregresstill/> <hhregresstill/>
<proplen>10</proplen> <proplen/>
<mscharge>100.0</mscharge> <mscharge>100.0</mscharge>
<prevten>1</prevten> <prevten>1</prevten>
<mortgageused>1</mortgageused> <mortgageused>1</mortgageused>
@ -89,6 +89,7 @@
<address_search_value_check/> <address_search_value_check/>
<firststair/> <firststair/>
<numstair/> <numstair/>
<mrentprestaircasing/>
<day>3</day> <day>3</day>
<month>4</month> <month>4</month>
<year>2024</year> <year>2024</year>

3
spec/services/exports/export_service_spec.rb

@ -26,6 +26,8 @@ RSpec.describe Exports::ExportService do
end end
context "when exporting daily XMLs before 2025" do context "when exporting daily XMLs before 2025" do
let(:start_time) { Time.zone.local(2022, 5, 1) }
context "and no lettings archives get created in lettings logs export" do context "and no lettings archives get created in lettings logs export" do
let(:lettings_logs_export_service) { instance_double("Exports::LettingsLogExportService", export_xml_lettings_logs: {}) } let(:lettings_logs_export_service) { instance_double("Exports::LettingsLogExportService", export_xml_lettings_logs: {}) }
@ -394,7 +396,6 @@ RSpec.describe Exports::ExportService do
context "with date after 2025-04-01" do context "with date after 2025-04-01" do
let(:start_time) { Time.zone.local(2025, 5, 1) } let(:start_time) { Time.zone.local(2025, 5, 1) }
let(:expected_master_manifest_filename) { "Manifest_2025_05_01_0001.csv" } let(:expected_master_manifest_filename) { "Manifest_2025_05_01_0001.csv" }
let(:lettings_logs_export_service) { instance_double("Exports::LettingsLogExportService", export_xml_lettings_logs: {}) }
context "when exporting daily XMLs" do context "when exporting daily XMLs" do
context "and no sales archives get created in sales logs export" do context "and no sales archives get created in sales logs export" do

Loading…
Cancel
Save