06f66bf777
Remove or include copy key where appropriate
8 months ago
9f700a3149
Correct uprn selection header back to original
8 months ago
6840794ee3
Correct uprn confirmed header back to original
8 months ago
105a0b98a7
Add missing id
8 months ago
d4d114e8a4
Set uprn selection default header
8 months ago
ea6a84f239
Set uprn confirmation default header
8 months ago
498c32baaa
Add sales soft validations
8 months ago
731dcc9325
CLDC-3650: Move copy for sales setup section to translation files ( #2672 )
8 months ago
16e16117d3
Remove copy key from uprn_confirmation
8 months ago
b7c3222a35
Add back removed id
8 months ago
bc5ba65b88
Keep existing details for monthly charged check, common to other subsections
8 months ago
d7e2a6bf8d
Keep existing details for combined income check, common to other subsections
8 months ago
4380e440a8
Keep existing details for buyer income 1 and 2 check, common to other subsections
8 months ago
df45443f6c
Keep existing header and check answer label for about price value check, common to other subsections
8 months ago
a035a221e7
Keep default page header for uprn confirmation and selection
8 months ago
331b308818
Remove 2022-only property questions and pages
9 months ago
4fd2c732e2
Fix copy key
9 months ago
898768019b
Add page headers
9 months ago
f75c5f3ba2
Move question details to translation files
9 months ago
f359ac326a
Tidy
9 months ago
f892f75631
More fixes
9 months ago
27fc1277ae
Remove test word
9 months ago
bd47018f47
CLDC-3650: Pull out copy for sales setup section questions to translation file
9 months ago
961f1b7f93
CLDC-3423: Add sales soft validation for person over retirement age not retired ( #2644 )
...
* CLDC-3423: Add sales soft validation for person over retirement age not retired
* Add rake task to recalculate log status when new validation is triggered
9 months ago
615ebfeff8
WIP
9 months ago
eeca40521f
WIP
9 months ago
8516aa1f23
Don't hide person known question in CYA ( #2641 )
9 months ago
459420d7ee
CLDC-3541 Update sales financial validations ( #2546 )
...
* CLDC-3569 Update social homebuy errors (#2541 )
* Split questions
* Update the error message
* Add guidance
* Add back the headers
* Refactor depends_on
* Refactor further
* CLDC-3569 Update missed errors (#2548 )
* Update some skipped error messages
* Remove repeating deposit question
* CLDC-3571 Discounted ownership validation (#2547 )
* Rename discount to deposit discount
* Split about price rtb questions
* Update error message
* Update guidance partial
* Fix top_guidance_partial method
* Split about_price_not_rtb
* Update guidance partial and validation
* Fix bulk upload test
* Update deposit routed_to and guidance
* Refactor guidance links into a helper (#2551 )
* Refactor guidance links into a helper
* Refactor discounted ownership guidance
* CLDC-3570 Validations all other shared ownership types (#2550 )
* Update "all other shared ownership" errors
* CLDC-3571 Update outright sale financial validations (#2549 )
* Update outright sale validation message
* Add outright sale guidance
* Update duplicate page id
* User guidance helper
* Fix up financial equations content (#2552 )
* Tweak shared ownership validation wording
* Add top_guidance_partial to missed shared ownership questions
* Update discounted ownership validation message when there's no grant
* Update discounted sale guidance and errors
* Lint and update test
* Update BU test
* Update test
* CLDC-3569 Update guidance for shared ownership without mortgage (#2562 )
* Update how we display errors for BU
* Update guidance for shared ownership
* Add header to mortgage used question
* Update shared ownership guidance
* Update spacing (#2569 )
* Fix spacing again (#2570 )
* Update discounted ownership guidance (#2582 )
* Update discounted ownership guidance
* Add top guidance partial to outright sale
* Update outright sale guidance content
* Update model test
---------
Co-authored-by: Manny Dinssa <44172848+Dinssa@users.noreply.github.com>
10 months ago
8af9c255e3
CLDC-3567-Remove-DLUHC-references-from-CORE-pages ( #2530 )
11 months ago
ab4915c2aa
CLDC-2480 Allow deleting organisations ( #2459 )
...
* Add delete confirmation page
* Allow deleting organisation
* Add delete button
* Do not display deleted organisations as an option
* Update policy
* Display informative text and delete org resources
* lint
* Update organisation labels to show when deleted
* Refactor organisation label
* Update more labels
* Remove deleted orgs from schemes and autorize delete_confirmation
* Fix tests
12 months ago
07750ef26c
CLDC-3289 Avoid freezing time in tests (part 1) ( #2421 )
...
* Refactor tests #1
* Refactor helper tests
* Refactor model form tests
* Remove Timecop.returns
* Update tasklist helper tests
* Update task list helper
* Fix test
* Fix flaky search test
* Refactor
1 year ago
5696e4b81e
Cldc 3452 remove dont know option from mortgage used when invalid ( #2470 )
...
* initial spec file refactor
remove create for build, extract form to own variable, remove non-valuable tests
run time from 0.29s to0.11s
* refactor to ensure that the questions ownershipsch instance variable and the value of ownershipsch on the log is the same in tests
* delete page test file which is not testing anything meaningful
* add error messages to the I18n yml
* update tests for the validations
* update validation logic
* update tests for the mortgage used question
* update the mortgage used question displayed answer options
* update bulk upload specs to reflect error message updates
* make use of brackets consistent within validation method
1 year ago
34faa74a6c
CLDC-3447: Allow decimal discount percentage and increased validation tolerance ( #2427 )
...
* CLDC-3447: Allow decimal discount percentage and increased validation tolerance
* Update tests to use decimal discount
* Disable extra borrowing soft validation for 2024 onwards
* CLDC-3447: Make tolerance inclusive
* Fix linting error
* Fix method call
* Only change strictness when discount is present
* Remove blank line
1 year ago
7d871edf74
CLDC-3482 Correct routing to property LA ( #2449 )
...
* Correct routing to property LA
* Add rake task to update LAs
1 year ago
730b07ab25
CLDC-3426: Ensure outright sale section can be completed with mortgage used unknown ( #2399 )
...
* CLDC-3426: Ensure outright sale section can be completed with mortgage used unknown
* CLDC-3426: fix test
* CLDC-3426: Refactor tests
* Avoid unnecessarily creating users in sales log factory
* Fix test that inexplicably relies on creation
1 year ago
7e638657fb
CLDC-3354 Show user input on address selection page ( #2374 )
...
* Display input playback on the page
* Add input playback to uprn selection pages
1 year ago
30bb983e78
CLDC-3412 set derived? on mortgage amount ( #2396 )
...
* Set derived on mortgage amount
* Refactor
1 year ago
ad488bb5ce
CLDC-3345 Add assigned_to to the exports ( #2391 )
...
* Empty
* CLDC-3345 Rename created_by to assigned_to (#2372 )
* Rename created_by to assigned_to
* Replace created_by with assigned_to
* Update created_by to assigned_to in exports, remove blank assigned to
* CLDC-3345 Add and set created_by fields (#2373 )
* Add created_by
* Update existing created_by values
* Set created_by on single log
* Set created_by on BU
* Add created_by to exports
* feat: update since last merge
---------
Co-authored-by: natdeanlewissoftwire <nat.dean-lewis@softwire.com>
* Fix papertrail create version
---------
Co-authored-by: natdeanlewissoftwire <nat.dean-lewis@softwire.com>
1 year ago
b83be837ee
CLDC-3377 Remove hint text from buyer 1 questions ( #2376 )
...
* Remove hint text from buyer 1 questions
* Update working situation answer options
* Update missed hint text
* Update csv tests
1 year ago
a0215d45ef
CLDC-3089 Make absolute skip/back links relative ( #2348 )
...
* Empty-Commit
* feat: make skip links relative
* feat: make scheme back links relative
* feat: update tests
1 year ago
d2518d7c38
CLDC-2481: Add ability to disable organisations ( #2293 )
...
* CLDC-2481: Add ability to disable organisations.
* CLDC-2481: Add ability to disable organisations
* Tidy up tests
* CLDC-2481: Review markups
* CLDC-2481: Fix location and scheme filters
* Add banners for stock owners and managing agents
* Update view test
---------
Co-authored-by: Kat <katrina@kosiak.co.uk>
1 year ago
a65cc59713
CLDC-2479 Allow deleting users ( #2288 )
...
* Add delete confirmation page
* Add status to the user
* Allow deleting user
* Refactor sign_in user in tests
* Add delete user button and update policy
* Update user policy
* Do not display deleted users as an answer option
* Update user table and details
* Do not show deleted users
* Disable delete user on production
* Update test
1 year ago
2e7cb56c70
CLDC-3351: Clear deposit in situations where it is no longer derived ( #2354 )
...
* CLDC-3351: Clear deposit in situations where it is no longer derived
1 year ago
41a68eee0a
CLDC-3341 Update nationality all csv labels ( #2328 )
...
* Update nationality all csv labels
* Update csv tests
* Return prefers not to say labels
1 year ago
99ad80aebd
feat: update skip links ( #2342 )
1 year ago
a38d6a265f
CLDC-3334 Improve address search flow ( #2339 )
...
* Refactor page buttons
* Immediately show address search results
1 year ago
999a33e0f7
CLDC-3313 Update financial sale validations ( #2313 )
...
* Rename method
* Update staircase/non staircase validations
* Add errors to type
* Remove validate_shared_ownership_deposit
* Don't add setup BU errors, deduplicate different sale type errors
* Add tolerance
* Reuse method
* Rename methods
* Skip type error completely in BU
* Update validation messages
* Update over tolerance method
1 year ago
5907502f21
CLDC-3146 Update household validations ( #2256 )
...
* Separate the validations, remove irrelevant tests
* Remove relevant lettings 2023 validations from 24
* Update validations for 2024 lettings
* Separate sales validations
* Infer child uner 16 for sales
* Update sales validations
* Update tests
* Add validations to all relevant fields
* Add a 2023 context
* Undo some 2024 validations
* Remove another validation, update test names
* Remove child option hint
* Update person age hint
* Add ecstat buyer validation
* Add custom ecstat BU errors
* Skip working situation for child in sales
* Add child under 16 validation to 2024, do not reset ecstat
* Add soft validation columns
* Add partner under 16 soft validation
* Add multiple partners soft validations
* Remove child option for buyer 2
* Update CSVs
* Check hhmemb exists
* refactor
* Display child option for lettings
* Remove wrong tests
* More tests
1 year ago
5b5e29a84a
CLDC-3310 UPRN routing bug fix ( #2312 )
...
* feat: update routing
* feat: test routing
1 year ago
5937ae3328
CLDC-3309: Update privacy notice/declaration error message for 2024 ( #2315 )
...
* CLDC-3309: Update privacy notice/declaration error message for 2024
* Remove missing answer feature test
* Remove unused definition
1 year ago
Manny Dinssa
Rachael Booth
kosiakkatrina
Arthur Campbell
natdeanlewissoftwire
Robert Sullivan