59c19c1993
refactor: simplification
2 years ago
a407187120
refactor: revert previous
2 years ago
7a310bf193
refactor: simplification
2 years ago
2a83fbc198
feat: remove instantiation, update tests
2 years ago
bf58939e4f
feat: re-instantiate
2 years ago
c427f720b5
feat: wip remove instance variables so tests work
2 years ago
13390bb67a
feat: instantiate suffixes
2 years ago
e49dedd59a
refactor: typo
2 years ago
47343613f9
feat: make validation use correct end_date
2 years ago
0e4c785018
feat: inequality tweak for crossover period
2 years ago
3d15283e43
Merge remote-tracking branch 'origin/CLDC-1917-allow-23/24-form' into CLDC-1917-allow-23/24-form
2 years ago
73a333fb68
refactor: linting
2 years ago
e21b7b81f0
Merge branch 'main' into CLDC-1917-allow-23/24-form
2 years ago
1913f6a685
db:update
2 years ago
0595b32254
Merge branch 'main' into CLDC-1917-allow-23/24-form
...
# Conflicts:
# db/schema.rb
2 years ago
3929a2c08b
feat: add more tests
2 years ago
7c62d8b4a6
Change CDS export archive names from quarter to financial year ( #1309 )
...
- We previously pushed logs into archives categorised by the quarter that they were created for.
- CDS requested that instead we push everything into a larger bucket seperated by FY.
2 years ago
02d8247f59
tweak bulk upload validation ( #1302 )
...
- LA referral not permitted if general needs and now also if owning
org is an LA
2 years ago
c19b200e84
Add arcturus.net to whitelisted delivery domains ( #1316 )
...
- We whitelist domains that we will deliver to in non-production environments
- This adds arcturus.net so that they can conduct their pentest
2 years ago
26aa5244bb
mass update gems used by docs ( #1313 )
2 years ago
b6ff8bf896
CLDC-1909 Add 2023-2024 collection year filter ( #1314 )
2 years ago
f4608d046f
test: update
2 years ago
fc2302e312
test: update
2 years ago
65bde2b7f5
CLDC-1903 Infer first time property let question ( #1300 )
2 years ago
d8689c30a2
CLDC-1968 Add review page for Sales logs ( #1292 )
...
* CLDC-1968 Add review page for Sales logs
* use log#sales?
* Do not use type checking
2 years ago
293077695c
Allow issues/pull-request write permissions for GitHub token ( #1310 )
2 years ago
b973e8348e
CLDC-1861 Update options order for lead tenant's working situation ( #1289 )
...
* Switch the first two options so Full time comes before Part time
* Enable dates validations on staging
2 years ago
ef0fc992e7
CLDC-1906 infer offered ( #1298 )
...
* feat: infer offered if renewal
* feat: update test
* db:update
2 years ago
be3e782a0e
Add 2023 sales validations ( #1305 )
2 years ago
2b918a09d7
Rename lettings log export field `form` to `formid` ( #1306 )
2 years ago
d3e59254d0
refactor: remove comments
2 years ago
98dc083e1a
feat: add separate validations for crossover and non-crossover
2 years ago
02f04fde60
CLDC-1884 Bulk upload disability access fields and validations ( #1299 )
...
* bulk upload considers housing needs fields
* bulk upload only permits one housing needs type
* add bulk upload validation
- no disabled needs cannot be selected in conjunction with a disabled need
* add bulk upload validation
- dont know disabled needs cannot be selected in conjunction with a disabled need
* add bulk upload validation
- no and don't know disabled access needs cannot be selected together
2 years ago
00cb234797
CLDC-1811 Add buyer 2 ethnicity question for 23/24 form ( #1287 )
...
* Add buyer 2 ethnic questions and pages
* Add ethnic fields for buyer 2
* Add the new questions to the correct year
2 years ago
8b86a750e6
feat: allow next collection year
2 years ago
8879748f82
only load session fiters when getting or exporting the logs ( #1301 )
2 years ago
92029ea2a0
CLDC-859 Sales validation - bedsits cannot have more than 1 bed ( #1188 )
...
* feat: add sales validation to check bedsits have <=1 beds
* test: sales validation to check bedsits have <=1 beds
* fix: typo in property validation method name
* feat: add same bedsit validation to number of bedrooms question
* test: fix typo propert -> property in property validations tests
* test: add test for validate_property_number_of_bedrooms (sales)
* feat: update wording for 'number of bedrooms' validation when bedsit
* test: condense sales property validations tests
* test: strengthen sales property validations error addition test
* refactor: simplify sales property validations into one method
* fix: update error message content to match Beth's choices
* chore: lint
* test: add requests test for invalid sales log params when posting
* refactor: use if rather than unless... not in property validation
* refactor: write method is_bedsit? on SalesLog
* test: check bedsit error not added if proptype or beds is nil
* lint: use update! not update
* feat: update validation messages to improve readability
* fix: provide valid date in request test for invalid proptype/beds
* feat: make is_bedsit and validate_bedsit_number_of_beds more readable
2 years ago
6c0780291b
CLDC-1810 new staircasing followup ( #1286 )
...
* feat: behaviour
* feat: conditional year behaviour and test
* refactor: linting
* db: update
2 years ago
ca8b797012
bulk upload ignores blank rows in csv ( #1295 )
2 years ago
f0a1e18325
CLDC-1885 Bulk upload type must match given needs type ( #1288 )
...
* bulk upload type must match given needs type
* refactor invert logic statement
* tweak validation copy
2 years ago
0ff387ad84
Remove nils before adding up location units ( #1290 )
2 years ago
c481055f4d
CLDC-1965 Bulk upload correct again email ( #1274 )
...
* tests for bulk upload mailer
* bulk upload send upload again email
2 years ago
466d3fc2cf
CLDC-1809 Add prevshared question ( #1269 )
...
* Add prevshared question
* Update CYA
* Add missing specs
2 years ago
1bc63c9fab
CLDC-1882 Bulk upload validate leaving reason if renewal ( #1278 )
...
* bulk upload validate leaving reason if renewal
* move validation string to locales
2 years ago
f86544bfe6
validate general needs cannot be referred by LA ( #1281 )
2 years ago
144e9dc593
CLDC-1900 improve expired join links ( #1265 )
...
* feat: update expired join link page
* feat: update controller
* feat: show invalid page if token invalid
* feat: add password hint_text
* feat: use new templates
* refactor: min password length simplification
* feat: add dynamic template selection
* feat: revert devise behaviour
* feat: fix initial confirmation sent behaviour
* feat: show invalid page if link invalid
* test: update
* test: add tests for path
* db: update
* refactor: linting
* feat: move initial_confirmation_sent update
* feat: add further reconfirmation to tests
* refactor: simplify by removing before_action
* revert password hint text update (added to cldc-1963 instead)
* feat: reset initial_confirmation_sent if deactivated
* feat: reset initial_confirmation_sent if deactivated
* feat: add flash notice for already confirmed
* feat: fix reset passwords bugs - stop leaking between reset/change routes
* test: add tests for change vs reset password routes
* feat: add reset password persistence
2 years ago
3b2e24bcff
CLDC-1883 bulk upload validate LA and local housing referral ( #1284 )
...
* bulk upload validate LA and local housing referral
* move validation message to locales
2 years ago
fa19f6b783
CLDC-1931 Update outside_collection_window error message ( #1275 )
2 years ago
dd82aee60c
CLDC-1902 update completed text ( #1283 )
...
* Add tests to cover updated header
* Refactor formhandler
2 years ago
2bff6e8092
Do not error if owning_organisation is nil ( #1280 )
2 years ago
natdeanlewissoftwire
natdeanlewissoftwire
James Rose
Phil Lee
Jack
kosiakkatrina
SamSeed-Softwire