kosiakkatrina
d8fa3cf7fe
CLDC-3816 Update rails admin styling ( #2879 )
...
* Update rails admin console layout
* Update dashboard and view tables
* lint
* More lint
* Inline actions
* Re-add filters
* Update buttons
* Update validation documentation generating (#2894 )
* Update documentation generator to use relevant translation files
* Add and use collection_year instead of from/to in log validations
4 days ago
Manny Dinssa
02a77e0889
CLDC-3835: Export merged organisations as inactive ( #2896 )
...
* Export active to CDS as false for merged orgs
* Export status to CDS for orgs
5 days ago
kosiakkatrina
19c5deb1d3
CLDC-3817 Only run net income validations when applicable_income_range exists ( #2882 )
...
* Only run net income validations when applicable_income_range exists
* Check that income ranges exist
5 days ago
Manny Dinssa
02d1c664ef
Fix view bulk uploads and add another status label ( #2883 )
...
* Add another bulk upload status for invalid uploads
* Add test and update text
* update text missed
2 weeks ago
kosiakkatrina
54912a066c
CLDC-3744 Validate correct benefits value in the validation ( #2769 )
...
* Check correct benefits value in the validation
* Update some tests
* Update validation
* clear invalid benefits
* Update more tests
* Fix world
* Clear the benefits
* Move benefits assign
1 month ago
kosiakkatrina
9a164dfa68
Export dates as iso8601 ( #2871 )
1 month ago
kosiakkatrina
8ffc5c6daf
Update rails to 7.2.2 ( #2856 )
...
* Update rails and puma
* Update factory bot, fixture_paths, lint and populate LAs for tests
* Remove enum deprecation warnings
* Fix prefic syntax
* Update paper_trail, add missing translations, lint
* Update some tests
* Update some more gems
* Update npm package
* Update Rails to 7.2.2.1
1 month ago
kosiakkatrina
3a4a8144d5
CLDC-3646 Do not update status for pending logs ( #2851 )
...
* Do not update status for pending logs
* Update some tests
* skip_update_status when unpending logs
1 month ago
kosiakkatrina
ca2d670116
CLDC-3748 Check org name uniqueness ( #2818 )
...
* Check org name uniqueness
* Some tests
* Do not update org name
* Update some request specs
* Remove unnecessary updates
* Update error message
1 month ago
kosiakkatrina
e7490f1381
CLDC-3779 Add duplicate logs email ( #2843 )
...
* Find block log creation reason
* Update mailer
* Remove create_logs? method
1 month ago
kosiakkatrina
9343d22768
CLDC-3335 Adjust BU errors for addresses ( #2829 )
...
* Adjust BU errors for addresses
* typo
* Update error messages
2 months ago
kosiakkatrina
84177349f0
Refactor exports to have years ( #2849 )
...
* Refactor exports to have years
* Update existing exports
* Fix flaky test
* Remove a comment
2 months ago
Rachael Booth
b3dca51216
CLDC-3753: Update soft income validations ( #2779 )
...
* CLDC-3753: Update soft income validations
* Update tests
* Fix linting
* Include reference to informative text translations copy
* Combine min and max checks for income based on ecstat
* Fixes
* Update tests
2 months ago
Rachael Booth
4157a7bb8f
CLDC-3732: Update review apps seeds ( #2834 )
...
* Update seeds
* Fix linting
* Update dsa bits
* Fix duplicate user/org variable names
* Fix create_list
* Set faker locale for development and review
* Update tests that relied on user factory default name
* Update more tests
* Add additional randomness to log factories
* Also create older logs
* Update tests and log randomness
* Ensure sufficient gap between child and parent ages
* More test fixes
* Specify names for users
* Fix more tests
* Fix lint
* More fixes
* More randomness in organisation generation
* Add some extra organisations
* Create future logs if future form use is enabled
* Update tests that expect fixed default org name
* Update more tests
* Fix typo
* Another tweak
* More test fixes
* More test fixes
* Another fix
* Update more tests
* More fixes
* Only create outright sale logs for relevant years
* Reduce max random age to avoid soft validations
* Don't allow sales logs to use no longer valid relat value
* Include fixed locations
2 months ago
kosiakkatrina
5d36a13e7c
Ignore irrelevant empty headers ( #2800 )
2 months ago
kosiakkatrina
8c092a02e2
Update paper form display name ( #2797 )
2 months ago
Rachael Booth
8dab730c54
CLDC-3704: Allow equity/stairowned/stairbought to have 1 decimal place ( #2746 )
...
* CLDC-3666: Pull sales financial validations into translations file
* CLDC-3704: Allow equity/stairowned/stairbought to have 1 decimal place
* Fix lint for migration
* Fix tests
* Fix sale information validations tests
* Fix lint
* Fix form spec
* Don't expect unexpected cashdis error
2 months ago
kosiakkatrina
020b8a4f4c
CLDC-3686 Extract lettings soft validations copy ( #2735 )
...
* Extract household characteristics soft validations
* Extract household needs soft validations
* Extract household situation soft validations
* Extract income and benefits soft validations
* Extract property information soft validations
* Update tests and 2024 soft validations
* Update some test forms
* Re-add sales validation
* Update BU tests
* Fixes
* Change higher to longer
* Update model test
* Update model test
* Add 2025 translations copied from 2024
* Update pregnancy and retirement copy
---------
Co-authored-by: Manny Dinssa <44172848+Dinssa@users.noreply.github.com>
Co-authored-by: Rachael Booth <rachael.booth@softwire.com>
2 months ago
kosiakkatrina
dd9bc7b191
CLDC-3669 Extract bulk upload validations ( #2719 )
2 months ago
kosiakkatrina
1e968e50a6
CLDC-3694 Extract lettings BU validations
2 months ago
kosiakkatrina
f2f44329f3
CLDC-3684 Extract lettings tenancy information copy ( #2731 )
...
* Extract lettings tenancy information copy
* Fix flaky merged schemes test
3 months ago
Rachael Booth
3424cbc550
CLDC-3366: Use single page for rent soft validation ( #2724 )
...
* CLDC-3366: Use single page for rent soft validation
* Fix tests
3 months ago
kosiakkatrina
1ffc440342
CLDC-3656 Extract household characteristics question and page copy to translation files ( #2702 )
...
* Extract question and page copy to translation files
* Refactor 2 question pages
* Readd removed answer options
* Fix missing/wrong age mappings
* Update some pages/questions
* Update tests
* CLDC-3656 Extract household characteristics soft validations (#2707 )
* Extract retirement confirmation questions
* Extract old persons shared ownership confirmation questions
* Extract income confirmation questions
* Extract buyer live-in value check page and question copy to translation files
* Extract student not a child confirmation questions and page copy to translation files
* Extract partner under 16 value check page and question copy to translation files
* Extract partner under 16 value check page and question copy to translation files
* Update some missing/wrong keys
* Update some keys on 2023
* Update BU tests
3 months ago
kosiakkatrina
64caf018e0
CLDC-2413 Allow 4 digit year format for bulk uploads ( #2715 )
...
* Allow 4 digit years for start date/sale date
* Update other dates
3 months ago
kosiakkatrina
e71b2aeb9f
CLDC-3638 Allow adding custom resources ( #2690 )
...
* Stub some collection resource requests
* Rebase changes
* Add upload new resource page
* Allow adding custom collection resources
* Display and validate additional resources
* Allow downloading additional collection resources
* Allow updating additional resources
* Display additional resources on the homepage
* Add delete link to additional resources
* Update hint text
* Update tests
* Allow unauthenticated users to donwload additional collection resources
* Add some changes to copy and styling
* Add content type to the files
* Validate short display name at the same time as file
3 months ago
Rachael Booth
2974bcddd7
CLDC-3330: Use partial postcodes in bulk upload ( #2692 )
...
* CLDC-3330: Use partial postcodes in bulk upload
* Adjust key address fields provided validations
* Use join to only insert space when both parts of postcode are provided
3 months ago
kosiakkatrina
932e766cf8
CLDC-3518 Add collection resources page ( #2673 )
...
* Dynamically display collection resources for years
* Display mandatory resources on collection resources page
* Move download resources to collection resources controller and refactor routes
* Put managing resources button behind a feature flag
* Everyone should be able to download mandatory resources
* Remove mentions of legacy template and update bu path methods
* Update styling
* Update tests and routes
* CLDC-3518 Allow updating mandatory collection resources (#2676 )
* Add update resource page
* Allow updating mandatory collection resources
* CLDC-3518 Add file validation to collection resources (#2678 )
* Add file validation to collection resources
* Move some tests to feature tests
* Extract validations into translations file
* Rebase changes
* More rebase updates
* Read file
* Update tests
3 months ago
Manny Dinssa
b1ad8a1520
CLDC-3633++ Full stops in error messages & capitalisation within messages ( #2674 )
3 months ago
Rachael Booth
35100ab7fe
CLDC-3413: Make BU validate_nulls account for errors on before_log when choosing whether to add errors ( #2686 )
3 months ago
Manny Dinssa
ec55d405e1
CLDC-3618: Support user - View bulk uploads page ( #2666 )
3 months ago
kosiakkatrina
54d15d95ef
CLDC-3420 Check tshortfall for care homes ( #2659 )
...
* Check tshortfall for care homes
* Fix BU tests
3 months ago
Manny Dinssa
53c3b3e61a
CLDC-3633 Full stops in error messages ( #2628 )
...
* Make full stops consistent in error messages
* Fix test
* Update few hardcoded errors
* Update join in remaining row parsers
* Update some more tests
* Update more hard coded BU errors
* Fix typo I introduced - bedrooms to bedroom
---------
Co-authored-by: Kat <katrina@kosiak.co.uk>
Co-authored-by: kosiakkatrina <54268893+kosiakkatrina@users.noreply.github.com>
4 months ago
kosiakkatrina
f269a88abc
Update xml exports ( #2543 )
...
* Refactor manifest creation into a separate job
* Add users export service
* Call user export service
* Rename exports table
* Update data export job spec
* Update naming
* Refactor shared logic into parent class
* Update initialize
* Allow exporting users individually
* Update data export task tests
* Move method and update task argument
* Add phone extension to the user export
* Add static period to filename
* Make recent logs export depend on the collection
* CLDC-3534 Export organisation data (#2599 )
* Add organisation export service
* Call organisations export and write manifest
* Add some additional fields to export
* Add period to organisation export filename
* Update provider_type and add new fields
* Filter exports by the collection
* Update tests
* Update fields exported in lettings export (#2652 )
* Add new fields for user ids (#2661 )
* Undo lettings export field changes
4 months ago
Manny Dinssa
d0ce0b87f2
CLDC 3623 Support user bulk uploading ( #2629 )
4 months ago
kosiakkatrina
204e022c8f
Refactor postcode tests to use webmock stubs ( #2651 )
4 months ago
Rachael Booth
380d63c367
CLDC-3244: Replace postcodes_io gem to improve error handling ( #2634 )
...
* CLDC-3244: Replace postcodes_io gem to improve error handling
* Fix status code in default postcodes api mocking
* Fix more mocking
* Remove blank line
* Handle non-Excon errors, in case of unexpected api behaviour
* Remove outdated test
* Remove another outdated test
4 months ago
kosiakkatrina
c3bfadfe7f
Empty bulk upload row parsing ( #2638 )
...
* empty
* Add stripped_row back
* Skip empty rows
4 months ago
kosiakkatrina
c45cb160d2
Do not check duplicates on empty rows ( #2636 )
4 months ago
Manny Dinssa
92aeb737a2
CLDC 3241: Part 2 - Explanation of variables on CSVs ( #2610 )
...
* Add variable definitions as the first row of csv downloads
5 months ago
Manny Dinssa
4746161488
CLDC-3241: Part 1 - Explanation of variables on CSVs ( #2585 )
...
* Create CsvVariableDefinition migration and model
* Add definition files
* Add CsvVariableDefinitions to rails admin
* Create rake and service
* Create tests
* Additional fixes
* Rollback unwanted changes to schema
* Update Gemfile.lock
5 months ago
Manny Dinssa
6596351937
Revert "CLDC-3241: Part 2 - Explanation of variables on CSVs" ( #2609 )
...
* Revert "CLDC-3241: Part 2 - Explanation of variables on CSVs (#2586 )"
This reverts commit e045588775
.
* Update Gemfile.lock
5 months ago
Manny Dinssa
e045588775
CLDC-3241: Part 2 - Explanation of variables on CSVs ( #2586 )
...
* Create CsvVariableDefinition migration and model
* Add definition files
* Add CsvVariableDefinitions to rails admin
* Create rake and service
* Create tests
* Additional fixes
* Rollback unwanted changes to schema
* Add variable definitions as the first row of csv downloads
* Add and update tests
* Fix lint offences
* Update Gemfile.lock
5 months ago
kosiakkatrina
459420d7ee
CLDC-3541 Update sales financial validations ( #2546 )
...
* CLDC-3569 Update social homebuy errors (#2541 )
* Split questions
* Update the error message
* Add guidance
* Add back the headers
* Refactor depends_on
* Refactor further
* CLDC-3569 Update missed errors (#2548 )
* Update some skipped error messages
* Remove repeating deposit question
* CLDC-3571 Discounted ownership validation (#2547 )
* Rename discount to deposit discount
* Split about price rtb questions
* Update error message
* Update guidance partial
* Fix top_guidance_partial method
* Split about_price_not_rtb
* Update guidance partial and validation
* Fix bulk upload test
* Update deposit routed_to and guidance
* Refactor guidance links into a helper (#2551 )
* Refactor guidance links into a helper
* Refactor discounted ownership guidance
* CLDC-3570 Validations all other shared ownership types (#2550 )
* Update "all other shared ownership" errors
* CLDC-3571 Update outright sale financial validations (#2549 )
* Update outright sale validation message
* Add outright sale guidance
* Update duplicate page id
* User guidance helper
* Fix up financial equations content (#2552 )
* Tweak shared ownership validation wording
* Add top_guidance_partial to missed shared ownership questions
* Update discounted ownership validation message when there's no grant
* Update discounted sale guidance and errors
* Lint and update test
* Update BU test
* Update test
* CLDC-3569 Update guidance for shared ownership without mortgage (#2562 )
* Update how we display errors for BU
* Update guidance for shared ownership
* Add header to mortgage used question
* Update shared ownership guidance
* Update spacing (#2569 )
* Fix spacing again (#2570 )
* Update discounted ownership guidance (#2582 )
* Update discounted ownership guidance
* Add top guidance partial to outright sale
* Update outright sale guidance content
* Update model test
---------
Co-authored-by: Manny Dinssa <44172848+Dinssa@users.noreply.github.com>
5 months ago
Rachael Booth
85bbbe6108
CLDC-3556: Ignore address data in bulk upload for supported housing logs ( #2540 )
...
* Only set address data in BU for general needs logs
* Don't route to uprn selection page for supported housing logs
* Fix tests
5 months ago
Manny Dinssa
1da04df30f
CLDC-3411 correct 24 25 bulk upload error messages on lettings and sales ( #2556 )
...
* Update error messages and sales parser
5 months ago
Manny Dinssa
c3b85f2b50
CLDC-3411: Correct 24/25 bulk upload error messages on lettings and sales ( #2553 )
5 months ago
Rachael Booth
6a42978fab
CLDC-3546: Add error to managing org when it does not have relevant rent period ( #2538 )
...
* CLDC-3546: Add error to managing org when it does not have relevant rent period
* Add test for :skip_bu_error
* Fix managing org question id
6 months ago
Rachael Booth
975f072d2f
CLDC-3547: Validate against incomplete schemes being used in logs ( #2498 )
...
* CLDC-3547: Validate against incomplete schemes being used in logs
* Fix ordering issue in tests
6 months ago
Manny Dinssa
8af9c255e3
CLDC-3567-Remove-DLUHC-references-from-CORE-pages ( #2530 )
6 months ago
kosiakkatrina
b9f900c98e
CLDC-3550 Fix rent_type 2024 BU mapping ( #2501 )
...
* Fix rent_type 2024 BU mapping
* Correct rent_type values
* Reuse rent_type mapping
* Track updated bulk uploads
* Fix test
6 months ago