Manny Dinssa
							
						 
						
							 
							
							
							
								
							
								d4d114e8a4 
								
							
								 
							
						 
						
							
							
								
								Set uprn selection default header  
							
							 
							
							
 
							
						 
						
							1 year ago  
						
					 
				
					
						
							
							
								 
								Manny Dinssa
							
						 
						
							 
							
							
							
								
							
								ea6a84f239 
								
							
								 
							
						 
						
							
							
								
								Set uprn confirmation default header  
							
							 
							
							
 
							
						 
						
							1 year ago  
						
					 
				
					
						
							
							
								 
								Manny Dinssa
							
						 
						
							 
							
							
							
								
							
								498c32baaa 
								
							
								 
							
						 
						
							
							
								
								Add sales soft validations  
							
							 
							
							
 
							
						 
						
							1 year ago  
						
					 
				
					
						
							
							
								 
								Manny Dinssa
							
						 
						
							 
							
							
							
								
							
								16e16117d3 
								
							
								 
							
						 
						
							
							
								
								Remove copy key from uprn_confirmation  
							
							 
							
							
 
							
						 
						
							1 year ago  
						
					 
				
					
						
							
							
								 
								Manny Dinssa
							
						 
						
							 
							
							
							
								
							
								b7c3222a35 
								
							
								 
							
						 
						
							
							
								
								Add back removed id  
							
							 
							
							
 
							
						 
						
							1 year ago  
						
					 
				
					
						
							
							
								 
								Manny Dinssa
							
						 
						
							 
							
							
							
								
							
								bc5ba65b88 
								
							
								 
							
						 
						
							
							
								
								Keep existing details for monthly charged check, common to other subsections  
							
							 
							
							
 
							
						 
						
							1 year ago  
						
					 
				
					
						
							
							
								 
								Manny Dinssa
							
						 
						
							 
							
							
							
								
							
								d7e2a6bf8d 
								
							
								 
							
						 
						
							
							
								
								Keep existing details for combined income check, common to other subsections  
							
							 
							
							
 
							
						 
						
							1 year ago  
						
					 
				
					
						
							
							
								 
								Manny Dinssa
							
						 
						
							 
							
							
							
								
							
								4380e440a8 
								
							
								 
							
						 
						
							
							
								
								Keep existing details for buyer income 1 and 2 check, common to other subsections  
							
							 
							
							
 
							
						 
						
							1 year ago  
						
					 
				
					
						
							
							
								 
								Manny Dinssa
							
						 
						
							 
							
							
							
								
							
								df45443f6c 
								
							
								 
							
						 
						
							
							
								
								Keep existing header and check answer label for about price value check, common to other subsections  
							
							 
							
							
 
							
						 
						
							1 year ago  
						
					 
				
					
						
							
							
								 
								Manny Dinssa
							
						 
						
							 
							
							
							
								
							
								a035a221e7 
								
							
								 
							
						 
						
							
							
								
								Keep default page header for uprn confirmation and selection  
							
							 
							
							
 
							
						 
						
							1 year ago  
						
					 
				
					
						
							
							
								 
								Manny Dinssa
							
						 
						
							 
							
							
							
								
							
								331b308818 
								
							
								 
							
						 
						
							
							
								
								Remove 2022-only property questions and pages  
							
							 
							
							
 
							
						 
						
							1 year ago  
						
					 
				
					
						
							
							
								 
								Manny Dinssa
							
						 
						
							 
							
							
							
								
							
								4fd2c732e2 
								
							
								 
							
						 
						
							
							
								
								Fix copy key  
							
							 
							
							
 
							
						 
						
							1 year ago  
						
					 
				
					
						
							
							
								 
								Manny Dinssa
							
						 
						
							 
							
							
							
								
							
								898768019b 
								
							
								 
							
						 
						
							
							
								
								Add page headers  
							
							 
							
							
 
							
						 
						
							1 year ago  
						
					 
				
					
						
							
							
								 
								Manny Dinssa
							
						 
						
							 
							
							
							
								
							
								f75c5f3ba2 
								
							
								 
							
						 
						
							
							
								
								Move question details to translation files  
							
							 
							
							
 
							
						 
						
							1 year ago  
						
					 
				
					
						
							
							
								 
								Rachael Booth
							
						 
						
							 
							
							
							
								
							
								713fb83c7a 
								
							
								 
							
						 
						
							
							
								
								Handle when some text is undefined in questions not yet using translation files  
							
							 
							
							
 
							
						 
						
							1 year ago  
						
					 
				
					
						
							
							
								 
								Rachael Booth
							
						 
						
							 
							
							
							
								
							
								f359ac326a 
								
							
								 
							
						 
						
							
							
								
								Tidy  
							
							 
							
							
 
							
						 
						
							1 year ago  
						
					 
				
					
						
							
							
								 
								Rachael Booth
							
						 
						
							 
							
							
							
								
							
								4901547d03 
								
							
								 
							
						 
						
							
							
								
								Tidy  
							
							 
							
							
 
							
						 
						
							1 year ago  
						
					 
				
					
						
							
							
								 
								Rachael Booth
							
						 
						
							 
							
							
							
								
							
								f892f75631 
								
							
								 
							
						 
						
							
							
								
								More fixes  
							
							 
							
							
 
							
						 
						
							1 year ago  
						
					 
				
					
						
							
							
								 
								Rachael Booth
							
						 
						
							 
							
							
							
								
							
								bd69ec56d4 
								
							
								 
							
						 
						
							
							
								
								More fixes  
							
							 
							
							
 
							
						 
						
							1 year ago  
						
					 
				
					
						
							
							
								 
								Rachael Booth
							
						 
						
							 
							
							
							
								
							
								c9192aa4d6 
								
							
								 
							
						 
						
							
							
								
								Fix page header  
							
							 
							
							
 
							
						 
						
							1 year ago  
						
					 
				
					
						
							
							
								 
								Rachael Booth
							
						 
						
							 
							
							
							
								
							
								27fc1277ae 
								
							
								 
							
						 
						
							
							
								
								Remove test word  
							
							 
							
							
 
							
						 
						
							1 year ago  
						
					 
				
					
						
							
							
								 
								Rachael Booth
							
						 
						
							 
							
							
							
								
							
								bd47018f47 
								
							
								 
							
						 
						
							
							
								
								CLDC-3650: Pull out copy for sales setup section questions to translation file  
							
							 
							
							
 
							
						 
						
							1 year ago  
						
					 
				
					
						
							
							
								 
								Rachael Booth
							
						 
						
							 
							
							
								
								
							
							
								
							
								961f1b7f93 
								
									
								
							
								 
							
						 
						
							
							
								
								CLDC-3423: Add sales soft validation for person over retirement age not retired ( #2644 )  
							
							 
							
							... 
							
							
 
							
							* CLDC-3423: Add sales soft validation for person over retirement age not retired
* Add rake task to recalculate log status when new validation is triggered 
							
						 
						
							1 year ago  
						
					 
				
					
						
							
							
								 
								Rachael Booth
							
						 
						
							 
							
							
							
								
							
								615ebfeff8 
								
							
								 
							
						 
						
							
							
								
								WIP  
							
							 
							
							
 
							
						 
						
							1 year ago  
						
					 
				
					
						
							
							
								 
								Rachael Booth
							
						 
						
							 
							
							
							
								
							
								eeca40521f 
								
							
								 
							
						 
						
							
							
								
								WIP  
							
							 
							
							
 
							
						 
						
							1 year ago  
						
					 
				
					
						
							
							
								 
								kosiakkatrina
							
						 
						
							 
							
							
								
								
							
							
								
							
								8516aa1f23 
								
									
								
							
								 
							
						 
						
							
							
								
								Don't hide person known question in CYA ( #2641 )  
							
							 
							
							
 
							
						 
						
							1 year ago  
						
					 
				
					
						
							
							
								 
								kosiakkatrina
							
						 
						
							 
							
							
								
								
							
							
								
							
								d5f2424247 
								
									
								
							
								 
							
						 
						
							
							
								
								CLDC-3576 Update soft pregnancy validation ( #2640 )  
							
							 
							
							... 
							
							
 
							
							* Update soft pregnancy validation
* Fix tests 
							
						 
						
							1 year ago  
						
					 
				
					
						
							
							
								 
								kosiakkatrina
							
						 
						
							 
							
							
								
								
							
							
								
							
								459420d7ee 
								
									
								
							
								 
							
						 
						
							
							
								
								CLDC-3541 Update sales financial validations ( #2546 )  
							
							 
							
							... 
							
							
 
							
							* CLDC-3569 Update social homebuy errors (#2541 )
* Split questions
* Update the error message
* Add guidance
* Add back the headers
* Refactor depends_on
* Refactor further
* CLDC-3569 Update missed errors (#2548 )
* Update some skipped error messages
* Remove repeating deposit question
* CLDC-3571 Discounted ownership validation (#2547 )
* Rename discount to deposit discount
* Split about price rtb questions
* Update error message
* Update guidance partial
* Fix top_guidance_partial method
* Split about_price_not_rtb
* Update guidance partial and validation
* Fix bulk upload test
* Update deposit routed_to and guidance
* Refactor guidance links into a helper (#2551 )
* Refactor guidance links into a helper
* Refactor discounted ownership guidance
* CLDC-3570 Validations all other shared ownership types (#2550 )
* Update "all other shared ownership" errors
* CLDC-3571 Update outright sale financial validations (#2549 )
* Update outright sale validation message
* Add outright sale guidance
* Update duplicate page id
* User guidance helper
* Fix up financial equations content (#2552 )
* Tweak shared ownership validation wording
* Add top_guidance_partial to missed shared ownership questions
* Update discounted ownership validation message when there's no grant
* Update discounted sale guidance and errors
* Lint and update test
* Update BU test
* Update test
* CLDC-3569 Update guidance for shared ownership without mortgage (#2562 )
* Update how we display errors for BU
* Update guidance for shared ownership
* Add header to mortgage used question
* Update shared ownership guidance
* Update spacing (#2569 )
* Fix spacing again (#2570 )
* Update discounted ownership guidance (#2582 )
* Update discounted ownership guidance
* Add top guidance partial to outright sale
* Update outright sale guidance content
* Update model test
---------
Co-authored-by: Manny Dinssa <44172848+Dinssa@users.noreply.github.com> 
							
						 
						
							1 year ago  
						
					 
				
					
						
							
							
								 
								Rachael Booth
							
						 
						
							 
							
							
								
								
							
							
								
							
								85bbbe6108 
								
									
								
							
								 
							
						 
						
							
							
								
								CLDC-3556: Ignore address data in bulk upload for supported housing logs ( #2540 )  
							
							 
							
							... 
							
							
 
							
							* Only set address data in BU for general needs logs
* Don't route to uprn selection page for supported housing logs
* Fix tests 
							
						 
						
							1 year ago  
						
					 
				
					
						
							
							
								 
								Manny Dinssa
							
						 
						
							 
							
							
								
								
							
							
								
							
								c3b85f2b50 
								
									
								
							
								 
							
						 
						
							
							
								
								CLDC-3411: Correct 24/25 bulk upload error messages on lettings and sales ( #2553 )  
							
							 
							
							
 
							
						 
						
							1 year ago  
						
					 
				
					
						
							
							
								 
								kosiakkatrina
							
						 
						
							 
							
							
								
								
							
							
								
							
								0f4bc32d6e 
								
									
								
							
								 
							
						 
						
							
							
								
								CLDC-3465 Update hard validations flow ( #2472 )  
							
							 
							
							... 
							
							
 
							
							* Add check your errors page with clear links
* Update answer links
* Link to check your errors page
* Refactor check errors page
* Allow clearing answers
* Update styling and lint
* Add routing for sales
* lint
* Update page routing test
* Remove unused code
* CLDC-3465 Handle additional errors (#2480 )
* Keep check errors query params
* Add success banner
* Update confirm and continue button
* CLDC-3465 Allow clearing all error questions (#2483 )
* Allow clearing all error questions
* Update setup question link
* Update clear all to ignore setup questions
* Update correct_validation_action_href
* Extract some vriables
* CLDC-3465 Do not display non persisted values in check errors page (#2484 )
* Do not display non persisted values on check_errors page
* Remove govuk button styling from link
* Update warning message
* Update copy 
							
						 
						
							1 year ago  
						
					 
				
					
						
							
							
								 
								Manny Dinssa
							
						 
						
							 
							
							
								
								
							
							
								
							
								8af9c255e3 
								
									
								
							
								 
							
						 
						
							
							
								
								CLDC-3567-Remove-DLUHC-references-from-CORE-pages  ( #2530 )  
							
							 
							
							
 
							
						 
						
							1 year ago  
						
					 
				
					
						
							
							
								 
								Manny Dinssa
							
						 
						
							 
							
							
								
								
							
							
								
							
								fb89b47b6f 
								
									
								
							
								 
							
						 
						
							
							
								
								CLDC-3520 order scheme locations ( #2499 )  
							
							 
							
							... 
							
							
 
							
							* List in alphabetical order using second line of address (.i.e. hint/name) 
							
						 
						
							1 year ago  
						
					 
				
					
						
							
							
								 
								kosiakkatrina
							
						 
						
							 
							
							
								
								
							
							
								
							
								ab4915c2aa 
								
									
								
							
								 
							
						 
						
							
							
								
								CLDC-2480 Allow deleting organisations ( #2459 )  
							
							 
							
							... 
							
							
 
							
							* Add delete confirmation page
* Allow deleting organisation
* Add delete button
* Do not display deleted organisations as an option
* Update policy
* Display informative text and delete org resources
* lint
* Update organisation labels to show when deleted
* Refactor organisation label
* Update more labels
* Remove deleted orgs from schemes and autorize delete_confirmation
* Fix tests 
							
						 
						
							1 year ago  
						
					 
				
					
						
							
							
								 
								kosiakkatrina
							
						 
						
							 
							
							
								
								
							
							
								
							
								07750ef26c 
								
									
								
							
								 
							
						 
						
							
							
								
								CLDC-3289 Avoid freezing time in tests (part 1) ( #2421 )  
							
							 
							
							... 
							
							
 
							
							* Refactor tests #1 
* Refactor helper tests
* Refactor model form tests
* Remove Timecop.returns
* Update tasklist helper tests
* Update task list helper
* Fix test
* Fix flaky search test
* Refactor 
							
						 
						
							1 year ago  
						
					 
				
					
						
							
							
								 
								Arthur Campbell
							
						 
						
							 
							
							
								
								
							
							
								
							
								5696e4b81e 
								
									
								
							
								 
							
						 
						
							
							
								
								Cldc 3452 remove dont know option from mortgage used when invalid ( #2470 )  
							
							 
							
							... 
							
							
 
							
							* initial spec file refactor
remove create for build, extract form to own variable, remove non-valuable tests
run time from 0.29s to0.11s
* refactor to ensure that the questions ownershipsch instance variable and the value of ownershipsch on the log is the same in tests
* delete page test file which is not testing anything meaningful
* add error messages to the I18n yml
* update tests for the validations
* update validation logic
* update tests for the mortgage used question
* update the mortgage used question displayed answer options
* update bulk upload specs to reflect error message updates
* make use of brackets consistent within validation method 
							
						 
						
							1 year ago  
						
					 
				
					
						
							
							
								 
								Arthur Campbell
							
						 
						
							 
							
							
								
								
							
							
								
							
								d95e08cca2 
								
									
								
							
								 
							
						 
						
							
							
								
								Cldc 3492 oustide rent range soft validation not clearing for bedsit ( #2473 )  
							
							 
							
							... 
							
							
 
							
							* mark the beds question as derived when the log is a bedsit to stop it from being cleared
* delete spec file not testing anything worthwhile 
							
						 
						
							1 year ago  
						
					 
				
					
						
							
							
								 
								kosiakkatrina
							
						 
						
							 
							
							
								
								
							
							
								
							
								a85fed42b1 
								
									
								
							
								 
							
						 
						
							
							
								
								CLDC-3504 Update period question options and error message ( #2463 )  
							
							 
							
							... 
							
							
 
							
							* Update displayed_answer_options for period
* Update invalid rent period error message 
							
						 
						
							1 year ago  
						
					 
				
					
						
							
							
								 
								Rachael Booth
							
						 
						
							 
							
							
								
								
							
							
								
							
								34faa74a6c 
								
									
								
							
								 
							
						 
						
							
							
								
								CLDC-3447: Allow decimal discount percentage and increased validation tolerance ( #2427 )  
							
							 
							
							... 
							
							
 
							
							* CLDC-3447: Allow decimal discount percentage and increased validation tolerance
* Update tests to use decimal discount
* Disable extra borrowing soft validation for 2024 onwards
* CLDC-3447: Make tolerance inclusive
* Fix linting error
* Fix method call
* Only change strictness when discount is present
* Remove blank line 
							
						 
						
							1 year ago  
						
					 
				
					
						
							
							
								 
								kosiakkatrina
							
						 
						
							 
							
							
								
								
							
							
								
							
								7d871edf74 
								
									
								
							
								 
							
						 
						
							
							
								
								CLDC-3482 Correct routing to property LA ( #2449 )  
							
							 
							
							... 
							
							
 
							
							* Correct routing to property LA
* Add rake task to update LAs 
							
						 
						
							1 year ago  
						
					 
				
					
						
							
							
								 
								Rachael Booth
							
						 
						
							 
							
							
								
								
							
							
								
							
								730b07ab25 
								
									
								
							
								 
							
						 
						
							
							
								
								CLDC-3426: Ensure outright sale section can be completed with mortgage used unknown ( #2399 )  
							
							 
							
							... 
							
							
 
							
							* CLDC-3426: Ensure outright sale section can be completed with mortgage used unknown
* CLDC-3426: fix test
* CLDC-3426: Refactor tests
* Avoid unnecessarily creating users in sales log factory
* Fix test that inexplicably relies on creation 
							
						 
						
							2 years ago  
						
					 
				
					
						
							
							
								 
								kosiakkatrina
							
						 
						
							 
							
							
								
								
							
							
								
							
								7e638657fb 
								
									
								
							
								 
							
						 
						
							
							
								
								CLDC-3354 Show user input on address selection page ( #2374 )  
							
							 
							
							... 
							
							
 
							
							* Display input playback on the page
* Add input playback to uprn selection pages 
							
						 
						
							2 years ago  
						
					 
				
					
						
							
							
								 
								kosiakkatrina
							
						 
						
							 
							
							
								
								
							
							
								
							
								30bb983e78 
								
									
								
							
								 
							
						 
						
							
							
								
								CLDC-3412 set derived? on mortgage amount ( #2396 )  
							
							 
							
							... 
							
							
 
							
							* Set derived on mortgage amount
* Refactor 
							
						 
						
							2 years ago  
						
					 
				
					
						
							
							
								 
								kosiakkatrina
							
						 
						
							 
							
							
								
								
							
							
								
							
								ad488bb5ce 
								
									
								
							
								 
							
						 
						
							
							
								
								CLDC-3345 Add assigned_to to the exports ( #2391 )  
							
							 
							
							... 
							
							
 
							
							* Empty
* CLDC-3345 Rename created_by to assigned_to (#2372 )
* Rename created_by to assigned_to
* Replace created_by with assigned_to
* Update created_by to assigned_to in exports, remove blank assigned to
* CLDC-3345 Add and set created_by fields (#2373 )
* Add created_by
* Update existing created_by values
* Set created_by on single log
* Set created_by on BU
* Add created_by to exports
* feat: update since last merge
---------
Co-authored-by: natdeanlewissoftwire <nat.dean-lewis@softwire.com>
* Fix papertrail create version
---------
Co-authored-by: natdeanlewissoftwire <nat.dean-lewis@softwire.com> 
							
						 
						
							2 years ago  
						
					 
				
					
						
							
							
								 
								Arthur Campbell
							
						 
						
							 
							
							
								
								
							
							
								
							
								44a0b1acb8 
								
									
								
							
								 
							
						 
						
							
							
								
								CLDC-3405-update-retirement-age-validation ( #2384 )  
							
							 
							
							... 
							
							
 
							
							* update retirement soft validation pages and copy in en.yml to reflect changes in english retirement age
* update soft validation tests to display interruption screens under the correct conditions given changes to state retirement age
reduction of variation in retirement age means lots of code related to determining the retirement age given an individuals gender can also be removed
testing updated 
							
						 
						
							2 years ago  
						
					 
				
					
						
							
							
								 
								natdeanlewissoftwire
							
						 
						
							 
							
							
								
								
							
							
								
							
								1f1df3e77f 
								
									
								
							
								 
							
						 
						
							
							
								
								feat: add new period option ( #2375 )  
							
							 
							
							
 
							
						 
						
							2 years ago  
						
					 
				
					
						
							
							
								 
								kosiakkatrina
							
						 
						
							 
							
							
								
								
							
							
								
							
								eea2aead2c 
								
									
								
							
								 
							
						 
						
							
							
								
								CLDC-3397 Remove hint text from lead tenant questions ( #2378 )  
							
							 
							
							... 
							
							
 
							
							* Remove hint text from lead tenant questions
* Update working situation answer options 
							
						 
						
							2 years ago  
						
					 
				
					
						
							
							
								 
								kosiakkatrina
							
						 
						
							 
							
							
								
								
							
							
								
							
								b83be837ee 
								
									
								
							
								 
							
						 
						
							
							
								
								CLDC-3377 Remove hint text from buyer 1 questions ( #2376 )  
							
							 
							
							... 
							
							
 
							
							* Remove hint text from buyer 1 questions
* Update working situation answer options
* Update missed hint text
* Update csv tests 
							
						 
						
							2 years ago  
						
					 
				
					
						
							
							
								 
								Robert Sullivan
							
						 
						
							 
							
							
								
								
							
							
								
							
								c309a4760b 
								
									
								
							
								 
							
						 
						
							
							
								
								CLDC-3384 referral tests and inconsistencies ( #2370 )  
							
							 
							
							... 
							
							
 
							
							* CLDC-3156: Update 2024 referral options
* CLDC-3156: Add tests for referral question
* CLDC-3156: Update other referral questions
* CLDC-3384: Referral question inconsistencies and tests
* feat: remove option 4 from 24/25 referral
* feat: update tests
---------
Co-authored-by: natdeanlewissoftwire <nat.dean-lewis@softwire.com> 
							
						 
						
							2 years ago  
						
					 
				
					
						
							
							
								 
								natdeanlewissoftwire
							
						 
						
							 
							
							
								
								
							
							
								
							
								a0215d45ef 
								
									
								
							
								 
							
						 
						
							
							
								
								CLDC-3089 Make absolute skip/back links relative ( #2348 )  
							
							 
							
							... 
							
							
 
							
							* Empty-Commit
* feat: make skip links relative
* feat: make scheme back links relative
* feat: update tests 
							
						 
						
							2 years ago