submit-social-housing-lettings-and-sales-data

Commit Graph

Author	SHA1	Message	Date
Rachael Booth	f3151188cf	Another fix	1 year ago
Rachael Booth	99328d545b	Update tests that expect fixed default org name	1 year ago
Rachael Booth	56b9a18b06	More test fixes	1 year ago
Rachael Booth	c756c76c51	Update tests and log randomness	1 year ago
Rachael Booth	bf3405fcc6	Update more tests	1 year ago
Rachael Booth	0bd7a8543f	Update tests that relied on user factory default name	1 year ago
kosiakkatrina	5d36a13e7c	Ignore irrelevant empty headers (#2800 )	1 year ago
kosiakkatrina	8c092a02e2	Update paper form display name (#2797 )	1 year ago
Rachael Booth	8dab730c54	CLDC-3704: Allow equity/stairowned/stairbought to have 1 decimal place (#2746 ) * CLDC-3666: Pull sales financial validations into translations file * CLDC-3704: Allow equity/stairowned/stairbought to have 1 decimal place * Fix lint for migration * Fix tests * Fix sale information validations tests * Fix lint * Fix form spec * Don't expect unexpected cashdis error	1 year ago
kosiakkatrina	020b8a4f4c	CLDC-3686 Extract lettings soft validations copy (#2735 ) * Extract household characteristics soft validations * Extract household needs soft validations * Extract household situation soft validations * Extract income and benefits soft validations * Extract property information soft validations * Update tests and 2024 soft validations * Update some test forms * Re-add sales validation * Update BU tests * Fixes * Change higher to longer * Update model test * Update model test * Add 2025 translations copied from 2024 * Update pregnancy and retirement copy --------- Co-authored-by: Manny Dinssa <44172848+Dinssa@users.noreply.github.com> Co-authored-by: Rachael Booth <rachael.booth@softwire.com>	1 year ago
kosiakkatrina	dd9bc7b191	CLDC-3669 Extract bulk upload validations (#2719 )	1 year ago
kosiakkatrina	1e968e50a6	CLDC-3694 Extract lettings BU validations	1 year ago
kosiakkatrina	f2f44329f3	CLDC-3684 Extract lettings tenancy information copy (#2731 ) * Extract lettings tenancy information copy * Fix flaky merged schemes test	1 year ago
Rachael Booth	3424cbc550	CLDC-3366: Use single page for rent soft validation (#2724 ) * CLDC-3366: Use single page for rent soft validation * Fix tests	1 year ago
kosiakkatrina	1ffc440342	CLDC-3656 Extract household characteristics question and page copy to translation files (#2702 ) * Extract question and page copy to translation files * Refactor 2 question pages * Readd removed answer options * Fix missing/wrong age mappings * Update some pages/questions * Update tests * CLDC-3656 Extract household characteristics soft validations (#2707) * Extract retirement confirmation questions * Extract old persons shared ownership confirmation questions * Extract income confirmation questions * Extract buyer live-in value check page and question copy to translation files * Extract student not a child confirmation questions and page copy to translation files * Extract partner under 16 value check page and question copy to translation files * Extract partner under 16 value check page and question copy to translation files * Update some missing/wrong keys * Update some keys on 2023 * Update BU tests	1 year ago
kosiakkatrina	64caf018e0	CLDC-2413 Allow 4 digit year format for bulk uploads (#2715 ) * Allow 4 digit years for start date/sale date * Update other dates	1 year ago
kosiakkatrina	e71b2aeb9f	CLDC-3638 Allow adding custom resources (#2690 ) * Stub some collection resource requests * Rebase changes * Add upload new resource page * Allow adding custom collection resources * Display and validate additional resources * Allow downloading additional collection resources * Allow updating additional resources * Display additional resources on the homepage * Add delete link to additional resources * Update hint text * Update tests * Allow unauthenticated users to donwload additional collection resources * Add some changes to copy and styling * Add content type to the files * Validate short display name at the same time as file	1 year ago
Rachael Booth	2974bcddd7	CLDC-3330: Use partial postcodes in bulk upload (#2692 ) * CLDC-3330: Use partial postcodes in bulk upload * Adjust key address fields provided validations * Use join to only insert space when both parts of postcode are provided	1 year ago
kosiakkatrina	932e766cf8	CLDC-3518 Add collection resources page (#2673 ) * Dynamically display collection resources for years * Display mandatory resources on collection resources page * Move download resources to collection resources controller and refactor routes * Put managing resources button behind a feature flag * Everyone should be able to download mandatory resources * Remove mentions of legacy template and update bu path methods * Update styling * Update tests and routes * CLDC-3518 Allow updating mandatory collection resources (#2676) * Add update resource page * Allow updating mandatory collection resources * CLDC-3518 Add file validation to collection resources (#2678) * Add file validation to collection resources * Move some tests to feature tests * Extract validations into translations file * Rebase changes * More rebase updates * Read file * Update tests	1 year ago
Manny Dinssa	b1ad8a1520	CLDC-3633++ Full stops in error messages & capitalisation within messages (#2674 )	1 year ago
Rachael Booth	35100ab7fe	CLDC-3413: Make BU validate_nulls account for errors on before_log when choosing whether to add errors (#2686 )	1 year ago
Manny Dinssa	ec55d405e1	CLDC-3618: Support user - View bulk uploads page (#2666 )	1 year ago
kosiakkatrina	54d15d95ef	CLDC-3420 Check tshortfall for care homes (#2659 ) * Check tshortfall for care homes * Fix BU tests	1 year ago
Manny Dinssa	53c3b3e61a	CLDC-3633 Full stops in error messages (#2628 ) * Make full stops consistent in error messages * Fix test * Update few hardcoded errors * Update join in remaining row parsers * Update some more tests * Update more hard coded BU errors * Fix typo I introduced - bedrooms to bedroom --------- Co-authored-by: Kat <katrina@kosiak.co.uk> Co-authored-by: kosiakkatrina <54268893+kosiakkatrina@users.noreply.github.com>	1 year ago
kosiakkatrina	f269a88abc	Update xml exports (#2543 ) * Refactor manifest creation into a separate job * Add users export service * Call user export service * Rename exports table * Update data export job spec * Update naming * Refactor shared logic into parent class * Update initialize * Allow exporting users individually * Update data export task tests * Move method and update task argument * Add phone extension to the user export * Add static period to filename * Make recent logs export depend on the collection * CLDC-3534 Export organisation data (#2599) * Add organisation export service * Call organisations export and write manifest * Add some additional fields to export * Add period to organisation export filename * Update provider_type and add new fields * Filter exports by the collection * Update tests * Update fields exported in lettings export (#2652) * Add new fields for user ids (#2661) * Undo lettings export field changes	1 year ago
Manny Dinssa	d0ce0b87f2	CLDC 3623 Support user bulk uploading (#2629 )	1 year ago
kosiakkatrina	204e022c8f	Refactor postcode tests to use webmock stubs (#2651 )	1 year ago
Rachael Booth	380d63c367	CLDC-3244: Replace postcodes_io gem to improve error handling (#2634 ) * CLDC-3244: Replace postcodes_io gem to improve error handling * Fix status code in default postcodes api mocking * Fix more mocking * Remove blank line * Handle non-Excon errors, in case of unexpected api behaviour * Remove outdated test * Remove another outdated test	1 year ago
kosiakkatrina	c3bfadfe7f	Empty bulk upload row parsing (#2638 ) * empty * Add stripped_row back * Skip empty rows	1 year ago
kosiakkatrina	c45cb160d2	Do not check duplicates on empty rows (#2636 )	1 year ago
Manny Dinssa	92aeb737a2	CLDC 3241: Part 2 - Explanation of variables on CSVs (#2610 ) * Add variable definitions as the first row of csv downloads	1 year ago
Manny Dinssa	4746161488	CLDC-3241: Part 1 - Explanation of variables on CSVs (#2585 ) * Create CsvVariableDefinition migration and model * Add definition files * Add CsvVariableDefinitions to rails admin * Create rake and service * Create tests * Additional fixes * Rollback unwanted changes to schema * Update Gemfile.lock	1 year ago
Manny Dinssa	6596351937	Revert "CLDC-3241: Part 2 - Explanation of variables on CSVs" (#2609 ) * Revert "CLDC-3241: Part 2 - Explanation of variables on CSVs (#2586)" This reverts commit `e045588775`. * Update Gemfile.lock	1 year ago
Manny Dinssa	e045588775	CLDC-3241: Part 2 - Explanation of variables on CSVs (#2586 ) * Create CsvVariableDefinition migration and model * Add definition files * Add CsvVariableDefinitions to rails admin * Create rake and service * Create tests * Additional fixes * Rollback unwanted changes to schema * Add variable definitions as the first row of csv downloads * Add and update tests * Fix lint offences * Update Gemfile.lock	1 year ago
kosiakkatrina	459420d7ee	CLDC-3541 Update sales financial validations (#2546 ) * CLDC-3569 Update social homebuy errors (#2541) * Split questions * Update the error message * Add guidance * Add back the headers * Refactor depends_on * Refactor further * CLDC-3569 Update missed errors (#2548) * Update some skipped error messages * Remove repeating deposit question * CLDC-3571 Discounted ownership validation (#2547) * Rename discount to deposit discount * Split about price rtb questions * Update error message * Update guidance partial * Fix top_guidance_partial method * Split about_price_not_rtb * Update guidance partial and validation * Fix bulk upload test * Update deposit routed_to and guidance * Refactor guidance links into a helper (#2551) * Refactor guidance links into a helper * Refactor discounted ownership guidance * CLDC-3570 Validations all other shared ownership types (#2550) * Update "all other shared ownership" errors * CLDC-3571 Update outright sale financial validations (#2549) * Update outright sale validation message * Add outright sale guidance * Update duplicate page id * User guidance helper * Fix up financial equations content (#2552) * Tweak shared ownership validation wording * Add top_guidance_partial to missed shared ownership questions * Update discounted ownership validation message when there's no grant * Update discounted sale guidance and errors * Lint and update test * Update BU test * Update test * CLDC-3569 Update guidance for shared ownership without mortgage (#2562) * Update how we display errors for BU * Update guidance for shared ownership * Add header to mortgage used question * Update shared ownership guidance * Update spacing (#2569) * Fix spacing again (#2570) * Update discounted ownership guidance (#2582) * Update discounted ownership guidance * Add top guidance partial to outright sale * Update outright sale guidance content * Update model test --------- Co-authored-by: Manny Dinssa <44172848+Dinssa@users.noreply.github.com>	1 year ago
Rachael Booth	85bbbe6108	CLDC-3556: Ignore address data in bulk upload for supported housing logs (#2540 ) * Only set address data in BU for general needs logs * Don't route to uprn selection page for supported housing logs * Fix tests	1 year ago
Manny Dinssa	1da04df30f	CLDC-3411 correct 24 25 bulk upload error messages on lettings and sales (#2556 ) * Update error messages and sales parser	1 year ago
Manny Dinssa	c3b85f2b50	CLDC-3411: Correct 24/25 bulk upload error messages on lettings and sales (#2553 )	1 year ago
Rachael Booth	6a42978fab	CLDC-3546: Add error to managing org when it does not have relevant rent period (#2538 ) * CLDC-3546: Add error to managing org when it does not have relevant rent period * Add test for :skip_bu_error * Fix managing org question id	1 year ago
Rachael Booth	975f072d2f	CLDC-3547: Validate against incomplete schemes being used in logs (#2498 ) * CLDC-3547: Validate against incomplete schemes being used in logs * Fix ordering issue in tests	1 year ago
Manny Dinssa	8af9c255e3	CLDC-3567-Remove-DLUHC-references-from-CORE-pages (#2530 )	1 year ago
kosiakkatrina	b9f900c98e	CLDC-3550 Fix rent_type 2024 BU mapping (#2501 ) * Fix rent_type 2024 BU mapping * Correct rent_type values * Reuse rent_type mapping * Track updated bulk uploads * Fix test	1 year ago
Rachael Booth	636e40fc9d	CLDC-3505: Fix tests for hard year end part 4 (#2509 ) * Add in past end dates for testing * Temporarily disable test marked to delete at year end * Remove one off reinfer_local_authority task * Update validator_spec * Set 2024 date in form_handler_spec to be during crossover period as needed * Use bulk_upload.year_combo for comparison in request tests to avoid year dependancy * Update BU log creator specs for 2024 * Use year combo function in bulk upload mailer tests * Refactor lettings validator_spec * More fixes * More work on bu validator specs - mostly sales * Remove pre 2023 test * More use of bulk_upload.year_combo in request tests * Fix lint * Tweak bulk upload error row component tests for year changes * Further fixes * Fix 2023 lettings row parser spec * Sales log to csv fix * Refactor BU processor tests * Fix field number row identifier * Fix linting * More years in request spec * fix * Don't use db unnecessarily in financial validations spec * Fix sale date changing 2024 -> 2023 test * Add tests for bulk_upload.year_combo * Update bu factory year specification * Refactoring * Linting * Don't use helper in factory * Remove new 2023 specific test * Remove dummy end dates	1 year ago
kosiakkatrina	8ce22d37c0	CLDC-3289 Avoid freezing time (part 3) (#2445 ) * Refactor tests #1 * Update tasklist helper tests * Update task list helper * Fix test * Rabase fixes * Update model/validations tests * Update som sales log specs * Remove missing addresses csv tasks * Update some tests for 2023 collection close * More fixes * Revert sales shared examples change * Fix test * Update test nemes, remove time stub	1 year ago
Arthur Campbell	f423ec1cd5	CLDC-3505 further fixes to tests for year hard end (#2493 ) * further fixes * Fix date / crossover issues * Try changing form end dates * Revert "Try changing form end dates" This reverts commit `e027e29cf0`. * Make use of :ignore-validation-errors trait * Try with end dates in past * Revert "Try with end dates in past" This reverts commit `6b87938d70`. --------- Co-authored-by: Rachael Booth <rachael.booth@softwire.com>	1 year ago
kosiakkatrina	8dcd80e4f8	Strip scheme ID (#2487 )	1 year ago
kosiakkatrina	5947a2027a	CLDC-3496 Move period creation to log (#2490 ) * Move period creation to log * Allow adding rent periods to organisations * Update more tests	2 years ago
Rachael Booth	22522fb907	CLDC-3265: Duplicate whitespace row fix to sales BU (#2481 ) * CLDC-3265: Duplicate whitespace row fix to sales BU * CLDC-3265: Fix bu test that accidentally had whitespace only row	2 years ago
kosiakkatrina	4c0c0d15eb	CLDC-3508 Search both datasets for UPRN (#2479 ) * Search both datasets for UPRN * Update presenter * Update request stubs	2 years ago
Rachael Booth	0718c10847	CLDC-3522: Correct logic around BU address search and address not found errors (#2476 ) * CLDC-3522: Correct logic around BU address search and address not found errors * Fix lint errors	2 years ago

1 2 3 4 5 ...

515 Commits (f3151188cf4a6b5c472aba7de2c8eac16d4e46e1)