f52a9d2587
Fix incorrect filtering of relationships and count
2 years ago
7b38c408e5
CLDC-3604 View logs outcomes ( #2618 )
...
* Update view logs outcomes link
* Add logs outcomes page
* Set logs outcome before merge and on merge fail
* Update logs outcomes text
* Update line break
2 years ago
ad6053bd6d
Return correct status when existing_absorbing_organisation is false ( #2617 )
2 years ago
2d2989cc67
CLDC-3609 Add existing absorbing organisation merge request question ( #2600 )
...
* Add existing absorbing organisation page and field
* Update status calculation and add new question to check answers
* Call correct merge service flow
* Update test
* Update test
2 years ago
45abd272c9
CLDC-3605 View relationships page ( #2606 )
2 years ago
d845fa9b03
CLDC-3603 View scheme outcomes ( #2604 )
...
* Update scheme outcomes view link
* Add scheme outcomes page
* Update scheme outcome before merge and on merge fail
2 years ago
1af87119ae
CLDC-3603 View merged users outcomes ( #2602 )
...
* Update user outcomes view link
* Add user outcomes page
* Set user outcomes before merge and on merge fail
* Update hardcoded total user count
* Account for singular user numbers
2 years ago
b0c77a7164
Make merge request status dynamic ( #2592 )
...
* Make merge request status dynamic
* Update tests
2 years ago
5fc89a5a26
CLDC-2101 Add begin merge ( #2575 )
...
* Calculate merge request status
* Add start merge and merge request job
* Update merge request when it gets processed
* Refactor and display a banner for failed requests
* update test
* Update change links
2 years ago
bd6ccdbf8f
Create delete merge request functionality ( #2568 )
2 years ago
804fc45bc7
CLDC-3586 Update merge date merge request question ( #2571 )
...
* Remove unused paths and update merge date
* lint
2 years ago
a74451327e
CLDC-3584 Update merging orgs question ( #2567 )
...
* Update merging organisations question
* Update rebase tests
* Update routing between CYA and questions
2 years ago
ef0ee4f633
CLDC 2094: View a merge request ( #2565 )
2 years ago
11331a9002
CLDC-2093 Merge organisations page - view all merge requests ( #2561 )
2 years ago
4746161488
CLDC-3241: Part 1 - Explanation of variables on CSVs ( #2585 )
...
* Create CsvVariableDefinition migration and model
* Add definition files
* Add CsvVariableDefinitions to rails admin
* Create rake and service
* Create tests
* Additional fixes
* Rollback unwanted changes to schema
* Update Gemfile.lock
2 years ago
6596351937
Revert "CLDC-3241: Part 2 - Explanation of variables on CSVs" ( #2609 )
...
* Revert "CLDC-3241: Part 2 - Explanation of variables on CSVs (#2586 )"
This reverts commit e045588775
2 years ago
e045588775
CLDC-3241: Part 2 - Explanation of variables on CSVs ( #2586 )
...
* Create CsvVariableDefinition migration and model
* Add definition files
* Add CsvVariableDefinitions to rails admin
* Create rake and service
* Create tests
* Additional fixes
* Rollback unwanted changes to schema
* Add variable definitions as the first row of csv downloads
* Add and update tests
* Fix lint offences
* Update Gemfile.lock
2 years ago
4690fb446e
CLDC-3595 Remove duplicate errors for check errors page ( #2560 )
...
* Remove duplicate errors for check errors page
* Remove unused line
* Format some missed errors correctly
2 years ago
ea853c484d
CLDC-3566: Clear duplicate set ids when a log ceases to be a duplicate in normal update flow - with better performance ( #2573 )
...
* Revert "Revert "CLDC-3566: Clear duplicate set ids when a log ceases to be a duplicate through normal update flow (#2534 )" (#2563 )"
This reverts commit 53ae216bae
2 years ago
14d63bd5c4
CLDC-3577: Add optional phone extension to users ( #2597 )
...
* CLDC-3577: Add optional phone extension to users
* CLDC-3577: Validate that phone extension is a number
2 years ago
daff1d637b
Remove old email template ( #2591 )
2 years ago
573e6302bc
CLDC-3600 Clear unconfirmed emails for deactivated users ( #2587 )
...
* Discard email changes when deactivating user
* Clear existing unconfirmed emails
2 years ago
eb355d6829
Update equity validation for resale ( #2559 )
2 years ago
459420d7ee
CLDC-3541 Update sales financial validations ( #2546 )
...
* CLDC-3569 Update social homebuy errors (#2541 )
* Split questions
* Update the error message
* Add guidance
* Add back the headers
* Refactor depends_on
* Refactor further
* CLDC-3569 Update missed errors (#2548 )
* Update some skipped error messages
* Remove repeating deposit question
* CLDC-3571 Discounted ownership validation (#2547 )
* Rename discount to deposit discount
* Split about price rtb questions
* Update error message
* Update guidance partial
* Fix top_guidance_partial method
* Split about_price_not_rtb
* Update guidance partial and validation
* Fix bulk upload test
* Update deposit routed_to and guidance
* Refactor guidance links into a helper (#2551 )
* Refactor guidance links into a helper
* Refactor discounted ownership guidance
* CLDC-3570 Validations all other shared ownership types (#2550 )
* Update "all other shared ownership" errors
* CLDC-3571 Update outright sale financial validations (#2549 )
* Update outright sale validation message
* Add outright sale guidance
* Update duplicate page id
* User guidance helper
* Fix up financial equations content (#2552 )
* Tweak shared ownership validation wording
* Add top_guidance_partial to missed shared ownership questions
* Update discounted ownership validation message when there's no grant
* Update discounted sale guidance and errors
* Lint and update test
* Update BU test
* Update test
* CLDC-3569 Update guidance for shared ownership without mortgage (#2562 )
* Update how we display errors for BU
* Update guidance for shared ownership
* Add header to mortgage used question
* Update shared ownership guidance
* Update spacing (#2569 )
* Fix spacing again (#2570 )
* Update discounted ownership guidance (#2582 )
* Update discounted ownership guidance
* Add top guidance partial to outright sale
* Update outright sale guidance content
* Update model test
---------
Co-authored-by: Manny Dinssa <44172848+Dinssa@users.noreply.github.com>
2 years ago
85bbbe6108
CLDC-3556: Ignore address data in bulk upload for supported housing logs ( #2540 )
...
* Only set address data in BU for general needs logs
* Don't route to uprn selection page for supported housing logs
* Fix tests
2 years ago
72890e516e
CLDC-3564 Update filter search ( #2535 )
...
* Add search controller
* Update on confirm
* lint
* Update search endpoint
* remove assigned to filter options
* Explicitly define host in the url
* Update search controller
* Allow searching organisations
* Allow filtering by user without js
* Allow filtering by org without js
* Add filter_type to method calls
* Update filter helpers
* Hide text search input when js is enabled
* Some feature test updates
* fix model test
* Delete a random file 👀
* lint
* Update more tests
* Update inner text for filter
* Keep csv filters the same
* Clear free text filters for csv dowloads
* User path helper
* Update scheme filters and log scopes
* Update which users we can filter by
2 years ago
979e2a6ba2
Filter out location questions before checking the routing ( #2557 )
2 years ago
c3b85f2b50
CLDC-3411: Correct 24/25 bulk upload error messages on lettings and sales ( #2553 )
2 years ago
6a42978fab
CLDC-3546: Add error to managing org when it does not have relevant rent period ( #2538 )
...
* CLDC-3546: Add error to managing org when it does not have relevant rent period
* Add test for :skip_bu_error
* Fix managing org question id
2 years ago
ba2cf8b4a9
Update location scopes ( #2537 )
2 years ago
9b0cbac406
CLDC 2954 handle schemes with only deactivated locations ( #2510 )
2 years ago
975f072d2f
CLDC-3547: Validate against incomplete schemes being used in logs ( #2498 )
...
* CLDC-3547: Validate against incomplete schemes being used in logs
* Fix ordering issue in tests
2 years ago
0f4bc32d6e
CLDC-3465 Update hard validations flow ( #2472 )
...
* Add check your errors page with clear links
* Update answer links
* Link to check your errors page
* Refactor check errors page
* Allow clearing answers
* Update styling and lint
* Add routing for sales
* lint
* Update page routing test
* Remove unused code
* CLDC-3465 Handle additional errors (#2480 )
* Keep check errors query params
* Add success banner
* Update confirm and continue button
* CLDC-3465 Allow clearing all error questions (#2483 )
* Allow clearing all error questions
* Update setup question link
* Update clear all to ignore setup questions
* Update correct_validation_action_href
* Extract some vriables
* CLDC-3465 Do not display non persisted values in check errors page (#2484 )
* Do not display non persisted values on check_errors page
* Remove govuk button styling from link
* Update warning message
* Update copy
2 years ago
201ce23906
CLDC-1718 Update numeric questions to text fields ( #2527 )
...
* Update numeric questions to text fields
* Add test case
2 years ago
8af9c255e3
CLDC-3567-Remove-DLUHC-references-from-CORE-pages ( #2530 )
2 years ago
b9f900c98e
CLDC-3550 Fix rent_type 2024 BU mapping ( #2501 )
...
* Fix rent_type 2024 BU mapping
* Correct rent_type values
* Reuse rent_type mapping
* Track updated bulk uploads
* Fix test
2 years ago
fb89b47b6f
CLDC-3520 order scheme locations ( #2499 )
...
* List in alphabetical order using second line of address (.i.e. hint/name)
2 years ago
6273a076cb
CLDC-3414&5 Close 2023/24 - No new/No editing of entries ( #2520 )
...
* Close 2023/24
2 years ago
a08f6a6ca8
Allow discarding users for merged orgs ( #2518 )
2 years ago
d2964d73db
CLDC-3549: Ensure location page routing is updated when log is changed ( #2502 )
2 years ago
8ce22d37c0
CLDC-3289 Avoid freezing time (part 3) ( #2445 )
...
* Refactor tests #1
* Update tasklist helper tests
* Update task list helper
* Fix test
* Rabase fixes
* Update model/validations tests
* Update som sales log specs
* Remove missing addresses csv tasks
* Update some tests for 2023 collection close
* More fixes
* Revert sales shared examples change
* Fix test
* Update test nemes, remove time stub
2 years ago
ab4915c2aa
CLDC-2480 Allow deleting organisations ( #2459 )
...
* Add delete confirmation page
* Allow deleting organisation
* Add delete button
* Do not display deleted organisations as an option
* Update policy
* Display informative text and delete org resources
* lint
* Update organisation labels to show when deleted
* Refactor organisation label
* Update more labels
* Remove deleted orgs from schemes and autorize delete_confirmation
* Fix tests
2 years ago
356d652db1
CLDC-3532: Make BU guidance back link depend on referrer ( #2482 )
...
* CLDC-3532: Make BU guidance back link depend on referrer
* Add tests for back_path
* Add guidance to homepage
* CLDC-3526: Update back_path
---------
Co-authored-by: Kat <katrina@kosiak.co.uk>
2 years ago
e566ff09a0
refactor property validations specs to avoid breaking on collection year change ( #2478 )
2 years ago
07750ef26c
CLDC-3289 Avoid freezing time in tests (part 1) ( #2421 )
...
* Refactor tests #1
* Refactor helper tests
* Refactor model form tests
* Remove Timecop.returns
* Update tasklist helper tests
* Update task list helper
* Fix test
* Fix flaky search test
* Refactor
2 years ago
5696e4b81e
Cldc 3452 remove dont know option from mortgage used when invalid ( #2470 )
...
* initial spec file refactor
remove create for build, extract form to own variable, remove non-valuable tests
run time from 0.29s to0.11s
* refactor to ensure that the questions ownershipsch instance variable and the value of ownershipsch on the log is the same in tests
* delete page test file which is not testing anything meaningful
* add error messages to the I18n yml
* update tests for the validations
* update validation logic
* update tests for the mortgage used question
* update the mortgage used question displayed answer options
* update bulk upload specs to reflect error message updates
* make use of brackets consistent within validation method
2 years ago
d95e08cca2
Cldc 3492 oustide rent range soft validation not clearing for bedsit ( #2473 )
...
* mark the beds question as derived when the log is a bedsit to stop it from being cleared
* delete spec file not testing anything worthwhile
2 years ago
a85fed42b1
CLDC-3504 Update period question options and error message ( #2463 )
...
* Update displayed_answer_options for period
* Update invalid rent period error message
2 years ago
34faa74a6c
CLDC-3447: Allow decimal discount percentage and increased validation tolerance ( #2427 )
...
* CLDC-3447: Allow decimal discount percentage and increased validation tolerance
* Update tests to use decimal discount
* Disable extra borrowing soft validation for 2024 onwards
* CLDC-3447: Make tolerance inclusive
* Fix linting error
* Fix method call
* Only change strictness when discount is present
* Remove blank line
2 years ago
8edca7e34b
Update routing for major repairs question ( #2464 )
2 years ago
Manny Dinssa
kosiakkatrina
Rachael Booth
Arthur Campbell